On 26/01/2012 05:21, Lex Trotman wrote:
On Thu, Jan 26, 2012 at 3:41 PM, Matthew Brushmbr...@codebrainz.ca wrote:
On 01/25/2012 06:45 PM, Lex Trotman wrote:
[...]
Hi Matthew,
[...]
utils_is_uri() - good utility function, well named
Indeed well named and probably a little clearer that
On 24/01/2012 03:30, Matthew Brush wrote:
I probably don't know 40%+ of Geany's code after casually hacking on it
for well over a year. When reading the code, I have to refer to the
source file for each function called to see what it does, with GTK+ I've
already done this for many cases, and
[...]
Hi Matthew,
While in general I agree with you, your examples are of mixed
accuracy, see below:
[1] Just at a very quick scan through utils.c, things like
utils_slist_remove_next() - local static used one place, agree no
reason to exist
utils_is_uri() - good utility function, well named
On 01/25/2012 06:45 PM, Lex Trotman wrote:
[...]
Hi Matthew,
While in general I agree with you, your examples are of mixed
accuracy, see below:
[1] Just at a very quick scan through utils.c, things like
utils_slist_remove_next() - local static used one place, agree no
reason to exist
On Thu, Jan 26, 2012 at 3:41 PM, Matthew Brush mbr...@codebrainz.ca wrote:
On 01/25/2012 06:45 PM, Lex Trotman wrote:
[...]
Hi Matthew,
[...]
utils_is_uri() - good utility function, well named
Indeed well named and probably a little clearer that `strstr(uri, ://) !=
NULL` but that's
On 01/23/2012 08:30 AM, Nick Treleaven wrote:
On 22/01/2012 22:00, Lex Trotman wrote:
When working with a common well known library like GTK it is better to
use the well known interface directly rather than creating private
partial wrappers.
Contributors who know GTK don't have to learn the
