Re: [Geeqie-devel] Compiling geeqie on Mac

2009-07-30 Thread Laurent Monin
Martin Proetzsch a écrit : > Hi again, > > > On Jul 28, 2009, at 10:32 PM, Vladimir Nadvornik wrote: > > >> what() is declared like this: >> >> virtual const char* what() const throw() { return msg_.c_str(); } >> >> It should not need another c_str(), >> Which Exiv2 version do you have? >>

Re: [Geeqie-devel] Compiling geeqie on Mac

2009-07-29 Thread Martin Proetzsch
Hi again, On Jul 28, 2009, at 10:32 PM, Vladimir Nadvornik wrote: > what() is declared like this: > > virtual const char* what() const throw() { return msg_.c_str(); } > > It should not need another c_str(), > Which Exiv2 version do you have? I found out that my exiv2 installation was kind of s

Re: [Geeqie-devel] Compiling geeqie on Mac

2009-07-29 Thread Martin Proetzsch
Hi Vladimir On Jul 28, 2009, at 10:27 PM, Vladimir Nadvornik wrote: > The patch looks good. > > Another question is if this mmap hack works on non-linux systems. > It is supposed to handle the situation when an image is truncated > during > reading. > It can be tested with this script: > > whil

Re: [Geeqie-devel] Compiling geeqie on Mac

2009-07-28 Thread Vladimir Nadvornik
On Saturday 25 July 2009 23:27:37 Martin Proetzsch wrote: > The first one is just an explicit cast (seems to be due a more > restrictive compiler), what() is declared like this: virtual const char* what() const throw() { return msg_.c_str(); } It should not need another c_str(), Which Exiv2 vers

Re: [Geeqie-devel] Compiling geeqie on Mac

2009-07-28 Thread Vladimir Nadvornik
On Sunday 26 July 2009 21:09:55 Laurent Monin wrote: > Greg Troxel a écrit : > > and Mac OS X 10.5.7 has MAP_ANON and not MAP_ANONYMOUS. Just dropping > > it seems not justified, but perhaps it is actually ok. > > Yes, instead can you try the attached patch ? > > MAP_ANON should be defined, but no

Re: [Geeqie-devel] Compiling geeqie on Mac

2009-07-27 Thread Laurent Monin
Omari Stephens a écrit : Is this really part of the "Compiling geeqie on Mac" thread? I don't see the connection. --xsdg Martin Proetzsch attached 2 patches in 1 to his first message. It is an attempt to fix 2 compilation issues on MacOs X. The first patch is about MAP_ANON vs MAP_ANO

Re: [Geeqie-devel] Compiling geeqie on Mac

2009-07-27 Thread m . proetzsch
Hi Omari, On Montag 27 Juli 2009, Omari Stephens wrote: > Laurent Monin wrote: > > On ubuntu jaunty i get this compilation error after applying your > > exiv2.cc patch: > ... > Is this really part of the "Compiling geeqie on Mac" thread? I don't see > the connection. > > --xsdg Yes it is, becaus

Re: [Geeqie-devel] Compiling geeqie on Mac

2009-07-27 Thread m . proetzsch
Hi, On Montag 27 Juli 2009, Laurent Monin wrote: > On ubuntu jaunty i get this compilation error after applying your > exiv2.cc patch: > > exiv2.cc: In function ‘void debug_exception(Exiv2::AnyError&)’: > exiv2.cc:106: erreur: request for member ‘c_str’ in > ‘((Exiv2::AnyError*)e)->Exiv2::AnyError

Re: [Geeqie-devel] Compiling geeqie on Mac

2009-07-26 Thread Omari Stephens
Laurent Monin wrote: > Martin Proetzsch a écrit : >> Hello Laurent, >> >> >> On Jul 26, 2009, at 9:09 PM, Laurent Monin wrote: >> >> >>> Yes, instead can you try the attached patch ? >>> >>> MAP_ANON should be defined, but not MAP_ANONYMOUS on some systems, >>> so making an alias should suffice.

Re: [Geeqie-devel] Compiling geeqie on Mac

2009-07-26 Thread Laurent Monin
Martin Proetzsch a écrit : > Hello Laurent, > > > On Jul 26, 2009, at 9:09 PM, Laurent Monin wrote: > > >> Yes, instead can you try the attached patch ? >> >> MAP_ANON should be defined, but not MAP_ANONYMOUS on some systems, >> so making an alias should suffice. >> > > I have done so and g

Re: [Geeqie-devel] Compiling geeqie on Mac

2009-07-26 Thread Martin Proetzsch
Hello Laurent, On Jul 26, 2009, at 9:09 PM, Laurent Monin wrote: > Yes, instead can you try the attached patch ? > > MAP_ANON should be defined, but not MAP_ANONYMOUS on some systems, > so making an alias should suffice. I have done so and geeqie works as expected. So, if it also works for th

Re: [Geeqie-devel] Compiling geeqie on Mac

2009-07-26 Thread Laurent Monin
Greg Troxel a écrit : > and Mac OS X 10.5.7 has MAP_ANON and not MAP_ANONYMOUS. Just dropping > it seems not justified, but perhaps it is actually ok. > > Yes, instead can you try the attached patch ? MAP_ANON should be defined, but not MAP_ANONYMOUS on some systems, so making an alias should

Re: [Geeqie-devel] Compiling geeqie on Mac

2009-07-26 Thread Greg Troxel
and Mac OS X 10.5.7 has MAP_ANON and not MAP_ANONYMOUS. Just dropping it seems not justified, but perhaps it is actually ok. pgpVvIBatJ4L8.pgp Description: PGP signature -- _

Re: [Geeqie-devel] Compiling geeqie on Mac

2009-07-26 Thread Greg Troxel
understand: MAP_ANONYMOUS was not declared (where can it be found?). I think the problem is that POSIX specifies mmap but not MAP_ANON or MAP_ANONYMOUS, found in . On NetBSD the constant is MAP_ANON. My somewhat fuzzy memory is that mmap was a BSD invention, and I'd expect NetBSD matches 4.