Re: [Geeqie-devel] [PATCH v2 1/1] Fix crash on drag and drop from xfe

2016-04-18 Thread Jonathan Boeing
On Mon, 18 Apr 2016 17:39:23 -0700 Jonathan Boeing <jonathan.n.boe...@gmail.com> wrote: > diff --git a/src/ui_bookmark.c b/src/ui_bookmark.c > index 842b947..18f7311 100644 > --- a/src/ui_bookmark.c > +++ b/src/ui_bookmark.c > @@ -707,13 +707,19 @@ static void bookmark_d

[Geeqie-devel] [PATCH v2 1/1] Fix crash on drag and drop from xfe

2016-04-18 Thread Jonathan Boeing
Dragged and dropped paths from xfe aren't escaped like paths from a gtk app. A folder named 'test # one' for example causes g_filename_from_uri to fail and return NULL, which then causes a SIGSEGV in path_to_utf8. This patch fixes the crash by checking for failed conversions. If conversion failed

Re: [Geeqie-devel] [PATCH 0/1] Fix crash on drag and drop from Xfe

2016-04-18 Thread Jonathan Boeing
On Sun, 17 Apr 2016 17:09:49 +0100 Colin Clark wrote: > Sorry, but I cannot test here this because I cannot replicate that > fault on my system. I'm using Fluxbox rather than a full Desktop Environment; maybe that has something to do with it?