Re: [Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers

2009-07-02 Thread Adam Turcotte
On Mon, Jun 29, 2009 at 4:47 PM, Martin Nordholtsense...@gmail.com wrote: It'll be fine to put it in gegl-matrix.c I have added the typedef, but now I have the issue of adding this GeglMatrix2 as a property of the sampler. I notice that there are g_object_class_install_property ( ) lines that

Re: [Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers

2009-07-02 Thread Martin Nordholts
On 07/02/2009 10:34 PM, Sven Neumann wrote: Hi, On Thu, 2009-07-02 at 16:27 -0400, Adam Turcotte wrote: I have added the typedef, but now I have the issue of adding this GeglMatrix2 as a property of the sampler. I notice that there are g_object_class_install_property ( ) lines that use

Re: [Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers

2009-06-29 Thread Martin Nordholts
On 06/25/2009 10:50 PM, Adam Turcotte wrote: My question at the moment is: what is the best way to pass this data to the sampler? I feel bad about you not getting a reply, so I want to give a reply even though it's not a super helpful one: Use whatever way you can come up with and that

Re: [Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers

2009-06-29 Thread Nicolas Robidoux
Martin Nordhotls wrote: Personally I don't see the point in duplicating a matrix lib in every software, i.e. I question the introduction of GeglMatrix3 in the first place, I mean there certainly must be high quality libs for matrix operations out there, but that's a different story... IMHO,

Re: [Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers

2009-06-29 Thread Martin Nordholts
On 06/29/2009 09:53 PM, Nicolas Robidoux wrote: IMHO, when all you are dealing with are 3x3 matrices (which are not arbitrary 3x3, since they represent affine + perspective transformations), it is likely that a general purpose matrix library would be slower. Even more so with 2x2. So, my

Re: [Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers

2009-06-29 Thread Adam Turcotte
On Mon, Jun 29, 2009 at 3:44 PM, Martin Nordholtsense...@gmail.com wrote: Since GeglMatrix3 exists, GeglMatrix2 also should exist for consistency. Should GeglMatrix2 also reside within gegl-matrix.c, or should it be separate? I can quickly create GeglMatrix2 for the purposes of passing Jacobian

[Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers

2009-06-26 Thread Nicolas Robidoux
Adam: (Ignore if my last email about GeglMatrix3 was off the mark.) Is it that affine transformations, stored in 3x3 matrices, get simplified when they are chained? If so, where is the final overall 3x3 representation? Hopefully, extracting the linear part from it to compute the inverse

[Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers

2009-06-25 Thread Nicolas Robidoux
Adam Turcotte writes: In addition, I will need to expand the OpAffine struct to include an additional GeglMatrix3 (call it matrix_inverse or inverse_jacobian?) to store this data. GeglMatrix3? Is this a 3x3 matrix type? (Ignore the following if it is not.) Maybe the matrix created by the