Re: [Gegl-developer] GEGL OpenCL Porting

2014-11-19 Thread Nanley Chery
I noticed there was more to the brightness-contrast example. I made the adjustments concerning the kernel name and parameter values. The code compiles now. The current problem that I'm experiencing is that the run-composition.py test for video-degradation passes with an empty kernel. I'm not sure w

Re: [Gegl-developer] GEGL OpenCL Porting

2014-11-19 Thread Nanley Chery
Wow. Thank you for the tip, CL_CHECK is now giving me an output. This is the error message: (lt-gegl:10486): GEGL-video-degradation.c-WARNING **: Error in video-degradation.c:236@cl_process - invalid kernel I thought that I had followed the kernel compilation process correctly. Do you notice any

Re: [Gegl-developer] GEGL OpenCL Porting

2014-11-19 Thread Nanley Chery
It seems like the code to initialize and run the opencl kernel was lost in this commit: https://git.gnome.org/browse/gegl/commit/gegl?id=a206f032f77064cf9bff8590ac83ca5b086b53fd I'm not familiar enough with the codebase to understand the commit message. Why was this functionality removed? Should

Re: [Gegl-developer] GEGL OpenCL Porting

2014-11-19 Thread Victor Oliveira
Hi Nanley, I was actually giving a look at that this morning and figuring out with Daniel Sabo if that's really the case. Pippin, did you delete that code on purpose? Victor On Wed, Nov 19, 2014 at 11:26 AM, Nanley Chery wrote: > It seems like the code to initialize and run the opencl kernel w

Re: [Gegl-developer] GEGL OpenCL Porting

2014-11-19 Thread Øyvind Kolås
On Wed, Nov 19, 2014 at 7:33 PM, Victor Oliveira wrote: > I was actually giving a look at that this morning and figuring out > with Daniel Sabo if that's really the case. > > Pippin, did you delete that code on purpose? Nope, removal of the code making OpenCL work definetely would have been unint

Re: [Gegl-developer] GEGL OpenCL Porting

2014-11-19 Thread Nanley Chery
I'm glad we could find this bug. Rolling back to the older version of gegl-operation-point-filter.c and adding support for enums in gegl-operation.c allows my opencl kernel to run (among other changes). I will rebase my repo on top of master once it's updated. The last issue that I'm having is that

Re: [Gegl-developer] GEGL OpenCL Porting

2014-11-19 Thread Victor Oliveira
Have you tried GEGL_DEBUG=opencl ? On Wed, Nov 19, 2014 at 2:32 PM, Nanley Chery wrote: > I'm glad we could find this bug. Rolling back to the older version of > gegl-operation-point-filter.c and adding support for enums in > gegl-operation.c allows my opencl kernel to run (among other changes).

Re: [Gegl-developer] GEGL OpenCL Porting

2014-11-19 Thread Nanley Chery
Thanks for the question Victor. I'm actually running a custom perl script to automate the process. Your question led me to find a bug in the script. Cheers, Nanley On Wed, Nov 19, 2014 at 5:33 PM, Victor Oliveira wrote: > Have you tried GEGL_DEBUG=opencl ? > > On Wed, Nov 19, 2014 at 2:32 PM, N

Re: [Gegl-developer] GEGL OpenCL Porting

2014-11-19 Thread Victor Oliveira
I put it back, hopefully everything is alright now. Victor On Wed, Nov 19, 2014 at 2:41 PM, Nanley Chery wrote: > Thanks for the question Victor. I'm actually running a custom perl script to > automate the process. Your question led me to find a bug in the script. > > Cheers, > Nanley > > On Wed