Re: [gem5-dev] Review Request 3585: misc: Remove FullSystem check for networking components

2016-08-16 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3585/ --- (Updated Aug. 16, 2016, 10:32 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3590: Add a DmaCallback class to DmaDevice

2016-08-16 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3590/ --- (Updated Aug. 16, 2016, 10:31 p.m.) Review request for Default. Summary

Re: [gem5-dev] Review Request 3588: ruby: convert atomic accesses to functional in RubyPort

2016-08-16 Thread Michael LeBeane
> On Aug. 4, 2016, 4:52 p.m., Andreas Hansson wrote: > > This is _very_ dangerous. > > > > The "functional" accessor functions are really only for debug access, and > > any writes happening on the functional interfaces do not really have a > > well-defined consistency model with respect to

[gem5-dev] Review Request 3619: kvm: Support timing accesses for KVM cpu

2016-08-16 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3619/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3586: dev: Exit correctly in dist-gem5

2016-08-16 Thread Mohammad Alian
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3586/#review8642 --- Thanks for this fix. Just one issue that I think still is not resolved

Re: [gem5-dev] Review Request 3604: base: Output all AddrRange parameters to config.ini

2016-08-16 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3604/#review8641 --- Ship it! Ship It! - Jason Lowe-Power On Aug. 4, 2016, 5:56 p.m.,

Re: [gem5-dev] Review Request 3599: mem: Sort memory commands and update DRAMPower

2016-08-16 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3599/#review8640 --- src/mem/dram_ctrl.hh (line 340)

Re: [gem5-dev] Review Request 3600: mem: Modify drain to ensure banks and power are idled

2016-08-16 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3600/#review8639 --- Ship it! Ship It! - Jason Lowe-Power On Aug. 11, 2016, 9:08 a.m.,

Re: [gem5-dev] Review Request 3601: mem: Add callback to compute stats prior to dump event

2016-08-16 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3601/#review8638 --- Just a small thing below. Other than that it looks good.

Re: [gem5-dev] Review Request 3598: mem: update DDR3 die revision

2016-08-16 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3598/#review8637 --- Ship it! Ship It! - Jason Lowe-Power On Aug. 11, 2016, 9:07 a.m.,

Re: [gem5-dev] Review Request 3603: mem: add DRAM powerdown current

2016-08-16 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3603/#review8635 --- Ship it! Ship It! - Jason Lowe-Power On Aug. 11, 2016, 9:08 a.m.,

Re: [gem5-dev] Review Request 3597: mem: add DRAM powerdown timing

2016-08-16 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3597/#review8636 --- Ship it! Ship It! - Jason Lowe-Power On Aug. 11, 2016, 9:07 a.m.,

Re: [gem5-dev] Review Request 3565: arm, config: Fixups for the example big.LITTLE(tm) configuration

2016-08-16 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3565/#review8634 --- Ship it! Thanks for the changes. It looks much better. This is now a

Re: [gem5-dev] Review Request 3614: cpu: Add frequency scaling to the Trace CPU

2016-08-16 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3614/#review8633 --- Ship it! Ship It! - Jason Lowe-Power On Aug. 12, 2016, 4:45 p.m.,

Re: [gem5-dev] Review Request 3616: cpu: Support exit when any one Trace CPU completes replay

2016-08-16 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3616/#review8632 --- Ship it! Ship It! - Jason Lowe-Power On Aug. 12, 2016, 4:45 p.m.,

Re: [gem5-dev] Review Request 3586: dev: Exit correctly in dist-gem5

2016-08-16 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3586/#review8631 --- Ship it! Ship It! - Jason Lowe-Power On Aug. 4, 2016, 4:48 p.m.,

[gem5-dev] Review Request 3618: arm, config: Fixups for the example big.LITTLE(tm) configuration

2016-08-16 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3618/ --- Review request for Default and Jason Lowe-Power. Repository: gem5 Description

[gem5-dev] Review Request 3617: isa, arm: Add missing AArch32 FP instructions

2016-08-16 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3617/ --- Review request for Default. Repository: gem5 Description --- isa,arm: Add

Re: [gem5-dev] Review Request 3586: dev: Exit correctly in dist-gem5

2016-08-16 Thread Gabor Dozsa
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3586/#review8630 --- Ship it! Ship it! Thanks for fixing this! - Gabor Dozsa - Gabor Dozsa

[gem5-dev] changeset in gem5: dev: Revert 0a316996de76 [dev, sim: Added mis...

2016-08-16 Thread Andreas Sandberg
changeset 7e7157941d70 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=7e7157941d70 description: dev: Revert 0a316996de76 [dev, sim: Added missing override...] This changeset reverts the changset "dev, sim: Added missing override keywords to fix CLANG

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2016-08-16 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/03.learning-gem5/alpha/linux/learning-gem5-p1-simple: passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/o3-timing: passed. * build/ALPHA/tests/opt/quick/se/01.hello-2T-smt/alpha/linux/o3-timing-mt: passed. *