Re: [gem5-dev] adding reviewers in gerrit?

2017-03-25 Thread Jason Lowe-Power
Hi Gabe, Hmm... It works for me. It's possible that we don't have the permissions set up correctly to allow anyone to add reviewers. I just tested with a non-admin account and it doesn't work for that account either. I'll look into it. Cheers, Jason On Sat, Mar 25, 2017 at 5:32 AM Gabe Black

[gem5-dev] adding reviewers in gerrit?

2017-03-25 Thread Gabe Black
Hi folks. I've uploaded a few CLs to gerrit now, and I notice that I can't add reviewers since it claims everyone I try to add isn't a registered user. That's very odd, because I'm trying to add people who have given me review feedback on earlier changes, and people who I can look up activity for

[gem5-dev] Change in public/gem5[master]: scons: Use a relative symlink for git hooks more selectively.

2017-03-25 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/2541 Change subject: scons: Use a relative symlink for git hooks more selectively. .. scons: Use a relative symlink for git hooks more

[gem5-dev] Change in public/gem5[master]: scons: Collapse symlinks when installing git hooks.

2017-03-25 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/2542 Change subject: scons: Collapse symlinks when installing git hooks. .. scons: Collapse symlinks when installing git hooks. When

[gem5-dev] Change in public/gem5[master]: scons: Detect and remove broken git hook symlinks.

2017-03-25 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/2540 Change subject: scons: Detect and remove broken git hook symlinks. .. scons: Detect and remove broken git hook symlinks. When

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2017-03-25 Thread Cron Daemon
* build/MIPS/tests/opt/quick/se/00.hello/mips/linux/o3-timing: CHANGED! * build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-timing: CHANGED!*** diff[simout]: SKIPPED * build/MIPS/tests/opt/quick/se/03.learning-gem5/mips/linux/learning-gem5-p1-two-level: CHANGED! *