On Wed, Jul 21, 2021 at 8:26 AM Giacomo Travaglini <
giacomo.travagl...@arm.com> wrote:
> Thanks Gabe,
>
> The performance benefit is difficult to measure as the macro is not
> currently used; it could provide negligible or no improvement at all
> depending on the compiler and on where it could be
Ok thanks, Bobby. Please let me know if you find anything, especially if it
looks like it's a bug in kokoro itself somehow.
Gabe
On Wed, Jul 21, 2021 at 3:52 PM Bobby Bruce wrote:
> There's definitely something funny going on with the gem5art tests there
> but I believe that error is happening
There's definitely something funny going on with the gem5art tests there
but I believe that error is happening without triggering a non-zero exit
code. The gem5art test script is set to `set -e`, which means the script
should exit immediately after a failure, yet it doesn't. The testing also
contin
I've seen many kokoro failures lately, including this one which seems to be
from a problem in gem5-art? Any idea what's going on?
https://source.cloud.google.com/results/invocations/caae5aad-91a6-4c6e-9fbe-20962f9c5519/targets/gem5%2Fgcp_ubuntu%2Fpresubmit/log
_
Thanks Gabe,
The performance benefit is difficult to measure as the macro is not currently
used; it could provide negligible or no improvement at all depending on the
compiler and on where it could be used.
So the question is not whether it makes gem5 faster now, it is more about
giving our use
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48383 )
Change subject: cpu: Remove unnecessary includes of arch/locked_mem.hh.
..
cpu: Remove unnecessary includes of arc
Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/45305 )
Change subject: arch-x86: De-conditionalize segmentation microops.
..
arch-x86: De-conditionalize segmentation microops.
The
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48366 )
Change subject: sim: Use a range based for loop in EmbeddedPython::initAll.
..
sim: Use a range based for loop in
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48382 )
Change subject: python: Minor cleanups in the marshal program source.
..
python: Minor cleanups in the marshal pro
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48381 )
Change subject: scons: Clean up the definition of m5.defines a little bit.
..
scons: Clean up the definition of m5
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48379 )
Change subject: scons: Eliminate flag_* entries from m5.defines.
..
scons: Eliminate flag_* entries from m5.define
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48378 )
Change subject: scons: Pull the "Blob" builder out of src/SConscript.
..
scons: Pull the "Blob" builder out of src
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48376 )
Change subject: scons: Move the source related helper classes out of
src/SConscript.
..
scons: Move the source
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48380 )
Change subject: scons,python: Stop importing some values in m5.defines.
..
scons,python: Stop importing some value
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48377 )
Change subject: scons: Move the bytesToCppArray helper to gem5_scons.util.
..
scons: Move the bytesToCppArray help
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48375 )
Change subject: scons: Build the source filter factories dict in
SourceFilter.
..
scons: Build the source filte
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48374 )
Change subject: scons: Turn gem5_scons.builders from a module into a
package.
..
scons: Turn gem5_scons.builder
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48373 )
Change subject: scons: Tidy up the definition of SourceFile slightly.
..
scons: Tidy up the definition of SourceFi
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48372 )
Change subject: scons: Define the rules for building debug flag hdrs in
place.
..
scons: Define the rules for b
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48371 )
Change subject: scons: Add a pair of functions for working with Value nodes.
..
scons: Add a pair of functions for
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48370 )
Change subject: scons,debug: Implement the "All" flag in C++ and not scons.
..
scons,debug: Implement the "All" fl
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48364 )
Change subject: configs,python: Clean some cruft out of m5.objects.
..
configs,python: Clean some cruft out of m5.
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48369 )
Change subject: scons: Generalize the Executable class to cover libraries
too.
..
scons: Generalize the Executa
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48362 )
Change subject: scons: Get rid of special handling of the _m5 package.
..
scons: Get rid of special handling of th
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48361 )
Change subject: scons: Get rid of a redundant import of code_formatter.
..
scons: Get rid of a redundant import of
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48368 )
Change subject: scons,test: Don't -Wall or -Werror for googletest libraries.
..
scons,test: Don't -Wall or -Werror
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48360 )
Change subject: util: Sort the "updater tags" in cpt_upgrader.py
--get-cc-file.
..
util: Sort the "updater tags
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48365 )
Change subject: scons,python,sim: Eliminate a redundant member of
EmbeddedPython.
..
scons,python,sim: Eliminat
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48367 )
Change subject: scons: Pull some python related mechanisms out of
USE_PYTHON guards.
..
scons: Pull some python
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48363 )
Change subject: scons: Update the special module importer API.
..
scons: Update the special module importer API.
30 matches
Mail list logo