[gem5-dev] Re: DPRINTF_UNCONDITIONAL deprecation

2021-07-21 Thread Gabe Black via gem5-dev
On Wed, Jul 21, 2021 at 8:26 AM Giacomo Travaglini < giacomo.travagl...@arm.com> wrote: > Thanks Gabe, > > The performance benefit is difficult to measure as the macro is not > currently used; it could provide negligible or no improvement at all > depending on the compiler and on where it could be

[gem5-dev] Re: kokoro failures due to bug in gem5-art?

2021-07-21 Thread Gabe Black via gem5-dev
Ok thanks, Bobby. Please let me know if you find anything, especially if it looks like it's a bug in kokoro itself somehow. Gabe On Wed, Jul 21, 2021 at 3:52 PM Bobby Bruce wrote: > There's definitely something funny going on with the gem5art tests there > but I believe that error is happening

[gem5-dev] Re: kokoro failures due to bug in gem5-art?

2021-07-21 Thread Bobby Bruce via gem5-dev
There's definitely something funny going on with the gem5art tests there but I believe that error is happening without triggering a non-zero exit code. The gem5art test script is set to `set -e`, which means the script should exit immediately after a failure, yet it doesn't. The testing also contin

[gem5-dev] kokoro failures due to bug in gem5-art?

2021-07-21 Thread Gabe Black via gem5-dev
I've seen many kokoro failures lately, including this one which seems to be from a problem in gem5-art? Any idea what's going on? https://source.cloud.google.com/results/invocations/caae5aad-91a6-4c6e-9fbe-20962f9c5519/targets/gem5%2Fgcp_ubuntu%2Fpresubmit/log _

[gem5-dev] Re: DPRINTF_UNCONDITIONAL deprecation

2021-07-21 Thread Giacomo Travaglini via gem5-dev
Thanks Gabe, The performance benefit is difficult to measure as the macro is not currently used; it could provide negligible or no improvement at all depending on the compiler and on where it could be used. So the question is not whether it makes gem5 faster now, it is more about giving our use

[gem5-dev] Change in gem5/gem5[develop]: cpu: Remove unnecessary includes of arch/locked_mem.hh.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48383 ) Change subject: cpu: Remove unnecessary includes of arch/locked_mem.hh. .. cpu: Remove unnecessary includes of arc

[gem5-dev] Change in gem5/gem5[develop]: arch-x86: De-conditionalize segmentation microops.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/45305 ) Change subject: arch-x86: De-conditionalize segmentation microops. .. arch-x86: De-conditionalize segmentation microops. The

[gem5-dev] Change in gem5/gem5[develop]: sim: Use a range based for loop in EmbeddedPython::initAll.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48366 ) Change subject: sim: Use a range based for loop in EmbeddedPython::initAll. .. sim: Use a range based for loop in

[gem5-dev] Change in gem5/gem5[develop]: python: Minor cleanups in the marshal program source.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48382 ) Change subject: python: Minor cleanups in the marshal program source. .. python: Minor cleanups in the marshal pro

[gem5-dev] Change in gem5/gem5[develop]: scons: Clean up the definition of m5.defines a little bit.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48381 ) Change subject: scons: Clean up the definition of m5.defines a little bit. .. scons: Clean up the definition of m5

[gem5-dev] Change in gem5/gem5[develop]: scons: Eliminate flag_* entries from m5.defines.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48379 ) Change subject: scons: Eliminate flag_* entries from m5.defines. .. scons: Eliminate flag_* entries from m5.define

[gem5-dev] Change in gem5/gem5[develop]: scons: Pull the "Blob" builder out of src/SConscript.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48378 ) Change subject: scons: Pull the "Blob" builder out of src/SConscript. .. scons: Pull the "Blob" builder out of src

[gem5-dev] Change in gem5/gem5[develop]: scons: Move the source related helper classes out of src/SConscript.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48376 ) Change subject: scons: Move the source related helper classes out of src/SConscript. .. scons: Move the source

[gem5-dev] Change in gem5/gem5[develop]: scons,python: Stop importing some values in m5.defines.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48380 ) Change subject: scons,python: Stop importing some values in m5.defines. .. scons,python: Stop importing some value

[gem5-dev] Change in gem5/gem5[develop]: scons: Move the bytesToCppArray helper to gem5_scons.util.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48377 ) Change subject: scons: Move the bytesToCppArray helper to gem5_scons.util. .. scons: Move the bytesToCppArray help

[gem5-dev] Change in gem5/gem5[develop]: scons: Build the source filter factories dict in SourceFilter.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48375 ) Change subject: scons: Build the source filter factories dict in SourceFilter. .. scons: Build the source filte

[gem5-dev] Change in gem5/gem5[develop]: scons: Turn gem5_scons.builders from a module into a package.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48374 ) Change subject: scons: Turn gem5_scons.builders from a module into a package. .. scons: Turn gem5_scons.builder

[gem5-dev] Change in gem5/gem5[develop]: scons: Tidy up the definition of SourceFile slightly.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48373 ) Change subject: scons: Tidy up the definition of SourceFile slightly. .. scons: Tidy up the definition of SourceFi

[gem5-dev] Change in gem5/gem5[develop]: scons: Define the rules for building debug flag hdrs in place.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48372 ) Change subject: scons: Define the rules for building debug flag hdrs in place. .. scons: Define the rules for b

[gem5-dev] Change in gem5/gem5[develop]: scons: Add a pair of functions for working with Value nodes.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48371 ) Change subject: scons: Add a pair of functions for working with Value nodes. .. scons: Add a pair of functions for

[gem5-dev] Change in gem5/gem5[develop]: scons,debug: Implement the "All" flag in C++ and not scons.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48370 ) Change subject: scons,debug: Implement the "All" flag in C++ and not scons. .. scons,debug: Implement the "All" fl

[gem5-dev] Change in gem5/gem5[develop]: configs,python: Clean some cruft out of m5.objects.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48364 ) Change subject: configs,python: Clean some cruft out of m5.objects. .. configs,python: Clean some cruft out of m5.

[gem5-dev] Change in gem5/gem5[develop]: scons: Generalize the Executable class to cover libraries too.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48369 ) Change subject: scons: Generalize the Executable class to cover libraries too. .. scons: Generalize the Executa

[gem5-dev] Change in gem5/gem5[develop]: scons: Get rid of special handling of the _m5 package.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48362 ) Change subject: scons: Get rid of special handling of the _m5 package. .. scons: Get rid of special handling of th

[gem5-dev] Change in gem5/gem5[develop]: scons: Get rid of a redundant import of code_formatter.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48361 ) Change subject: scons: Get rid of a redundant import of code_formatter. .. scons: Get rid of a redundant import of

[gem5-dev] Change in gem5/gem5[develop]: scons,test: Don't -Wall or -Werror for googletest libraries.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48368 ) Change subject: scons,test: Don't -Wall or -Werror for googletest libraries. .. scons,test: Don't -Wall or -Werror

[gem5-dev] Change in gem5/gem5[develop]: util: Sort the "updater tags" in cpt_upgrader.py --get-cc-file.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48360 ) Change subject: util: Sort the "updater tags" in cpt_upgrader.py --get-cc-file. .. util: Sort the "updater tags

[gem5-dev] Change in gem5/gem5[develop]: scons,python,sim: Eliminate a redundant member of EmbeddedPython.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48365 ) Change subject: scons,python,sim: Eliminate a redundant member of EmbeddedPython. .. scons,python,sim: Eliminat

[gem5-dev] Change in gem5/gem5[develop]: scons: Pull some python related mechanisms out of USE_PYTHON guards.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48367 ) Change subject: scons: Pull some python related mechanisms out of USE_PYTHON guards. .. scons: Pull some python

[gem5-dev] Change in gem5/gem5[develop]: scons: Update the special module importer API.

2021-07-21 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/48363 ) Change subject: scons: Update the special module importer API. .. scons: Update the special module importer API.