Re: [gem5-dev] Port configuration overhaul

2019-03-14 Thread Gabe Black
Definitely. This makes ports a lot more abstract, where they just represent a potential association between two objects. The nature and function of that association is up to either side of the connection, as implement in their Port subclasses. That *could* be the traditional MemObject style of

Re: [gem5-dev] Port configuration overhaul

2019-03-14 Thread Jason Lowe-Power
Hey Gabe, I'll need to think about this a bit more myself, but do you think these changes will increase the places we can use ports? Like Andreas was saying, it would be nice to use it for things like interrupt routing, connecting TLBs, and connecting all of the wavefronts in the GPU to the

Re: [gem5-dev] Port configuration overhaul

2019-03-14 Thread Gabe Black
Great, I'm glad you're in favor of this. I have a new, hopefully more final batch of patches incoming soon which also include application of the new mechanism to TLM sockets. Gabe On Thu, Mar 14, 2019 at 2:47 AM Andreas Sandberg wrote: > Hi Everyone, > > I remember talking to Andreas H about

Re: [gem5-dev] Port configuration overhaul

2019-03-14 Thread Andreas Sandberg
Hi Everyone, I remember talking to Andreas H about this many years ago. If I remember correctly, the main reason the patch wasn't committed at the time was performance related. IIRC, the patch series had a ~10%-20% performance hit. I suspect it the patch Jason pointed to isn't the main reason for

Re: [gem5-dev] Port configuration overhaul

2019-03-11 Thread Gabe Black
My doc is updated with what my patches turned into, so PTAL if you have a chance. I think it turned out to be pretty straightforward which should make it an easier read. I took a look at Andrea's patch, and it has some pretty interesting ideas in there. One prominent difference I see is that I

Re: [gem5-dev] Port configuration overhaul

2019-03-07 Thread Steve Reinhardt
Thanks for digging this up, Jason. I knew this issue had been addressed multiple times before (I think I even had a patch at one point that was a smaller change, but held it off in favor of Andreas's version). I don't know why Andreas's change was never committed either. Anyway, it will be good

Re: [gem5-dev] Port configuration overhaul

2019-03-07 Thread Jason Lowe-Power
Hey Gabe, I was digging through the old reviewboard and found this patch that also re-did this interface: http://reviews.gem5.org/r/1301 I'm not sure why this was never committed. I believe Andreas H's goal was to enable TLM-2 interfaces with the gem5, IIRC. Just something to consider.

Re: [gem5-dev] Port configuration overhaul

2019-03-07 Thread Gabe Black
Hey folks, specifically folks looking at this doc. I have a series of patches which largely implement what I was going for, although it turned out differently than what I have in my doc. I'll update the doc soon(ish) to describe the current version. Go ahead and review the CLs if you want,

[gem5-dev] Port configuration overhaul

2019-03-06 Thread Gabe Black
Hi folks. I've been looking at how to configure TLM sockets through gem5's port configuration mechanism and how gem5's port configuration mechanism works in general, and I think I've mostly come up with a plan. I've written everything up in a doc over here: