[gem5-dev] Re: Broken SST due to python changes

2021-12-16 Thread Jason Lowe-Power via gem5-dev
Thanks, Gabe! We'll run the nightly tests and double check everything is working as expected. Jason On Thu, Dec 16, 2021 at 6:49 AM Gabe Black wrote: > I just realized I turned off my computer since I'll be traveling, and my > test run of sst can't finish if the computer is off :-P. I have not

[gem5-dev] Re: Broken SST due to python changes

2021-12-16 Thread Gabe Black via gem5-dev
I just realized I turned off my computer since I'll be traveling, and my test run of sst can't finish if the computer is off :-P. I have not completed a run of your example command, but it starts and I have no reason to believe it won't finish. I would still suggest running it yourself (with my cha

[gem5-dev] Re: Broken SST due to python changes

2021-12-16 Thread Gabe Black via gem5-dev
https://gem5-review.googlesource.com/c/public/gem5/+/54325/1 On Wed, Dec 15, 2021 at 11:12 PM Gabe Black wrote: > There will be a couple more patches coming, since the systemc subsystem > has problems when python is already running when static initializers run. I > had been building without syst

[gem5-dev] Re: Broken SST due to python changes

2021-12-15 Thread Gabe Black via gem5-dev
There will be a couple more patches coming, since the systemc subsystem has problems when python is already running when static initializers run. I had been building without systemc enabled to simplify things earlier, but I need to get it running too. That should be a fairly quick fix. Gabe On We

[gem5-dev] Re: Broken SST due to python changes

2021-12-15 Thread Hoa Nguyen via gem5-dev
Hi Gabe, Thanks for uploading the changes. Typically it'll take less than an hour for RISC-V. Regards, Hoa Nguyen On Wed, Dec 15, 2021 at 10:38 PM Gabe Black wrote: > I have it running, although it's taking a while. How long should it take > to finish? Should it finish immediately, 15 minutes,

[gem5-dev] Re: Broken SST due to python changes

2021-12-15 Thread Gabe Black via gem5-dev
I have it running, although it's taking a while. How long should it take to finish? Should it finish immediately, 15 minutes, a few hours, tomorrow...? I'll upload my changes in the mean time. Gabe On Wed, Dec 15, 2021 at 9:13 PM Gabe Black wrote: > Ok, I did/am doing a little more looking, and

[gem5-dev] Re: Broken SST due to python changes

2021-12-15 Thread Gabe Black via gem5-dev
Ok, I did/am doing a little more looking, and part of the problem seems to be that some of the python blobs executed with executePython assume prior blobs have done imports for them already. That was where the modules or their contents not being found was coming from, and then after that something

[gem5-dev] Re: Broken SST due to python changes

2021-12-15 Thread Gabe Black via gem5-dev
Also, I have to say, while I'm grateful that there was a push to get the SCons changes reviewed for the release, we wouldn't be in this crunch if they had been reviewed a month ago. It would be best not to let things bunch up and then make a herculean push right at the deadline, where problems have

[gem5-dev] Re: Broken SST due to python changes

2021-12-15 Thread Gabe Black via gem5-dev
That's actually very helpful, since I was pretty sure there was a memory problem but couldn't figure out where. I think there's a good chance this will be an easy fix. Gabe On Wed, Dec 15, 2021, 8:59 AM Jason Lowe-Power wrote: > Ok, I was able to get a debugger to work and I dug in a bit more..

[gem5-dev] Re: Broken SST due to python changes

2021-12-15 Thread Jason Lowe-Power via gem5-dev
Ok, I was able to get a debugger to work and I dug in a bit more... The problem is that the new code does not initialize the __main__.py module. The original SST code had the following line: `pythonMain = PyImport_AddModule(PyCC("__main__"));` This was executed before `execPythonCommands`. In `e

[gem5-dev] Re: Broken SST due to python changes

2021-12-15 Thread Jason Lowe-Power via gem5-dev
Here's my understanding of where we are on this: As of https://gem5.googlesource.com/public/gem5/+/cf7ce21848ea4aeee28737823e6e768f9a14ceaf SST was working. (Committed Dec. 7th) Then, this large relation chain was pushed: https://gem5-review.googlesource.com/c/public/gem5/+/49425 ending with http

[gem5-dev] Re: Broken SST due to python changes

2021-12-11 Thread Gabe Black via gem5-dev
https://gem5-review.googlesource.com/c/public/gem5/+/54006 At least one problem I ran into was that the order of static initializers was not determinstic, so the structures which said what embedded python modules existed might be statically constructed after the thing that consumes and sets them u

[gem5-dev] Re: Broken SST due to python changes

2021-12-11 Thread Jason Lowe-Power via gem5-dev
Everything was working as of last week-ish, if I remember correctly. We were booting both Arm and RISCV full system with gem5 cores and SST caches/memory. Cheers, Jason On Sat, Dec 11, 2021, 8:23 AM Gabe Black wrote: > Thanks, that was really helpful. I've fixed the compilation problems, and >

[gem5-dev] Re: Broken SST due to python changes

2021-12-11 Thread Gabe Black via gem5-dev
Thanks, that was really helpful. I've fixed the compilation problems, and then a few more that were hiding behind that, including a few ones that were intrinsic to the way sst was initializing the gem5 library (with dlopen). Was this working to begin with and all this breakage is new, or was it jus

[gem5-dev] Re: Broken SST due to python changes

2021-12-10 Thread Bobby Bruce via gem5-dev
Hey gabe. No idea if this is the _best_ solution to your problem, but my solution would be to rebuild the image with this installed. Modify the `util/dockerfiles/sst-11.1.0/Dockerfile` to the environment you want. Then run `docker build -t util/dockerfiles/sst-11.1.0` to build an image with the n

[gem5-dev] Re: Broken SST due to python changes

2021-12-10 Thread Gabe Black via gem5-dev
Dumb question: I'm trying to run gdb inside this container on the sst thing. How do I do that? It's not installed in the container now, and I can't (easily) figure out how to get it installed. I can tell docker to install it, but then it seems to throw that away as soon as the command ends. Gabe

[gem5-dev] Re: Broken SST due to python changes

2021-12-10 Thread Bobby Bruce via gem5-dev
Thanks Gabe, This is very much appreciated. I'm going to create the release staging once a couple more things get in. Feel free to push any patches related to these bugs to the release staging branch. If there is an order of priority I'd say the bug affecting SST is of higher importance than that

[gem5-dev] Re: Broken SST due to python changes

2021-12-10 Thread Gabe Black via gem5-dev
Hi Bobby, not yet, I meant to look into this for the last couple days but kept running out of time. I'm sitting down to work on it right now. Gabe On Fri, Dec 10, 2021 at 1:21 PM Bobby Bruce wrote: > Hey Gabe, > > Is there any update on this? > > Kind regards, > Bobby > -- > Dr. Bobby R. Bruce

[gem5-dev] Re: Broken SST due to python changes

2021-12-10 Thread Bobby Bruce via gem5-dev
Hey Gabe, Is there any update on this? Kind regards, Bobby -- Dr. Bobby R. Bruce Room 3050, Kemper Hall, UC Davis Davis, CA, 95616 web: https://www.bobbybruce.net On Wed, Dec 8, 2021 at 5:51 PM Hoa Nguyen via gem5-dev wrote: > Hi Gabe, > > I have more details about this. In this use case, SS

[gem5-dev] Re: Broken SST due to python changes

2021-12-08 Thread Hoa Nguyen via gem5-dev
Hi Gabe, I have more details about this. In this use case, SST initialized the Python environment before adding the "gem5 object". This gem5 object will add more Python stuff from gem5 to the environment. The function that does that is initPython() https://gem5.googlesource.com/public/gem5/+/refs