On Sun, March 3, 2013 3:40 pm, Ali Saidi wrote:
HI Nilay,
I hacked around and almost got it to compile on os x. There was one issue
with a vtable on BaseGlobalEvent::BaseEvent not having a viable that I
can't seem to get rid of. I can try some more later, but I here is the
diff that gets it
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1667/
---
(Updated Feb. 22, 2013, 9:50 a.m.)
Review request for Default.
Description
On Thu, February 14, 2013 12:58 pm, Ali Saidi wrote:
Thanks Nilay,
I still haven't groked all your code completely ,but
it seems like perhaps having a #define for TLS_VARIABLE and setting it
to nothing if tls isn't supported and just #ifdefing the control flow
through simulate() might be
Xcode (for clang) + macports (for python, scons, mercurial etc) is what I
use, works like a charm.
Andreas
On 18/02/2013 17:43, Nilay ni...@cs.wisc.edu wrote:
On Thu, February 14, 2013 12:58 pm, Ali Saidi wrote:
Thanks Nilay,
I still haven't groked all your code completely ,but
it seems
Andreas, thanks for the info.
--
Nilay
On Mon, February 18, 2013 11:53 am, Andreas Hansson wrote:
Xcode (for clang) + macports (for python, scons, mercurial etc) is what I
use, works like a charm.
Andreas
___
gem5-dev mailing list
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1667/
---
(Updated Feb. 14, 2013, 7:29 a.m.)
Review request for Default.
Description
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1667/#review4037
---
Nice! Thanks for the changes, Nilay. This is really looking good. My
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1667/
---
(Updated Feb. 14, 2013, 10:12 a.m.)
Review request for Default.
Description
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1667/
---
(Updated Feb. 14, 2013, 10:17 a.m.)
Review request for Default.
Description
Hi Nilay,
Could you see if you can easily #ifdef the __thread commands and the
creation of threads such that if the platform doesn't support one or both
features we can still compile and run?
I'll borrow an OS X laptop and see what parts need to be protected.
--
Nilay
Thanks Nilay,
I still haven't groked all your code completely ,but
it seems like perhaps having a #define for TLS_VARIABLE and setting it
to nothing if tls isn't supported and just #ifdefing the control flow
through simulate() might be sufficient to get the job done.
Thanks
again,
Ali
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1667/#review4039
---
src/sim/eventq.cc
http://reviews.gem5.org/r/1667/#comment3915
I
On Feb. 11, 2013, 10:25 a.m., Ali Saidi wrote:
src/python/m5/SimObject.py, line 604
http://reviews.gem5.org/r/1667/diff/2/?file=33931#file33931line604
How does this work? I'm not saying it doesn't I just don't understand
what the proxy is doing in this case? Looking for any
See http://gem5.org/Simulation_Scripts_Explained#Relative_references for
the official explanation.
Parent.any just looks for a type match and not a parameter name match.
It's generally used where you're looking to find an enclosing object
further up the hierarchy (like a System object) and not
On Feb. 11, 2013, 10:25 a.m., Ali Saidi wrote:
src/python/m5/SimObject.py, line 604
http://reviews.gem5.org/r/1667/diff/2/?file=33931#file33931line604
How does this work? I'm not saying it doesn't I just don't understand
what the proxy is doing in this case? Looking for any
On Feb. 11, 2013, 10:25 a.m., Ali Saidi wrote:
src/sim/eventq.cc, line 59
http://reviews.gem5.org/r/1667/diff/2/?file=33940#file33940line59
I'm a bit concerned with using __thread since it isn't supported on OS
X as far as I know. I'd be fine for requiring TLS on a platform that
On Feb. 10, 2013, 8:19 p.m., Steve Reinhardt wrote:
src/sim/eventq.hh, line 198
http://reviews.gem5.org/r/1667/diff/2/?file=33939#file33939line198
I would really like to solve this problem without adding yet another
field to the Event structure. I think that all the common cases
On Feb. 10, 2013, 8:19 p.m., Steve Reinhardt wrote:
src/sim/eventq.hh, line 198
http://reviews.gem5.org/r/1667/diff/2/?file=33939#file33939line198
I would really like to solve this problem without adding yet another
field to the Event structure. I think that all the common cases
On Feb. 11, 2013, 10:25 a.m., Ali Saidi wrote:
src/sim/eventq.cc, line 59
http://reviews.gem5.org/r/1667/diff/2/?file=33940#file33940line59
I'm a bit concerned with using __thread since it isn't supported on OS
X as far as I know. I'd be fine for requiring TLS on a platform that
On Feb. 10, 2013, 8:19 p.m., Steve Reinhardt wrote:
Hi Nilay,
Thanks a lot for posting this. I'm really excited to see you pushing this
forward.
One high-level thought... now that I've looked at this code again after not
having seen it for over a year, the repetition of
On Feb. 10, 2013, 8:19 p.m., Steve Reinhardt wrote:
Hi Nilay,
Thanks a lot for posting this. I'm really excited to see you pushing this
forward.
One high-level thought... now that I've looked at this code again after not
having seen it for over a year, the repetition of
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1667/#review4011
---
Hi Nilay,
Thanks for all of this, it's really great to see us making
On Feb. 11, 2013, 10:25 a.m., Ali Saidi wrote:
src/python/m5/SimObject.py, line 604
http://reviews.gem5.org/r/1667/diff/2/?file=33931#file33931line604
How does this work? I'm not saying it doesn't I just don't understand
what the proxy is doing in this case? Looking for any
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1667/
---
(Updated Feb. 10, 2013, 1:44 p.m.)
Review request for Default.
Description
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1667/#review4013
---
Hi Nilay,
Thanks a lot for posting this. I'm really excited to see you
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1667/
---
Review request for Default.
Description
---
Changeset 9486:a6a90f478e1d
26 matches
Mail list logo
