---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2523/#review5601
---
Ship it!
Ship It!
- Steve Reinhardt
On Nov. 22, 2014, 11:25 p.m.,
On Nov 26, 2014, at 12:11 PM, Steve Reinhardt via gem5-dev gem5-dev@gem5.org
wrote:
On Wed, Nov 26, 2014 at 4:30 AM, Gabe Black via gem5-dev gem5-dev@gem5.org
wrote:
Just to make sure we're all on the same page, I removed the spaces here
because these are default values for arguments.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2523/#review5552
---
I thought the style guide said there were supposed to be spaces around
On Nov. 26, 2014, 10:45 a.m., Andreas Hansson wrote:
I thought the style guide said there were supposed to be spaces around
operators and assignments, or am I missing something?
I don't think the style guide says, or at least not that I see. I may be
tending to the style we use at work.
On Nov. 26, 2014, 10:45 a.m., Andreas Hansson wrote:
I thought the style guide said there were supposed to be spaces around
operators and assignments, or am I missing something?
Gabe Black wrote:
I don't think the style guide says, or at least not that I see. I may be
tending to
On Nov. 26, 2014, 10:45 a.m., Andreas Hansson wrote:
I thought the style guide said there were supposed to be spaces around
operators and assignments, or am I missing something?
Gabe Black wrote:
I don't think the style guide says, or at least not that I see. I may be
tending to
On Wed, Nov 26, 2014 at 4:30 AM, Gabe Black via gem5-dev gem5-dev@gem5.org
wrote:
Just to make sure we're all on the same page, I removed the spaces here
because these are default values for arguments. My brain might have just
pattern matched and applied a rule for named function arguments
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2523/#review5549
---
Ship it!
Ship It!
- Nilay Vaish
On Nov. 23, 2014, 7:25 a.m., Gabe
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2523/
---
Review request for Default.
Repository: gem5
Description
---
Changeset