Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

Oops, those patches don't apply cleanly to the mainline. Here's the updated patches. I tested these three patches on Intel (3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux) and AMD (4.0.0-040050-generic #201505271752 SMP Wed May 27 17:53:58 IDT 2015

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

Here's the three patches I've been using. I've done most of my testing on an Intel platform, BTW. I have an AMD platform, though it's been a long time since I've tested gem5-KVM on it. If I get some extra time today, I'll run a quick test. Cheers, Jason On Fri, Feb 3, 2017 at 12:10 PM Gabe Black

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

ping... On Thu, Feb 2, 2017 at 12:11 PM, Gabe Black wrote: > Any chance somebody can send me a patch? > > Gabe > > > On Tue, Jan 31, 2017 at 2:34 PM, Gabe Black wrote: > >> I have no plans to attend HPCA at the moment. >> >> There are folks here who

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

Any chance somebody can send me a patch? Gabe On Tue, Jan 31, 2017 at 2:34 PM, Gabe Black wrote: > I have no plans to attend HPCA at the moment. > > There are folks here who are using my original version of this patch and > would like to check it into our internal version

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

I have no plans to attend HPCA at the moment. There are folks here who are using my original version of this patch and would like to check it into our internal version of gem5, but I think we should use a version of it that doesn't break anything else in the process. Unfortunately I don't have an

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

> On Jan. 30, 2017, 10:31 p.m., Gabe Black wrote: > > Hi folks. I put together this patch a long time ago, there was some > > discussion about it, and then I lost track of what was going on with it. > > Have the issues it causes with AMD cpus been tracked down? Glancing through > > this

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

> On Jan. 30, 2017, 10:31 p.m., Gabe Black wrote: > > Hi folks. I put together this patch a long time ago, there was some > > discussion about it, and then I lost track of what was going on with it. > > Have the issues it causes with AMD cpus been tracked down? Glancing through > > this

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2557/#review9350 --- Hi folks. I put together this patch a long time ago, there was some

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

From AMD's system programming manual: SYSCALL New selectors are loaded, without permission checking (see above), as follows: Bits 47:32 of the STAR register specify the selector that is copied into the CS register. Bits 47:32 of the STAR register + 8 specify the selector that is copied into

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

OK, I believe I have a patch that unifies the code for both AMD and Intel. Do I post it as a separate review-board item? On Thu, Jan 22, 2015 at 11:32 AM, mike upton michaelup...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2557/

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

Glad you all seem to be figuring this out. I think we should do runtime rather than compile-time detection though, as some people may have mixed clusters they want to run the same binary on, or may cross-compile. Steve On Wed, Jan 21, 2015 at 3:30 PM, Dutu, Alexandru via gem5-dev

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

On Jan. 21, 2015, 9:22 p.m., mike upton wrote: src/arch/x86/process.cc, lines 218-237 http://reviews.gem5.org/r/2557/diff/2/?file=42948#file42948line218 For AMD systems, the sys descriptors need to come first. On intel systems they need to come second. I do not know

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

On Jan. 21, 2015, 9:22 p.m., mike upton wrote: src/arch/x86/process.cc, lines 218-237 http://reviews.gem5.org/r/2557/diff/2/?file=42948#file42948line218 For AMD systems, the sys descriptors need to come first. On intel systems they need to come second. I do not know

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

On Jan. 21, 2015, 9:22 p.m., mike upton wrote: src/arch/x86/process.cc, lines 218-237 http://reviews.gem5.org/r/2557/diff/2/?file=42948#file42948line218 For AMD systems, the sys descriptors need to come first. On intel systems they need to come second. I do not know

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

On Jan. 21, 2015, 9:22 p.m., mike upton wrote: src/arch/x86/process.cc, lines 218-237 http://reviews.gem5.org/r/2557/diff/2/?file=42948#file42948line218 For AMD systems, the sys descriptors need to come first. On intel systems they need to come second. I do not know

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2557/#review5782 --- src/arch/x86/process.cc http://reviews.gem5.org/r/2557/#comment5116

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

On Jan. 21, 2015, 9:22 p.m., mike upton wrote: src/arch/x86/process.cc, lines 218-237 http://reviews.gem5.org/r/2557/diff/2/?file=42948#file42948line218 For AMD systems, the sys descriptors need to come first. On intel systems they need to come second. I do not know

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

On Jan. 16, 2015, 11:56 p.m., mike upton wrote: src/arch/x86/process.cc, lines 212-213 http://reviews.gem5.org/r/2557/diff/2/?file=42948#file42948line212 when limitHigh and limitLow get set by dataSegDesc(), it seems that limitHigh and limitLow get reversed. This patch

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

On Jan. 16, 2015, 11:28 p.m., mike upton wrote: src/arch/x86/utility.hh, line 219 http://reviews.gem5.org/r/2557/diff/2/?file=42952#file42952line219 Is there a reason the desc.l does not get set for the dataSegDesc()? code sets p,l,d,g,s. Yes. The long mode bit only means

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

I am making some progress on debugging this. I hope to have it tomorrow. On Sun, Jan 11, 2015 at 12:48 AM, Alexandru Dutu alexandru.d...@amd.com wrote: This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2557/ On December 10th, 2014, 10:30 p.m. UTC,

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

it is: hg qpush On Fri, Jan 16, 2015 at 8:39 AM, Amit Gaikwad avlan...@gmail.com wrote: Hello Mike, Thank you so much for taking out time to explain things. That was really helpful. But I have unsuccessful in getting KVM CPU working on my intel system. Since when I applied the patch ,

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2557/#review5772 --- src/arch/x86/utility.hh http://reviews.gem5.org/r/2557/#comment5110

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2557/#review5773 --- src/arch/x86/process.cc http://reviews.gem5.org/r/2557/#comment5111

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

On Dec. 10, 2014, 10:30 p.m., mike upton wrote: There is some issue with AMD platforms. A test that used to run in 30 sec is not finishing. mike upton wrote: hello world passes. SPEC apps hang. Gabe Black wrote: Can you identify where it's getting stuck? It could be

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

On Jan. 16, 2015, 12:44 a.m., mike upton wrote: src/arch/x86/regs/misc.hh, line 922 http://reviews.gem5.org/r/2557/diff/2/?file=42949#file42949line922 really 32, 0 in the new code? Yeah, I think that should be 31, 0 - Gabe

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

if you go here: http://reviews.gem5.org/r/2557/ there is a 'Download Diff' button on the first active line of the review (about 3 down from the 'Review board 1.7.9') You download it, and then apply it using the method I PMed you. On Thu, Jan 15, 2015 at 4:36 PM, Amit Gaikwad

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2557/#review5769 --- src/arch/x86/regs/misc.hh http://reviews.gem5.org/r/2557/#comment5108

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

On Dec. 10, 2014, 10:30 p.m., mike upton wrote: There is some issue with AMD platforms. A test that used to run in 30 sec is not finishing. mike upton wrote: hello world passes. SPEC apps hang. Gabe Black wrote: Can you identify where it's getting stuck? It could be

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

On Dec. 10, 2014, 10:30 p.m., mike upton wrote: There is some issue with AMD platforms. A test that used to run in 30 sec is not finishing. mike upton wrote: hello world passes. SPEC apps hang. Gabe Black wrote: Can you identify where it's getting stuck? It could be

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

On Dec. 10, 2014, 10:30 p.m., mike upton wrote: There is some issue with AMD platforms. A test that used to run in 30 sec is not finishing. mike upton wrote: hello world passes. SPEC apps hang. Gabe Black wrote: Can you identify where it's getting stuck? It could be

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

On Dec. 10, 2014, 10:30 p.m., mike upton wrote: There is some issue with AMD platforms. A test that used to run in 30 sec is not finishing. mike upton wrote: hello world passes. SPEC apps hang. Gabe Black wrote: Can you identify where it's getting stuck? It could be

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2557/ --- (Updated Dec. 10, 2014, 10:11 a.m.) Review request for Default. Summary

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2557/#review5663 --- Ok, now it's for real. Review away. - Gabe Black On Dec. 10, 2014,

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2557/#review5673 --- There is some issue with AMD platforms. A test that used to run in 30

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

On Dec. 10, 2014, 10:30 p.m., mike upton wrote: There is some issue with AMD platforms. A test that used to run in 30 sec is not finishing. hello world passes. SPEC apps hang. - mike --- This is an automatically generated

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

On Dec. 10, 2014, 10:30 p.m., mike upton wrote: There is some issue with AMD platforms. A test that used to run in 30 sec is not finishing. mike upton wrote: hello world passes. SPEC apps hang. Can you identify where it's getting stuck? It could be there's something wrong