Re: [gem5-dev] Review Request 2801: slicc: Support for setting individual message buffer size

2015-05-26 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2801/ --- (Updated May 26, 2015, 12:59 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2801: slicc: Support for setting individual message buffer size

2015-05-20 Thread Joel Hestness
> On May 14, 2015, 6:10 p.m., Joel Hestness wrote: > > src/mem/slicc/symbols/StateMachine.py, line 629 > > > > > > I see. On my first pass here, I misread that this code allows arbitrary > > expressions for setting buffer_s

Re: [gem5-dev] Review Request 2801: slicc: Support for setting individual message buffer size

2015-05-19 Thread Brad Beckmann
> On May 14, 2015, 6:10 p.m., Joel Hestness wrote: > > src/mem/slicc/symbols/StateMachine.py, line 629 > > > > > > I see. On my first pass here, I misread that this code allows arbitrary > > expressions for setting buffer_s

Re: [gem5-dev] Review Request 2801: slicc: Support for setting individual message buffer size

2015-05-14 Thread Joel Hestness
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2801/#review6272 --- src/mem/slicc/symbols/StateMachine.py (line 629)

Re: [gem5-dev] Review Request 2801: slicc: Support for setting individual message buffer size

2015-05-14 Thread Brad Beckmann
> On May 12, 2015, 2:23 p.m., Joel Hestness wrote: > > src/mem/slicc/symbols/StateMachine.py, line 629 > > > > > > It appears that this parses the buffer_size value string for a literal, > > variable name, or a statement co

Re: [gem5-dev] Review Request 2801: slicc: Support for setting individual message buffer size

2015-05-12 Thread Jason Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2801/#review6163 --- Ship it! Ship It! - Jason Power On May 11, 2015, 10:20 p.m., Tony Gut

Re: [gem5-dev] Review Request 2801: slicc: Support for setting individual message buffer size

2015-05-12 Thread Joel Hestness
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2801/#review6159 --- I like the direction of this patch, but I think the buffer_size value sho

[gem5-dev] Review Request 2801: slicc: Support for setting individual message buffer size

2015-05-11 Thread Anthony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2801/ --- Review request for Default. Repository: gem5 Description --- Changeset 10858