Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-21 Thread Andreas Hansson
> On April 18, 2016, 5:06 a.m., Steve Reinhardt wrote: > > src/mem/cache/write_queue_entry.hh, line 80 > > > > > > Is this 'pkt' field still used? I'd think not, in which case it should > > of course be deleted. If it is

Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-20 Thread Steve Reinhardt
> On April 17, 2016, 10:06 p.m., Steve Reinhardt wrote: > > src/mem/cache/write_queue_entry.hh, line 80 > > > > > > Is this 'pkt' field still used? I'd think not, in which case it should > > of course be deleted. If it is

Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-20 Thread Andreas Hansson
> On April 18, 2016, 5:06 a.m., Steve Reinhardt wrote: > > src/mem/cache/write_queue_entry.hh, line 80 > > > > > > Is this 'pkt' field still used? I'd think not, in which case it should > > of course be deleted. If it is

Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-20 Thread Steve Reinhardt
> On April 17, 2016, 10:06 p.m., Steve Reinhardt wrote: > > src/mem/cache/write_queue_entry.hh, line 80 > > > > > > Is this 'pkt' field still used? I'd think not, in which case it should > > of course be deleted. If it is

Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-20 Thread Andreas Hansson
> On April 18, 2016, 5:06 a.m., Steve Reinhardt wrote: > > src/mem/cache/write_queue_entry.hh, line 80 > > > > > > Is this 'pkt' field still used? I'd think not, in which case it should > > of course be deleted. If it is

Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-20 Thread Andreas Hansson
> On April 18, 2016, 5:06 a.m., Steve Reinhardt wrote: > > src/mem/cache/write_queue_entry.hh, line 80 > > > > > > Is this 'pkt' field still used? I'd think not, in which case it should > > of course be deleted. If it is

Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-20 Thread Steve Reinhardt
> On April 17, 2016, 10:06 p.m., Steve Reinhardt wrote: > > src/mem/cache/write_queue_entry.hh, line 80 > > > > > > Is this 'pkt' field still used? I'd think not, in which case it should > > of course be deleted. If it is

Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-20 Thread Andreas Hansson
> On April 18, 2016, 5:06 a.m., Steve Reinhardt wrote: > > src/mem/cache/write_queue_entry.hh, line 80 > > > > > > Is this 'pkt' field still used? I'd think not, in which case it should > > of course be deleted. If it is

Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-19 Thread Steve Reinhardt
> On April 17, 2016, 10:06 p.m., Steve Reinhardt wrote: > > src/mem/cache/write_queue_entry.hh, line 80 > > > > > > Is this 'pkt' field still used? I'd think not, in which case it should > > of course be deleted. If it is

Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-19 Thread Andreas Hansson
> On April 18, 2016, 5:06 a.m., Steve Reinhardt wrote: > > src/mem/cache/write_queue_entry.hh, line 80 > > > > > > Is this 'pkt' field still used? I'd think not, in which case it should > > of course be deleted. If it is

Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-18 Thread Steve Reinhardt
> On April 17, 2016, 10:06 p.m., Steve Reinhardt wrote: > > src/mem/cache/write_queue_entry.hh, line 80 > > > > > > Is this 'pkt' field still used? I'd think not, in which case it should > > of course be deleted. If it is

Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-18 Thread Andreas Hansson
> On April 18, 2016, 5:06 a.m., Steve Reinhardt wrote: > > src/mem/cache/write_queue_entry.hh, line 80 > > > > > > Is this 'pkt' field still used? I'd think not, in which case it should > > of course be deleted. If it is

Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-18 Thread Steve Reinhardt
> On April 17, 2016, 10:06 p.m., Steve Reinhardt wrote: > > src/mem/cache/write_queue_entry.hh, line 80 > > > > > > Is this 'pkt' field still used? I'd think not, in which case it should > > of course be deleted. If it is

Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-18 Thread Andreas Hansson
> On April 18, 2016, 5:06 a.m., Steve Reinhardt wrote: > > src/mem/cache/write_queue_entry.hh, line 80 > > > > > > Is this 'pkt' field still used? I'd think not, in which case it should > > of course be deleted. If it is

Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-17 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3407/#review8240 --- Hard not to like a change that's a net reduction in LOC!

Re: [gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-04-09 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3407/ --- (Updated April 9, 2016, 4:20 p.m.) Review request for Default. Repository: gem5

[gem5-dev] Review Request 3407: mem: Simplify cache packet handling for uncacheable writes

2016-03-31 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3407/ --- Review request for Default. Repository: gem5 Description --- Changeset