Re: [gem5-dev] Review Request 3414: ruby: change !! into static_cast calls

2016-04-06 Thread Brandon Potter
> On April 5, 2016, 2:54 p.m., Jason Lowe-Power wrote: > > Would you be against doing if (count > 0)? I think that is more clear than > > a static cast. The two m_map objects are an unordered_map and an ordered_map. The count method can only return 0 or 1 because duplicates are not allowed in

Re: [gem5-dev] Review Request 3414: ruby: change !! into static_cast calls

2016-04-05 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3414/#review8138 --- Would you be against doing if (count > 0)? I think that is more clear

[gem5-dev] Review Request 3414: ruby: change !! into static_cast calls

2016-04-04 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3414/ --- Review request for Default. Repository: gem5 Description --- Changeset