Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-15 Thread Brandon Potter
> On April 13, 2016, 7:08 p.m., Joel Hestness wrote: > > I'm not clear how this change fixes the exception noted above. Can you > > elaborate? > > > > Also, the diff here doesn't apply cleanly to the current mainline head. Is > > there another patch that needs to be applied before this? > >

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-14 Thread Joel Hestness
> On April 13, 2016, 7:08 p.m., Joel Hestness wrote: > > configs/ruby/MESI_Three_Level.py, line 153 > > > > > > This change connects the L0 caches to the network rather than > > connecting them directly to the L1 caches.

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-14 Thread Joel Hestness
> On April 13, 2016, 7:08 p.m., Joel Hestness wrote: > > configs/ruby/MESI_Three_Level.py, line 153 > > > > > > This change connects the L0 caches to the network rather than > > connecting them directly to the L1 caches.

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Jason Lowe-Power
> On April 13, 2016, 7:08 p.m., Joel Hestness wrote: > > I'm not clear how this change fixes the exception noted above. Can you > > elaborate? > > > > Also, the diff here doesn't apply cleanly to the current mainline head. Is > > there another patch that needs to be applied before this? > >

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Brad Beckmann
> On April 13, 2016, 7:08 p.m., Joel Hestness wrote: > > configs/ruby/MESI_Three_Level.py, line 153 > > > > > > This change connects the L0 caches to the network rather than > > connecting them directly to the L1 caches.

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Brandon Potter
> On April 13, 2016, 7:08 p.m., Joel Hestness wrote: > > configs/ruby/MESI_Three_Level.py, line 153 > > > > > > This change connects the L0 caches to the network rather than > > connecting them directly to the L1 caches.

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Brandon Potter
> On April 13, 2016, 7:08 p.m., Joel Hestness wrote: > > I'm not clear how this change fixes the exception noted above. Can you > > elaborate? > > > > Also, the diff here doesn't apply cleanly to the current mainline head. Is > > there another patch that needs to be applied before this? This

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Joel Hestness
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3441/#review8142 --- I'm not clear how this change fixes the exception noted above. Can you

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Brandon Potter
> On April 13, 2016, 6:17 p.m., Jason Lowe-Power wrote: > > Before this patch this protocol was broken? From the changes, it doesn't > > even look like it would have compiled. Is this true? In one way I'm shocked > > this happend. In another I'm not surprised at all... :( > > Brandon Potter

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Jason Lowe-Power
> On April 13, 2016, 6:17 p.m., Jason Lowe-Power wrote: > > Before this patch this protocol was broken? From the changes, it doesn't > > even look like it would have compiled. Is this true? In one way I'm shocked > > this happend. In another I'm not surprised at all... :( > > Brandon Potter

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Brandon Potter
> On April 13, 2016, 6:17 p.m., Jason Lowe-Power wrote: > > Before this patch this protocol was broken? From the changes, it doesn't > > even look like it would have compiled. Is this true? In one way I'm shocked > > this happend. In another I'm not surprised at all... :( It doesn't make it

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3441/#review8209 --- Before this patch this protocol was broken? From the changes, it doesn't

[gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-04 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3441/ --- Review request for Default. Repository: gem5 Description --- Changeset