Re: [gem5-dev] Review Request 3461: tests: Add test infrastructure as a Python module

2016-05-26 Thread Andreas Sandberg
> On May 10, 2016, 1:12 a.m., Joe Gross wrote: > > Hi Andreas, I had a couple questions/clarifications about this patch. The > > idea is that this script will run the test/test suites in an ordered > > fashion but doesn't contain any infrastructure to launch jobs in a > > distributed

Re: [gem5-dev] Review Request 3461: tests: Add test infrastructure as a Python module

2016-05-10 Thread Andreas Sandberg
> On May 10, 2016, 1:12 a.m., Joe Gross wrote: > > Hi Andreas, I had a couple questions/clarifications about this patch. The > > idea is that this script will run the test/test suites in an ordered > > fashion but doesn't contain any infrastructure to launch jobs in a > > distributed

Re: [gem5-dev] Review Request 3461: tests: Add test infrastructure as a Python module

2016-05-06 Thread Andreas Sandberg
> On May 5, 2016, 8:20 p.m., Joel Hestness wrote: > > Thanks for the updates. LGTM. > > > > If you're willing, I still think it would be good to add comments about > > what might need to be changed in these files in order to add new tests. Will do. The way the configuration files are added

Re: [gem5-dev] Review Request 3461: tests: Add test infrastructure as a Python module

2016-05-03 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3461/ --- (Updated May 3, 2016, 6:44 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3461: tests: Add test infrastructure as a Python module

2016-05-03 Thread Andreas Sandberg
> On May 2, 2016, 10:01 p.m., Joel Hestness wrote: > > Overall, this looks pretty solid - much more like a "test harness" than the > > existing regressions. Thanks! > > > > Given that this change is already pretty significant, are there other > > changes we should introduce or plan to make?

Re: [gem5-dev] Review Request 3461: tests: Add test infrastructure as a Python module

2016-05-02 Thread Joel Hestness
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3461/#review8277 --- Overall, this looks pretty solid - much more like a "test harness" than

[gem5-dev] Review Request 3461: tests: Add test infrastructure as a Python module

2016-04-28 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3461/ --- Review request for Default. Repository: gem5 Description --- Changeset