Re: [gem5-dev] Review Request 3535: gpu-compute: Adding context serialization methods to Wavefront

2016-08-15 Thread Andreas Hansson
> On June 30, 2016, 7:17 a.m., Andreas Hansson wrote: > > src/gpu-compute/wavefront.hh, line 389 > > > > > > Surely one of these should be const > > Andreas Hansson wrote: > I do not see this being addressed.

Re: [gem5-dev] Review Request 3535: gpu-compute: Adding context serialization methods to Wavefront

2016-08-12 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3535/#review8614 --- Ship it! Ship It! - Andreas Hansson On July 8, 2016, 10:14 p.m.,

Re: [gem5-dev] Review Request 3535: gpu-compute: Adding context serialization methods to Wavefront

2016-08-12 Thread Alexandru Dutu
> On June 30, 2016, 7:17 a.m., Andreas Hansson wrote: > > src/gpu-compute/wavefront.hh, line 389 > > > > > > Surely one of these should be const > > Andreas Hansson wrote: > I do not see this being addressed.

Re: [gem5-dev] Review Request 3535: gpu-compute: Adding context serialization methods to Wavefront

2016-08-04 Thread Andreas Hansson
> On June 30, 2016, 7:17 a.m., Andreas Hansson wrote: > > src/gpu-compute/wavefront.hh, line 389 > > > > > > Surely one of these should be const I do not see this being addressed. getContext should be const I would

Re: [gem5-dev] Review Request 3535: gpu-compute: Adding context serialization methods to Wavefront

2016-07-08 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3535/ --- (Updated July 8, 2016, 3:14 p.m.) Review request for Default. Summary (updated)