Re: [gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-10-12 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3591/#review8828 --- Ship it! Ship It! - Jason Lowe-Power On Aug. 30, 2016, 3:54 p.m.,

Re: [gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-10-12 Thread Michael LeBeane
> On Sept. 1, 2016, 3:33 p.m., Jason Lowe-Power wrote: > > What testing did you perform to make sure all of the protocols were > > modified correctly? > > > > Most of these changes seem reasonable to me, but I know from experience > > that even when the SLICC changes seem like they are right,

Re: [gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-09-09 Thread Andreas Hansson
> On Sept. 1, 2016, 3:33 p.m., Jason Lowe-Power wrote: > > What testing did you perform to make sure all of the protocols were > > modified correctly? > > > > Most of these changes seem reasonable to me, but I know from experience > > that even when the SLICC changes seem like they are right,

Re: [gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-09-09 Thread Jason Lowe-Power
> On Sept. 1, 2016, 3:33 p.m., Jason Lowe-Power wrote: > > What testing did you perform to make sure all of the protocols were > > modified correctly? > > > > Most of these changes seem reasonable to me, but I know from experience > > that even when the SLICC changes seem like they are right,

Re: [gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-09-09 Thread Brad Beckmann
> On Sept. 1, 2016, 3:33 p.m., Jason Lowe-Power wrote: > > What testing did you perform to make sure all of the protocols were > > modified correctly? > > > > Most of these changes seem reasonable to me, but I know from experience > > that even when the SLICC changes seem like they are right,

Re: [gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-09-01 Thread Andreas Hansson
> On Sept. 1, 2016, 3:33 p.m., Jason Lowe-Power wrote: > > What testing did you perform to make sure all of the protocols were > > modified correctly? > > > > Most of these changes seem reasonable to me, but I know from experience > > that even when the SLICC changes seem like they are right,

Re: [gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-09-01 Thread Jason Lowe-Power
> On Sept. 1, 2016, 3:33 p.m., Jason Lowe-Power wrote: > > What testing did you perform to make sure all of the protocols were > > modified correctly? > > > > Most of these changes seem reasonable to me, but I know from experience > > that even when the SLICC changes seem like they are right,

Re: [gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-09-01 Thread Michael LeBeane
> On Sept. 1, 2016, 3:33 p.m., Jason Lowe-Power wrote: > > What testing did you perform to make sure all of the protocols were > > modified correctly? > > > > Most of these changes seem reasonable to me, but I know from experience > > that even when the SLICC changes seem like they are right,

Re: [gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-09-01 Thread Jason Lowe-Power
> On Sept. 1, 2016, 3:33 p.m., Jason Lowe-Power wrote: > > What testing did you perform to make sure all of the protocols were > > modified correctly? > > > > Most of these changes seem reasonable to me, but I know from experience > > that even when the SLICC changes seem like they are right,

Re: [gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-09-01 Thread Michael LeBeane
> On Sept. 1, 2016, 3:33 p.m., Jason Lowe-Power wrote: > > What testing did you perform to make sure all of the protocols were > > modified correctly? > > > > Most of these changes seem reasonable to me, but I know from experience > > that even when the SLICC changes seem like they are right,

Re: [gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-09-01 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3591/#review8698 --- What testing did you perform to make sure all of the protocols were

Re: [gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-08-30 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3591/ --- (Updated Aug. 30, 2016, 3:54 p.m.) Review request for Default. Repository: gem5

[gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-08-04 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3591/ --- Review request for Default. Repository: gem5 Description --- Changeset