Re: [gem5-dev] Review Request 3647: ruby: Fix regressions and make Ruby configs Python packages

2016-10-12 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3647/#review8826 --- Ship it! Thanks again for doing this! - Jason Lowe-Power On Oct. 12,

Re: [gem5-dev] Review Request 3647: ruby: Fix regressions and make Ruby configs Python packages

2016-10-12 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3647/ --- (Updated Oct. 12, 2016, 2:30 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3647: ruby: Fix regressions and make Ruby configs Python packages

2016-10-12 Thread Andreas Hansson
> On Oct. 12, 2016, 2:21 p.m., Jason Lowe-Power wrote: > > I like this approach! A couple of comments,though. > > > > 1. I think you need to add an __init__.py file to each directory (ruby, > > topologies, network) for this to work. Did you forget to hg add them? > > 2. Since we don't have

Re: [gem5-dev] Review Request 3647: ruby: Fix regressions and make Ruby configs Python packages

2016-10-12 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3647/#review8824 --- I like this approach! A couple of comments,though. 1. I think you need

Re: [gem5-dev] Review Request 3647: ruby: Fix regressions and make Ruby configs Python packages

2016-10-12 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3647/#review8823 --- Ship it! Ship It! - Tony Gutierrez On Oct. 12, 2016, 1:55 a.m.,

Re: [gem5-dev] Review Request 3647: ruby: Fix regressions and make Ruby configs Python packages

2016-10-12 Thread Andreas Hansson
> On Oct. 10, 2016, 9:58 p.m., Tony Gutierrez wrote: > > Ship It! I've taken another stab at fixing this in a less hackish way. I took a first stab at making the shared config modules Python packages (as they should have been all along). Have a look and let me know what you think. - Andreas

Re: [gem5-dev] Review Request 3647: ruby: Fix regressions and make Ruby configs Python packages

2016-10-12 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3647/ --- (Updated Oct. 12, 2016, 8:55 a.m.) Review request for Default. Summary (updated)