Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-17 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3702/#review9103 --- Ship it! Ship It! - Alexandru Dutu On Nov. 16, 2016, 4:44 p.m.,

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-16 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3702/ --- (Updated Nov. 16, 2016, 4:44 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-15 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3702/#review9079 --- Ship it! Ship It! - Michael LeBeane On Nov. 14, 2016, 9:30 p.m.,

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-14 Thread Michael LeBeane
> On Nov. 14, 2016, 7:19 p.m., Michael LeBeane wrote: > > src/sim/futex_map.hh, line 81 > > > > > > Why not something simple, like: > > > > return std::hash(addr) ^ (std::hash(tgid) << 1) > > Brandon Potter wrote:

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-14 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3702/ --- (Updated Nov. 14, 2016, 9:30 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-14 Thread Brandon Potter
> On Nov. 14, 2016, 7:19 p.m., Michael LeBeane wrote: > > src/sim/futex_map.hh, line 81 > > > > > > Why not something simple, like: > > > > return std::hash(addr) ^ (std::hash(tgid) << 1) The return value has to be

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-14 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3702/#review9052 --- src/sim/futex_map.hh (line 65)

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-14 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3702/ --- (Updated Nov. 14, 2016, 6:49 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-10 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3702/#review9036 --- src/sim/futex_map.hh (line 5)

[gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-07 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3702/ --- Review request for Default. Repository: gem5 Description --- Changeset