Re: [gem5-dev] include order style checker bug

2019-05-06 Thread Gabe Black
ens. > > Andrew > > -Original Message- > From: gem5-dev On Behalf Of Gambord, Ryan > Sent: Friday, May 3, 2019 10:15 PM > To: gem5 Developer List > Subject: Re: [gem5-dev] include order style checker bug > > I can confirm it's been doing this for a while now

Re: [gem5-dev] include order style checker bug

2019-05-05 Thread Zigerelli, Andrew D
f Of Gambord, Ryan Sent: Friday, May 3, 2019 10:15 PM To: gem5 Developer List Subject: Re: [gem5-dev] include order style checker bug I can confirm it's been doing this for a while now on my end. Lots of existing files in gem5 fail the style checker when I modify them, so it seems to be at leas

Re: [gem5-dev] include order style checker bug

2019-05-03 Thread Gambord, Ryan
I can confirm it's been doing this for a while now on my end. Lots of existing files in gem5 fail the style checker when I modify them, so it seems to be at least somewhat recent, or people were overriding the style checker in the past. Ryan Gambord On Thu, May 2, 2019, 22:58 Gabe Black wrote:

Re: [gem5-dev] include order style checker bug

2019-05-02 Thread Gabe Black
Here's another potentially related bug. There was an extra space between the final header and the using at the top of a .cc, and the style fixer decided to move the include of the corresponding .hh from the top where it belonged down into the list of includes in alphabetic order. It still

[gem5-dev] include order style checker bug

2019-05-02 Thread Gabe Black
Hey folks. I just ran into a bug in the style checker/fixer, and since I wanted to make sure I kept track of those so they can be fixed I thought I would describe it here for the record. I have a cc file which had a single system include (#include ) and the include for its .hh file (#include