[gem5-dev] Change in gem5/gem5[master]: base: Use a const auto & in a range based for loop.

2020-02-10 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/25226 ) Change subject: base: Use a const auto & in a range based for loop. .. base: Use a const auto & in a range based for loop.

[gem5-dev] Change in gem5/gem5[master]: riscv: Cast to float explicitly when comparing a float to an int.

2020-02-10 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/25225 ) Change subject: riscv: Cast to float explicitly when comparing a float to an int. .. riscv: Cast to float explicitly when

[gem5-dev] Change in gem5/gem5[master]: base: Fix squares of stats

2020-02-10 Thread Daniel Carvalho (Gerrit)
Daniel Carvalho has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/25184 ) Change subject: base: Fix squares of stats .. base: Fix squares of stats If a sample V, which has a square(V) = V * V,

[gem5-dev] Change in gem5/gem5[master]: arch: Add a bunch of missing override specifiers.

2020-02-10 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/25223 ) Change subject: arch: Add a bunch of missing override specifiers. .. arch: Add a bunch of missing override specifiers.

[gem5-dev] Change in gem5/gem5[master]: arm: Fix how a bitfield is extracted in some SVE instructions.

2020-02-10 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/25224 ) Change subject: arm: Fix how a bitfield is extracted in some SVE instructions. .. arm: Fix how a bitfield is extracted in

[gem5-dev] Change in gem5/gem5[master]: scons: Fix an error about an unrecognized compiler.

2020-02-10 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/25203 ) Change subject: scons: Fix an error about an unrecognized compiler. .. scons: Fix an error about an unrecognized compiler.

[gem5-dev] Change in gem5/gem5[master]: arm, sim: Use loadAddr(Mask|Offset) in getEntry.

2020-02-10 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/25267 ) Change subject: arm,sim: Use loadAddr(Mask|Offset) in getEntry. .. arm,sim: Use loadAddr(Mask|Offset) in

[gem5-dev] Change in gem5/gem5[master]: fastmodel: Use all possible address spaces when setting up a bp.

2020-02-10 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/25268 ) Change subject: fastmodel: Use all possible address spaces when setting up a bp. .. fastmodel: Use all

[gem5-dev] Change in gem5/gem5[master]: base: Fix squares of stats

2020-02-10 Thread Daniel Carvalho (Gerrit)
Daniel Carvalho has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/25184 ) Change subject: base: Fix squares of stats .. base: Fix squares of stats If a sample V, which has a

Re: [gem5-dev] commit message thrown away because of bad tag

2020-02-10 Thread Daniel Carvalho
Hi Gabe, Sorry for the inconvenience, but as Bobby pointed out, the commit message is not discarded, and its backup's location is explicitly stated on a failure. If it is preferred it could also be printed for ease of access, but when I tried this locally it clogged the output, making it

[gem5-dev] Change in gem5/gem5[master]: arch-arm: LDTRSW was not marked as unpriviledged

2020-02-10 Thread Giacomo Travaglini (Gerrit)
Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/24043 ) Change subject: arch-arm: LDTRSW was not marked as unpriviledged .. arch-arm: LDTRSW was not marked as unpriviledged

[gem5-dev] Change in gem5/gem5[master]: configs: Using VExpress_GEM5_V1 as a default for Options.py

2020-02-10 Thread Giacomo Travaglini (Gerrit)
Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/25183 ) Change subject: configs: Using VExpress_GEM5_V1 as a default for Options.py .. configs: Using VExpress_GEM5_V1 as a

Re: [gem5-dev] commit message thrown away because of bad tag

2020-02-10 Thread Daniel Carvalho
Gabe, I just saw your other e-mail (could you please CC me if you respond to this? My e-mail provider blocks all your e-mails, not even letting reach the spam box...), and although I did not understand the proper sequence of commands done, and I have never had an issue when creating commits

[gem5-dev] Change in gem5/gem5[master]: tests: Add --host tag

2020-02-10 Thread Giacomo Travaglini (Gerrit)
Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/24527 ) Change subject: tests: Add --host tag .. tests: Add --host tag A host tag has been added to take into consideration

[gem5-dev] Change in gem5/gem5[master]: tests: hello_se using host tag

2020-02-10 Thread Giacomo Travaglini (Gerrit)
Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/24528 ) Change subject: tests: hello_se using host tag .. tests: hello_se using host tag This patch is rewriting hello_se

[gem5-dev] Change in gem5/gem5[master]: mem-cache, mem-ruby: Move WeightedLRU RP

2020-02-10 Thread Daniel Carvalho (Gerrit)
Daniel Carvalho has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/22445 ) Change subject: mem-cache,mem-ruby: Move WeightedLRU RP .. mem-cache,mem-ruby: Move WeightedLRU RP Move the

Re: [gem5-dev] commit message thrown away because of bad tag

2020-02-10 Thread Jason Lowe-Power
Hi all, I think we should solve this problem instead ignoring it. It's good to have this check as a huge number of reviews are simply "please update the commit message", which is also a bad experience. @Bobby: Could you try to figure out a more user-friendly way for the commit message to be

Re: [gem5-dev] commit message thrown away because of bad tag

2020-02-10 Thread Bobby Bruce
I've created a Jira ticket for this: https://gem5.atlassian.net/browse/GEM5-321 I'll get to work on it. -- Dr. Bobby R. Bruce Room 2235, Kemper Hall, UC Davis Davis, CA, 95616 web: https://www.bobbybruce.net On Mon, Feb 10, 2020 at 5:58 AM Jason Lowe-Power wrote: > Hi all, > > I think we