Re: [gem5-dev] Review Request 3802: mem, stats: fix typos in CommMonitor and Stats

[Jason Lowe-Power]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3802/#review9409
---

Ship it!


Ship It!

- Jason Lowe-Power


On Feb. 6, 2017, 1:43 p.m., Pierre-Yves Péneau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3802/
> ---
> 
> (Updated Feb. 6, 2017, 1:43 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11809:e8c2d26050a3
> ---
> mem, stats: fix typos in CommMonitor and Stats
> 
> Signed-off-by: Pierre-Yves Péneau 
> 
> 
> Diffs
> -
> 
>   src/base/statistics.hh 63325e5b0a9d 
>   src/mem/comm_monitor.hh 63325e5b0a9d 
>   src/mem/comm_monitor.cc 63325e5b0a9d 
> 
> Diff: http://reviews.gem5.org/r/3802/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Pierre-Yves Péneau
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3802: mem, stats: fix typos in CommMonitor and Stats

[Tony Gutierrez]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3802/#review9408
---

Ship it!


Ship It!

- Tony Gutierrez


On Feb. 6, 2017, 5:43 a.m., Pierre-Yves Péneau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3802/
> ---
> 
> (Updated Feb. 6, 2017, 5:43 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11809:e8c2d26050a3
> ---
> mem, stats: fix typos in CommMonitor and Stats
> 
> Signed-off-by: Pierre-Yves Péneau 
> 
> 
> Diffs
> -
> 
>   src/base/statistics.hh 63325e5b0a9d 
>   src/mem/comm_monitor.hh 63325e5b0a9d 
>   src/mem/comm_monitor.cc 63325e5b0a9d 
> 
> Diff: http://reviews.gem5.org/r/3802/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Pierre-Yves Péneau
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3806: sparc: fix bugs caused by cd7f3a1dbf55

[Tony Gutierrez]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3806/#review9407
---



src/arch/sparc/faults.cc (line 641)


more comments here



src/arch/sparc/faults.cc (line 668)


Some more comments here would be useful



src/arch/sparc/faults.cc (line 674)


If you want just a single bit you can use the 2 arg variant of bits(T val, 
int bit), which will call the 3 arg version with fist == last.


- Tony Gutierrez


On Feb. 3, 2017, 10:48 a.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3806/
> ---
> 
> (Updated Feb. 3, 2017, 10:48 a.m.)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, and Steve Reinhardt.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11803:28dec3e7b84b
> ---
> sparc: fix bugs caused by cd7f3a1dbf55
> 
> Turns out that SPARC SE mode relied on M5_pid being "0" in
> all cases. The entries in the SPARC TLBs are accessed with
> M5_pid as their context. This is buggy in the sense that it
> will never work with more than one process or any
> initialization that doesn't have the M5_pid value passed in
> as "0".
> 
> cd7f3a1dbf55 broke the SPARC build because it deletes M5_pid
> and uses a _pid with a default of "100" instead. This caused
> the SPARC TLB to never return any valid lookups for any
> request; the program never moved past the first instruction
> with SPARC SE in the regression tester.
> 
> The solution proposed in this changeset is to initialize
> the address space identification register with the PID value
> that is passed into the process class as a parameter from
> Python. This should return the correct responses from the TLB
> since the insertions and lookups into the page table will be
> using the same PID.
> 
> Furthermore, there are corner cases in the code which elevate
> privileges and revert to using context "0" as the context in
> the TLB. I believe that these are related to kernel level
> traps and hypervisor privilege escalations, but I'm not
> completely sure. I've tried to address the corner cases
> properly, but it would be beneficial to have someone who is
> familiar with the SPARC architecture to take a look at this
> fix.
> 
> 
> Diffs
> -
> 
>   src/arch/sparc/faults.cc cd7f3a1dbf55bfa03b436c8cde51ebda515fbdbc 
>   src/arch/sparc/process.cc cd7f3a1dbf55bfa03b436c8cde51ebda515fbdbc 
> 
> Diff: http://reviews.gem5.org/r/3806/diff/
> 
> 
> Testing
> ---
> 
> util/regress all
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3802: mem, stats: fix typos in CommMonitor and Stats

[Pierre-Yves Péneau]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3802/
---

(Updated Feb. 6, 2017, 2:43 p.m.)


Review request for Default.


Repository: gem5


Description
---

Changeset 11809:e8c2d26050a3
---
mem, stats: fix typos in CommMonitor and Stats

Signed-off-by: Pierre-Yves Péneau 


Diffs (updated)
-

  src/base/statistics.hh 63325e5b0a9d 
  src/mem/comm_monitor.hh 63325e5b0a9d 
  src/mem/comm_monitor.cc 63325e5b0a9d 

Diff: http://reviews.gem5.org/r/3802/diff/


Testing
---


Thanks,

Pierre-Yves Péneau

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev