[gem5-dev] Change in gem5/gem5[master]: dev-arm: A9SCU fixup
Tiago Mück has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/19408
Change subject: dev-arm: A9SCU fixup
..
dev-arm: A9SCU fixup
Shifting instead of expensive power.
Change-Id: I164933257db125e18721c5b8bcaf9702030ebf40
Signed-off-by: Tiago Mück
---
M src/dev/arm/a9scu.cc
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/dev/arm/a9scu.cc b/src/dev/arm/a9scu.cc
index 677101b..20a0c33 100644
--- a/src/dev/arm/a9scu.cc
+++ b/src/dev/arm/a9scu.cc
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2010 ARM Limited
+ * Copyright (c) 2010,2019 ARM Limited
* All rights reserved
*
* The license below extends only to copyright in the software and shall
@@ -73,7 +73,7 @@
fatal("Too many CPUs (%d) for A9SCU!\n",
sys->numContexts());
}
int smp_bits, core_cnt;
-smp_bits = power(2,sys->numContexts()) - 1;
+smp_bits = (1 << sys->numContexts()) - 1;
core_cnt = sys->numContexts() - 1;
pkt->setLE(smp_bits << 4 | core_cnt);
break;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/19408
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I164933257db125e18721c5b8bcaf9702030ebf40
Gerrit-Change-Number: 19408
Gerrit-PatchSet: 1
Gerrit-Owner: Tiago Mück
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: cpu: Added the Multiperspective Perceptron Predictor with TAGE (8KB a...
Javier Bueno Hedo has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/19188 )
Change subject: cpu: Added the Multiperspective Perceptron Predictor with
TAGE (8KB and 64KB)
..
cpu: Added the Multiperspective Perceptron Predictor with TAGE (8KB and
64KB)
Described by the following article:
Jiménez, D. "Multiperspective perceptron predictor with TAGE."
Championship Branch Prediction (CBP-5) (2016).
Change-Id: Ica3c121a4c94657d9015573085040e8a1984b069
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/19188
Tested-by: kokoro
Maintainer: Andreas Sandberg
Reviewed-by: Ilias Vougioukas
---
M src/cpu/pred/BranchPredictor.py
M src/cpu/pred/SConscript
M src/cpu/pred/loop_predictor.cc
M src/cpu/pred/loop_predictor.hh
M src/cpu/pred/multiperspective_perceptron.cc
M src/cpu/pred/multiperspective_perceptron.hh
A src/cpu/pred/multiperspective_perceptron_tage.cc
A src/cpu/pred/multiperspective_perceptron_tage.hh
A src/cpu/pred/multiperspective_perceptron_tage_64KB.cc
A src/cpu/pred/multiperspective_perceptron_tage_64KB.hh
A src/cpu/pred/multiperspective_perceptron_tage_8KB.cc
A src/cpu/pred/multiperspective_perceptron_tage_8KB.hh
M src/cpu/pred/statistical_corrector.cc
M src/cpu/pred/statistical_corrector.hh
M src/cpu/pred/tage_base.cc
M src/cpu/pred/tage_base.hh
M src/cpu/pred/tage_sc_l.cc
M src/cpu/pred/tage_sc_l.hh
M src/cpu/pred/tage_sc_l_64KB.cc
M src/cpu/pred/tage_sc_l_64KB.hh
M src/cpu/pred/tage_sc_l_8KB.cc
M src/cpu/pred/tage_sc_l_8KB.hh
22 files changed, 1,909 insertions(+), 77 deletions(-)
Approvals:
Ilias Vougioukas: Looks good to me, approved
Andreas Sandberg: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/cpu/pred/BranchPredictor.py
b/src/cpu/pred/BranchPredictor.py
index 967489a..1196405 100644
--- a/src/cpu/pred/BranchPredictor.py
+++ b/src/cpu/pred/BranchPredictor.py
@@ -133,6 +133,7 @@
logUResetPeriod = Param.Unsigned(18,
"Log period in number of branches to reset TAGE useful counters")
numUseAltOnNa = Param.Unsigned(1, "Number of USE_ALT_ON_NA counters")
+initialTCounterValue = Param.Int(1 << 17, "Initial value of tCounter")
useAltOnNaBits = Param.Unsigned(4, "Size of the USE_ALT_ON_NA
counter(s)")
maxNumAlloc = Param.Unsigned(1,
@@ -210,6 +211,7 @@
pathHistBits = 27
maxNumAlloc = 2
logUResetPeriod = 10
+initialTCounterValue = 1 << 9
useAltOnNaBits = 5
# TODO No speculation implemented as of now
speculativeHistUpdate = False
@@ -334,14 +336,20 @@
bwnb = Param.Unsigned("Num global backward branch GEHL lengths")
bwm = VectorParam.Int("Global backward branch GEHL lengths")
logBwnb = Param.Unsigned("Log num of global backward branch GEHL
entries")
+bwWeightInitValue = Param.Int(
+ "Initial value of the weights of the global backward branch GEHL
entries")
lnb = Param.Unsigned("Num first local history GEHL lenghts")
lm = VectorParam.Int("First local history GEHL lengths")
logLnb = Param.Unsigned("Log number of first local history GEHL
entries")
+lWeightInitValue = Param.Int(
+"Initial value of the weights of the first local history GEHL
entries")
inb = Param.Unsigned(1, "Num IMLI GEHL lenghts")
im = VectorParam.Int([8], "IMLI history GEHL lengths")
logInb = Param.Unsigned("Log number of IMLI GEHL entries")
+iWeightInitValue = Param.Int(
+"Initial value of the weights of the IMLI history GEHL entries")
logBias = Param.Unsigned("Log size of Bias tables")
@@ -362,6 +370,9 @@
scCountersWidth = Param.Unsigned(6, "Statistical corrector counters
width")
+initialUpdateThresholdValue = Param.Int(0,
+"Initial pUpdate threshold counter value")
+
# TAGE-SC-L branch predictor as desribed in
# https://www.jilp.org/cbp2016/paper/AndreSeznecLimited.pdf
# It is a modified LTAGE predictor plus a statistical corrector predictor
@@ -425,12 +436,15 @@
bwnb = 3
bwm = [40, 24, 10]
logBwnb = 10
+bwWeightInitValue = 7
lnb = 3
lm = [11, 6, 3]
logLnb = 10
+lWeightInitValue = 7
logInb = 8
+iWeightInitValue = 7
class TAGE_SC_L_8KB_StatisticalCorrector(StatisticalCorrector):
type = 'TAGE_SC_L_8KB_StatisticalCorrector'
@@ -447,12 +461,15 @@
bwnb = 2
logBwnb = 7
bwm = [16, 8]
+bwWeightInitValue = 7
lnb = 2
logLnb = 7
lm = [6, 3]
+lWeightInitValue = 7
logInb = 7
+iWeightInitValue = 7
# 64KB TAGE-SC-L branch predictor as described in
# http://www.jilp.org/cbp2016/paper/AndreSeznecLimited.pdf
@@ -536,6 +553,9 @@
speculative_update = Param.Bool(False,
"Use speculative update for histories")
+initial_ghist_length = Param.Int(1, "Initial GHist length value")
+ignore_path_size = Param.Bool(False, "Ignore the path storage")
+
class Multiperspectiv
[gem5-dev] Change in gem5/gem5[master]: cpu-o3: Reset fault status for mem access in pushRequest
Gabor Dozsa has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/19388 ) Change subject: cpu-o3: Reset fault status for mem access in pushRequest .. cpu-o3: Reset fault status for mem access in pushRequest Reset the fault status always before translation is initiated in pushRequest() in the LSQ. This avoids the problem when a strictly ordered load needs to be re-executed multiple times. If the translation is delayed at one of those attempts then the internal panicFault (from the previous execution attempt) can get fired at commit. Change-Id: I0c22b2f7afd6e2cb00bc359a4a01042efd2d01d2 Signed-off-by: Gabor Dozsa Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/19388 Reviewed-by: Ciro Santilli Maintainer: Andreas Sandberg Tested-by: kokoro --- M src/cpu/o3/lsq_impl.hh 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Ciro Santilli: Looks good to me, approved Andreas Sandberg: Looks good to me, approved kokoro: Regressions pass diff --git a/src/cpu/o3/lsq_impl.hh b/src/cpu/o3/lsq_impl.hh index 70621a5..d4e0a28 100644 --- a/src/cpu/o3/lsq_impl.hh +++ b/src/cpu/o3/lsq_impl.hh @@ -724,6 +724,10 @@ inst->setRequest(); req->taskId(cpu->taskId()); +// There might be fault from a previous execution attempt if this is +// a strictly ordered load +inst->getFault() = NoFault; + req->initiateTranslation(); } -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/19388 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I0c22b2f7afd6e2cb00bc359a4a01042efd2d01d2 Gerrit-Change-Number: 19388 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Dozsa Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Ciro Santilli Gerrit-Reviewer: Gabor Dozsa Gerrit-Reviewer: Giacomo Gabrielli Gerrit-Reviewer: Giacomo Travaglini Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: kokoro Gerrit-MessageType: merged ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: stats: Add beta support for HDF5 stat dumps
Hello Daniel Carvalho, Gabe Black, Jason Lowe-Power, Nikos Nikoleris,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/8121
to look at the new patch set (#3).
Change subject: stats: Add beta support for HDF5 stat dumps
..
stats: Add beta support for HDF5 stat dumps
This changeset add support for stat dumps in the HDF5 file
format. HDF5 is a binary data format that represents data in a
file-system-like balanced tree. It has native support for
N-dimensional arrays and binary data (e.g., frame buffers).
It has the following benefits over traditional text stat files:
* Efficient storage of time series (multiple stat dumps)
* Fast lookup of stats
* Plenty of existing tooling (e.g., Python libraries and graphical
viewers)
* File format can be used to store frame buffers together with
normal stats.
Drawbacks:
* Large startup cost (single stat dump larger than text equivalent)
* Stat dumps are slower than text
Known limitations:
* Distributions and histograms aren't supported.
HDF5 stat output can be enabled using the 'h5' URL scheme when
overriding the stat file name on gem5's command line. The following
parameters are supported:
* chunking (unsigned): Number of time steps to pre-allocate
(default: 10)
* desc (bool): Output stat descriptions (default: True)
* formulas (bool): Output derived stats (default: True)
Example gem5 command line:
./build/ARM/gem5.opt \
--stats-file="h5://stats.h5?desc=False;formulas=False" \
configs/example/fs.py
Example Python stat consumer that computes IPC:
import h5py
f = h5py.File('stats.h5', 'r')
group = f['/system/cpu']
for i, c in zip(group['committedInsts'], group['numCycles']):
print i, c, i / c
Change-Id: I351c6cbff2fb7bef9012f47876ba227ed288975b
Signed-off-by: Andreas Sandberg
Reviewed-by: Nikos Nikoleris
---
M SConstruct
M src/base/SConscript
A src/base/stats/hdf5.cc
A src/base/stats/hdf5.hh
M src/python/m5/stats/__init__.py
M src/python/pybind11/stats.cc
6 files changed, 532 insertions(+), 4 deletions(-)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/8121
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I351c6cbff2fb7bef9012f47876ba227ed288975b
Gerrit-Change-Number: 8121
Gerrit-PatchSet: 3
Gerrit-Owner: Andreas Sandberg
Gerrit-Reviewer: Andreas Sandberg
Gerrit-Reviewer: Daniel Carvalho
Gerrit-Reviewer: Gabe Black
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-Reviewer: Nikos Nikoleris
Gerrit-CC: Dave Wen
Gerrit-MessageType: newpatchset
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: mem: Convert CommMonitor to the new stat framework
Andreas Sandberg has uploaded a new patch set (#4). ( https://gem5-review.googlesource.com/c/public/gem5/+/19371 ) Change subject: mem: Convert CommMonitor to the new stat framework .. mem: Convert CommMonitor to the new stat framework Change-Id: I851c29909f3e6923c0233505a4d0f2d266bc254f Signed-off-by: Andreas Sandberg --- M src/mem/comm_monitor.cc M src/mem/comm_monitor.hh 2 files changed, 142 insertions(+), 151 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/19371 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I851c29909f3e6923c0233505a4d0f2d266bc254f Gerrit-Change-Number: 19371 Gerrit-PatchSet: 4 Gerrit-Owner: Andreas Sandberg Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: stats: Add support for hierarchical stats
Hello Brandon Potter, Daniel Carvalho, Gabe Black, Jason Lowe-Power, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/19368 to look at the new patch set (#3). Change subject: stats: Add support for hierarchical stats .. stats: Add support for hierarchical stats This change makes the stat system aware of the hierarchical nature of stats. The aim is to achieve the following goals: * Make the SimObject hierarchy explicit in the stat system (i.e., get rid of name() + ".foo"). This makes stat naming less fragile and makes it possible to implement hierarchical formats like XML/HDF5/JSON in a clean way. * Make it more convenient to split stats into a separate struct/class that can be bound to a SimObject. This makes the namespace cleaner and makes stat accesses a bit more obvious. * Make it possible to build groups of stats in C++ that can be used in subcomponents in a SimObject (similar to what we do for checkpoint sections). This makes it easier to structure large components. * Enable partial stat dumps. Some of our internal users have been asking for this since a full stat dump can be large. * Enable better stat access from Python. This changeset implements solves the first three points by introducing a class (Stats::Group) that owns statistics belonging to the same object. SimObjects inherit from Stats::Group since they typically have statistics. New-style statistics need to be associated with a parent group at instantiation time. Instantiation typically sets the name and the description, other parameters need to be set by overriding Group::regStats() just like with legacy stats. Simple objects with scalar stats can typically avoid implementing regStats() altogether since the stat name and description are both specified in the constructor. For convenience reasons, statistics groups can be merged into other groups. This means that a SimObject can create a stat struct that inherits from Stats::Group and merge it into the parent group (SimObject). This can make the code cleaner since statistics tracking gets grouped into a single object. Stat visitors have a new API to expose the group structure. The Output::beginGroup(name) method is called at the beginning of a group and the Output::endGroup() method is called when all stats, and sub-groups, have been visited. Flat formats (e.g., the text format) typically need to maintain a stack to track the full path to a stat. Legacy, flat, statistics are still supported after applying this change. These stats don't belong to any group and stat visitors will not see a Output::beginGroup(name) call before their corresponding Output::visit() methods are called. Change-Id: I9025d61dfadeabcc8ecf30813ab2060def455648 Signed-off-by: Andreas Sandberg --- M src/base/SConscript M src/base/statistics.cc M src/base/statistics.hh A src/base/stats/group.cc A src/base/stats/group.hh M src/base/stats/output.hh M src/base/stats/text.cc M src/base/stats/text.hh M src/python/m5/SimObject.py M src/python/m5/simulate.py M src/python/m5/stats/__init__.py M src/python/pybind11/stats.cc M src/sim/sim_object.cc M src/sim/sim_object.hh 14 files changed, 705 insertions(+), 114 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/19368 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I9025d61dfadeabcc8ecf30813ab2060def455648 Gerrit-Change-Number: 19368 Gerrit-PatchSet: 3 Gerrit-Owner: Andreas Sandberg Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Brandon Potter Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Jason Lowe-Power Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: mem-ruby: Make MultiGrainBloomFilter generic
Hello kokoro, Nikos Nikoleris, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/18869 to look at the new patch set (#4). Change subject: mem-ruby: Make MultiGrainBloomFilter generic .. mem-ruby: Make MultiGrainBloomFilter generic Allow combining any number of Bloom Filters in the MultiGrain. Change-Id: I73ae33063e1feed731af6f625d2f64245f21df18 Signed-off-by: Daniel R. Carvalho --- M src/mem/ruby/filters/BloomFilters.py M src/mem/ruby/filters/MultiGrainBloomFilter.cc M src/mem/ruby/filters/MultiGrainBloomFilter.hh 3 files changed, 57 insertions(+), 48 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18869 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I73ae33063e1feed731af6f625d2f64245f21df18 Gerrit-Change-Number: 18869 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: Nikos Nikoleris Gerrit-Reviewer: kokoro Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: mem-ruby: Move Bloom Filters to base
Hello kokoro, Anthony Gutierrez, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/18875 to look at the new patch set (#4). Change subject: mem-ruby: Move Bloom Filters to base .. mem-ruby: Move Bloom Filters to base All Bloom Filters are completely independent of Ruby, and therefore can be used everywhere. As a side effect, Ruby was not using the filters, so their dependency was removed. Change-Id: Ic5f430610c33c0791fb81c79101ebe737189497e Signed-off-by: Daniel R. Carvalho --- R src/base/filters/BloomFilters.py R src/base/filters/SConscript R src/base/filters/base.hh R src/base/filters/block_bloom_filter.cc R src/base/filters/block_bloom_filter.hh R src/base/filters/bulk_bloom_filter.cc R src/base/filters/bulk_bloom_filter.hh R src/base/filters/h3_bloom_filter.cc R src/base/filters/h3_bloom_filter.hh R src/base/filters/lsb_counting_bloom_filter.cc R src/base/filters/lsb_counting_bloom_filter.hh R src/base/filters/multi_bit_sel_bloom_filter.cc R src/base/filters/multi_bit_sel_bloom_filter.hh R src/base/filters/multi_bloom_filter.cc R src/base/filters/multi_bloom_filter.hh M src/mem/protocol/RubySlicc_Types.sm M src/mem/ruby/SConscript 17 files changed, 107 insertions(+), 82 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18875 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Ic5f430610c33c0791fb81c79101ebe737189497e Gerrit-Change-Number: 18875 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Anthony Gutierrez Gerrit-Reviewer: kokoro Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: mem-ruby: Define BloomFilter namespace
Daniel Carvalho has uploaded a new patch set (#4). ( https://gem5-review.googlesource.com/c/public/gem5/+/18874 ) Change subject: mem-ruby: Define BloomFilter namespace .. mem-ruby: Define BloomFilter namespace Define a BloomFilter namespace and put all BloomFilter related code in it. As a side effect the BloomFilter classes have been renamed to remove the "BloomFilter" suffix. Change-Id: I3ee8cc225bf3b820e561c3e25a6bf38e0012e3a8 Signed-off-by: Daniel R. Carvalho --- M src/mem/ruby/filters/AbstractBloomFilter.hh M src/mem/ruby/filters/BlockBloomFilter.cc M src/mem/ruby/filters/BlockBloomFilter.hh M src/mem/ruby/filters/BloomFilters.py M src/mem/ruby/filters/BulkBloomFilter.cc M src/mem/ruby/filters/BulkBloomFilter.hh M src/mem/ruby/filters/H3BloomFilter.cc M src/mem/ruby/filters/H3BloomFilter.hh M src/mem/ruby/filters/LSB_CountingBloomFilter.cc M src/mem/ruby/filters/LSB_CountingBloomFilter.hh M src/mem/ruby/filters/MultiBitSelBloomFilter.cc M src/mem/ruby/filters/MultiBitSelBloomFilter.hh M src/mem/ruby/filters/MultiGrainBloomFilter.cc M src/mem/ruby/filters/MultiGrainBloomFilter.hh 14 files changed, 184 insertions(+), 127 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18874 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I3ee8cc225bf3b820e561c3e25a6bf38e0012e3a8 Gerrit-Change-Number: 18874 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: mem-ruby: Remove NonCountingBloomFilter
Hello kokoro, Nikos Nikoleris, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/18871 to look at the new patch set (#4). Change subject: mem-ruby: Remove NonCountingBloomFilter .. mem-ruby: Remove NonCountingBloomFilter Make BlockBloomFilter accept having a single bitfield, in which case it behaves exactly as the NonCountingBloomFilter, and thus the latter can be removed. Change-Id: I56d96a89290c933293ce434bbe0e8bcd4bbcaa42 Signed-off-by: Daniel R. Carvalho --- M src/mem/ruby/filters/BlockBloomFilter.cc M src/mem/ruby/filters/BloomFilters.py D src/mem/ruby/filters/NonCountingBloomFilter.cc D src/mem/ruby/filters/NonCountingBloomFilter.hh M src/mem/ruby/filters/SConscript 5 files changed, 2 insertions(+), 150 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18871 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I56d96a89290c933293ce434bbe0e8bcd4bbcaa42 Gerrit-Change-Number: 18871 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Nikos Nikoleris Gerrit-Reviewer: kokoro Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: mem-ruby: Parameterize xor bits in BlockBloomFilter
Hello Nikos Nikoleris, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/18870 to look at the new patch set (#4). Change subject: mem-ruby: Parameterize xor bits in BlockBloomFilter .. mem-ruby: Parameterize xor bits in BlockBloomFilter Parameterize bitfield ranges in BlockBloomFilter such that the hash is applied between masked bitfields of an address. Change-Id: I008bd873458e9815e98530e308491adb65bb34cb Signed-off-by: Daniel R. Carvalho --- M src/mem/ruby/filters/BlockBloomFilter.cc M src/mem/ruby/filters/BlockBloomFilter.hh M src/mem/ruby/filters/BloomFilters.py 3 files changed, 47 insertions(+), 11 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18870 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I008bd873458e9815e98530e308491adb65bb34cb Gerrit-Change-Number: 18870 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: Nikos Nikoleris Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
