[gem5-dev] Build failed in Jenkins: Compiler-Checks #23

2020-09-17 Thread jenkins-no-reply--- via gem5-dev
See Changes: [Jason Lowe-Power] cpu-minor: convert fetch2 to new style stats [gabeblack] arch: Add a virtual destructor to BaseHTMCheckpoint. [gabeblack] cpu: Fix style and add overrides to bas_dyn_inst.hh. [gabeb

[gem5-dev] Change in gem5/gem5[develop]: systemc: Add a missing override.

2020-09-17 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/34756 ) Change subject: systemc: Add a missing override. .. systemc: Add a missing override. A recent change accidentally

[gem5-dev] Change in gem5/testing[master]: testing, testing2: This is a test

2020-09-17 Thread Hoa Nguyen (Gerrit) via gem5-dev
Hoa Nguyen has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/testing/+/34716 ) Change subject: testing, testing2: This is a test .. testing, testing2: This is a test Signed-off-by: Hoa Nguy

[gem5-dev] Change in gem5/testing[master]: testing: This is a commit

2020-09-17 Thread Hoa Nguyen (Gerrit) via gem5-dev
Hoa Nguyen has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/testing/+/34715 ) Change subject: testing: This is a commit .. testing: This is a commit Signed-off-by: Hoa Nguyen Change-Id: I

[gem5-dev] Re: A few quick thoughts

2020-09-17 Thread Jason Lowe-Power via gem5-dev
On Thu, Sep 17, 2020 at 2:48 PM Gabe Black via gem5-dev wrote: > 1. Sounds good, I'll hopefully have some time to put together a CL in no > too long (weekend?). > > 2. I 5ries to figure out a way to do it without the template that wasn't > really gross a somewhat fragile and wasn't able to, but t

[gem5-dev] Re: A few quick thoughts

2020-09-17 Thread Gabe Black via gem5-dev
1. Sounds good, I'll hopefully have some time to put together a CL in no too long (weekend?). 2. I 5ries to figure out a way to do it without the template that wasn't really gross a somewhat fragile and wasn't able to, but that would definitely be preferable. I'll keep thinking about it, but the i

[gem5-dev] Change in gem5/gem5[develop]: gpu-compute: Fix deadlock in fetch_unit after branch instruction

2020-09-17 Thread Kyle Roarty (Gerrit) via gem5-dev
Kyle Roarty has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/34555 ) Change subject: gpu-compute: Fix deadlock in fetch_unit after branch instruction .. gpu-compute: Fix deadlock in fetch_un

[gem5-dev] Re: A few quick thoughts

2020-09-17 Thread Bobby Bruce via gem5-dev
1) Seems fine to me. 2) I remember looking into this and I agree with Jason, it involves template magic which I'm not a huge fan of. I feel like in order to add these compile time asserts we'd be sacrificing some readability/ease-of-usability of bitfields.hh. This may just be a "me thing", but som

[gem5-dev] Re: A few quick thoughts

2020-09-17 Thread Jason Lowe-Power via gem5-dev
Hey Gabe, On Thu, Sep 17, 2020 at 4:46 AM Gabe Black via gem5-dev wrote: > 1. Use __builtin_expect() for panic, fatal, etc. Preexisting library > functions like assert probably already have this, but our versions don't > and have similar behavior patterns. This should improve performance. > See

[gem5-dev] A few quick thoughts

2020-09-17 Thread Gabe Black via gem5-dev
1. Use __builtin_expect() for panic, fatal, etc. Preexisting library functions like assert probably already have this, but our versions don't and have similar behavior patterns. This should improve performance. 2. Create template versions of the bits, etc functions in bitfields.hh which use static

[gem5-dev] Change in gem5/gem5[develop]: base: avoid std::mutex by implementing a spinlock

2020-09-17 Thread Earl Ou (Gerrit) via gem5-dev
Earl Ou has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/34696 ) Change subject: base: avoid std::mutex by implementing a spinlock .. base: avoid std::mutex by implementing a spinloc

[gem5-dev] Change in gem5/gem5[develop]: systemc: avoid mutex lock in non async cases

2020-09-17 Thread Earl Ou (Gerrit) via gem5-dev
Earl Ou has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/34695 ) Change subject: systemc: avoid mutex lock in non async cases .. systemc: avoid mutex lock in non async cases Avoid a