[gem5-dev] Change in gem5/gem5[develop]: base: Add unit test for SymbolTable

2021-03-18 Thread Daniel Carvalho (Gerrit) via gem5-dev
\ntest.binding_0=1\n" +"test.addr_1=32\ntest.symbol_1=symbol2\n" +"test.addr_2=48\ntest.symbol_2=symbol3\ntest.binding_2=1\n"; +cp.close(); +} + +// Unserialization +{ + Loader::SymbolTable uns

[gem5-dev] Change in gem5/gem5[develop]: base: Document the SymbolTable

2021-03-18 Thread Daniel Carvalho (Gerrit) via gem5-dev
errit-Change-Id: Ia4f18bf60d3d8eab7a775f34f553d420816d62b9 Gerrit-Change-Number: 43248 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_pag

[gem5-dev] Change in gem5/gem5[develop]: sim: Make SimObject inherit from Named

2021-03-18 Thread Daniel Carvalho (Gerrit) via gem5-dev
or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I5e0cb828da0810b47217e96e302857e32083c50b Gerrit-Change-Number: 43246 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel

[gem5-dev] Change in gem5/gem5[develop]: base: Remove duplicate of findNearest

2021-03-18 Thread Daniel Carvalho (Gerrit) via gem5-dev
atchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base: Make Named::name() virtual

2021-03-18 Thread Daniel Carvalho (Gerrit) via gem5-dev
Gerrit-Change-Id: I6a4bc0cd13ca05e75557ed90b12a6bd6708925ec Gerrit-Change-Number: 43245 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le

[gem5-dev] Change in gem5/gem5[develop]: base-stats: Fix Watt Unit

2021-03-18 Thread Daniel Carvalho (Gerrit) via gem5-dev
filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ic9ae755115e2eca94492f3d5b11245db9fe42bb6 Gerrit-Change-Number: 43247 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange

[gem5-dev] Change in gem5/gem5[release-staging-v21-0]: base-stats: Fix Watt Unit

2021-03-17 Thread Daniel Carvalho (Gerrit) via gem5-dev
/settings Gerrit-Project: public/gem5 Gerrit-Branch: release-staging-v21-0 Gerrit-Change-Id: Ic9ae755115e2eca94492f3d5b11245db9fe42bb6 Gerrit-Change-Number: 43006 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer

[gem5-dev] Change in gem5/gem5[develop]: base: Move Named class to its own file

2021-03-15 Thread Daniel Carvalho (Gerrit) via gem5-dev
/mem_checker.hh index c924b1d..101da4f 100644 --- a/src/mem/mem_checker.hh +++ b/src/mem/mem_checker.hh @@ -47,6 +47,7 @@ #include #include "base/cprintf.hh" +#include "base/named.hh" #include "base/trace.hh" #include "base/types.hh" #include "de

[gem5-dev] Change in gem5/gem5[develop]: base: Add fatal tests to sat_counter

2021-03-15 Thread Daniel Carvalho (Gerrit) via gem5-dev
ing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ia610636fe8cf636401e2b2ed623bf20b41147ea4 Gerrit-Change-Number: 42763 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Bobby R. Bruce Gerrit-R

[gem5-dev] Change in gem5/gem5[develop]: base-stats: Fix null addStatGroup

2021-03-15 Thread Daniel Carvalho (Gerrit) via gem5-dev
1a698 Gerrit-Change-Number: 43012 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: WIP,base-stats: Add unit test for Stats::Info

2021-03-15 Thread Daniel Carvalho (Gerrit) via gem5-dev
Id: I8b169d34c1309b37ba79fa9cf6895547b7e97fc0 Gerrit-Change-Number: 43009 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base-stats: Add unit test for Stats::Group

2021-03-15 Thread Daniel Carvalho (Gerrit) via gem5-dev
nfo_found, nullptr); +ASSERT_EQ(info_found->name, "InfoResolveStatMerged"); + +info_found = root.resolveStat("InfoResolveStatMerged2"); +ASSERT_NE(info_found, nullptr); +ASSERT_EQ(info_found->name, "InfoResolveStatMerged2"); +} + +/** Tes

[gem5-dev] Change in gem5/gem5[develop]: base-stats: Add unit test for Stats::Units

2021-03-15 Thread Daniel Carvalho (Gerrit) via gem5-dev
it https://gem5-review.googlesource.com/c/public/gem5/+/43007 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I87f729928bb99c7f4d657bca0307955be933d3

[gem5-dev] Change in gem5/gem5[develop]: base-stats: Fix Watt Unit

2021-03-15 Thread Daniel Carvalho (Gerrit) via gem5-dev
filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ic9ae755115e2eca94492f3d5b11245db9fe42bb6 Gerrit-Change-Number: 43006 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange

[gem5-dev] Change in gem5/gem5[develop]: base-stats: Remove SimObject dependency from stats group

2021-03-15 Thread Daniel Carvalho (Gerrit) via gem5-dev
} g.second->regStats(); -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/43005 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I10545

[gem5-dev] Change in gem5/gem5[develop]: sim: Remove SimObject dependency from Drainable

2021-03-15 Thread Daniel Carvalho (Gerrit) via gem5-dev
://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ia064f7ab1a693586b6bd0045f431512ca3c78801 Gerrit-Change-Number: 43004 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___

[gem5-dev] Change in gem5/gem5[develop]: base-stats: Make Rate's compilation smarter

2021-03-15 Thread Daniel Carvalho (Gerrit) via gem5-dev
, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I36ab7c73b239ccc86d866c5b38e14fd765bbbd0f Gerrit-Change-Number: 43008 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageTy

[gem5-dev] Change in gem5/gem5[develop]: base-stats: Fix self addition bug in addStatGroup

2021-03-15 Thread Daniel Carvalho (Gerrit) via gem5-dev
3011 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: sim: Add unit test for sim/port

2021-03-15 Thread Daniel Carvalho (Gerrit) via gem5-dev
cout's streambuf +std::cout.rdbuf(old); +} -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/43003 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Chang

[gem5-dev] Change in gem5/gem5[develop]: base: Add fatal tests to sat_counter

2021-03-11 Thread Daniel Carvalho (Gerrit) via gem5-dev
+/42763 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ia610636fe8cf636401e2b2ed623bf20b41147ea4 Gerrit-Change-Number: 42763 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base: Add LOC to Loggers

2021-03-03 Thread Daniel Carvalho (Gerrit) via gem5-dev
derr(), +::testing::HasSubstr("warn: message\n")); +} else { +ASSERT_EQ(testing::internal::GetCapturedStderr(), ""); +} } } @@ -571,8 +590,12 @@ for (int i = 0; i < 10; i++) { testing::internal::CaptureStderr(); warn_if_once(i == 3, "message\n"); -ASSERT_EQ(testing::internal::GetCapturedStderr(), -(i == 3) ? "warn: message\n" : ""); +if (i == 3) { +ASSERT_THAT(testing::internal::GetCapturedStderr(), +::testing::HasSubstr("warn: message\n")); +} else { +ASSERT_EQ(testing::internal::GetCapturedStderr(), ""); +} } } @@ -581,7 +604,7 @@ TEST(LoggingDeathTest, ChattyAssert) { chatty_assert(true, "message\n"); -ASSERT_DEATH(chatty_assert(false, "message\n"), ::testing::StartsWith( +ASSERT_DEATH(chatty_assert(false, "message\n"), ::testing::HasSubstr( "panic: assert(false) failed: message\nMemory Usage:")); } #endif -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/42141 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I74e0637b2943049134bd3e9a4bc6cab3766591a9 Gerrit-Change-Number: 42141 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base: Remove DDUMPN

2021-03-02 Thread Daniel Carvalho (Gerrit) via gem5-dev
scribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I6fe048910ad1d39b6b10af509ba84aab1792b8fb Gerrit-Change-Number: 41335 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: B

[gem5-dev] Change in gem5/gem5[develop]: base: Remove hostname from hostinfo

2021-02-19 Thread Daniel Carvalho (Gerrit) via gem5-dev
t: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I20919a49b123a6a49582d9cfacf1fd167cb44776 Gerrit-Change-Number: 41394 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: kokoro Gerrit-MessageType: merged

[gem5-dev] Change in gem5/gem5[develop]: base: Clean up base/hostinfo

2021-02-19 Thread Daniel Carvalho (Gerrit) via gem5-dev
unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I54e1f13231e512d26cf0127cc80256fb5e91bf91 Gerrit-Change-Number: 41393 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Carvalho Gerrit-R

[gem5-dev] Change in gem5/gem5[develop]: base: Fix scientific number conversion in base/str

2021-02-19 Thread Daniel Carvalho (Gerrit) via gem5-dev
he submitted one. -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/38775 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I6a9599d8473909d274326b6f8c268e3603044ab4 G

[gem5-dev] Change in gem5/gem5[develop]: base: Add enum to_number tests

2021-02-14 Thread Daniel Carvalho (Gerrit) via gem5-dev
Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: kokoro Gerrit-MessageType: merged ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(we

[gem5-dev] Change in gem5/gem5[develop]: base: Add unit test for base/logging

2021-02-14 Thread Daniel Carvalho (Gerrit) via gem5-dev
only prints the message once in a loop. */ +TEST(LoggingTest, InformOnce) +{ +for (int i = 0; i < 10; i++) { +testing::internal::CaptureStderr(); +inform_once("message\n"); + ASSERT_EQ(testing::internal::GetCaptur

[gem5-dev] Change in gem5/gem5[develop]: tests: Remove GTestLogger

2021-02-14 Thread Daniel Carvalho (Gerrit) via gem5-dev
-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: If4510eeeb40c936f986d84b639206c5884a08984 Gerrit-Change-Number: 41396 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange _

[gem5-dev] Change in gem5/gem5[develop]: base: Fix incorrect use of Logger::print

2021-02-14 Thread Daniel Carvalho (Gerrit) via gem5-dev
com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Idc51d2ef28ab4721d2be16f3e5fce19c494a0d47 Gerrit-Change-Number: 41399 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing

[gem5-dev] Change in gem5/gem5[develop]: tests: Remove gtest/logging

2021-02-14 Thread Daniel Carvalho (Gerrit) via gem5-dev
ript +++ b/src/sim/SConscript @@ -86,7 +86,7 @@ GTest('byteswap.test', 'byteswap.test.cc', '../base/types.cc') GTest('guest_abi.test', 'guest_abi.test.cc') -GTest('proxy_ptr.test', 'proxy_ptr.test.cc') +GTest('proxy_ptr.test', 'proxy_ptr.test.cc', with_tag('gem5 logging')) if env['TARGET_ISA'] !=

[gem5-dev] Change in gem5/gem5[develop]: base: Remove hostname from hostinfo

2021-02-14 Thread Daniel Carvalho (Gerrit) via gem5-dev
582d9cfacf1fd167cb44776 Gerrit-Change-Number: 41394 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base: Add default log functionality to Logger

2021-02-14 Thread Daniel Carvalho (Gerrit) via gem5-dev
develop Gerrit-Change-Id: I6805fa14f58ddc7d37b00fcd7fcacb32e0b5d456 Gerrit-Change-Number: 41395 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base: Clean up base/hostinfo

2021-02-14 Thread Daniel Carvalho (Gerrit) via gem5-dev
://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I54e1f13231e512d26cf0127cc80256fb5e91bf91 Gerrit-Change-Number: 41393 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem

[gem5-dev] Change in gem5/gem5[develop]: base: Add unit test for base/trace.hh

2021-02-12 Thread Daniel Carvalho (Gerrit) via gem5-dev
UNCONDITIONAL) +{ +StringWrap name("Foo"); + +// Flag enabled +Trace::enable(); +EXPECT_TRUE(Debug::changeFlag("TraceTestDebugFlag", true)); + EXPECT_TRUE(Debug::changeFlag("FmtFlag", true)); +DPRINTF_UNCONDITIONAL(TraceTestDebugFlag, "Test mess

[gem5-dev] Change in gem5/gem5[develop]: base: Add enum to_number tests

2021-02-12 Thread Daniel Carvalho (Gerrit) via gem5-dev
41334 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I7967c62feea335f3ffda40d8bf0334c20b53ee6c Gerrit-Change-Number: 41334 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho

[gem5-dev] Change in gem5/gem5[develop]: base: Remove DDUMPN

2021-02-12 Thread Daniel Carvalho (Gerrit) via gem5-dev
ce.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I6fe048910ad1d39b6b10af509ba84aab1792b8fb Gerrit-Change-Number: 41335 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailin

[gem5-dev] Change in gem5/gem5[develop]: base: Fix scientific number conversion in base/str

2021-02-12 Thread Daniel Carvalho (Gerrit) via gem5-dev
* (case-insenstive), and sets the second argument to the bool equivilent. -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/41333 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop

[gem5-dev] Change in gem5/gem5[develop]: base: Fix copyright of base/stats/SConscript

2021-02-10 Thread Daniel Carvalho (Gerrit) via gem5-dev
: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ib3b7a34ea889fbd9a6f2a8e21a6bb24432939da9 Gerrit-Change-Number: 40755 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: Giacomo Travaglini Gerrit-Reviewer

[gem5-dev] Change in gem5/gem5[develop]: dev: Fix register bank unit test in .debug

2021-02-07 Thread Daniel Carvalho (Gerrit) via gem5-dev
-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Id736dc42a82aea871da6a53c06d89fd399d3559a Gerrit-Change-Number: 40836 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: Gabe Black Gerrit

[gem5-dev] Change in gem5/gem5[develop]: base: Fix storage unit test in .fast

2021-02-07 Thread Daniel Carvalho (Gerrit) via gem5-dev
visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I0dd78f184809a453035046bc76640dfb5988bb5f Gerrit-Change-Number: 40835 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carvalho Gerrit-

[gem5-dev] Change in gem5/gem5[develop]: base: Fix storage unit test in .fast

2021-02-06 Thread Daniel Carvalho (Gerrit) via gem5-dev
or help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I0dd78f184809a453035046bc76640dfb5988bb5f Gerrit-Change-Number: 40835 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-Me

[gem5-dev] Change in gem5/gem5[develop]: dev: Fix register bank unit test in .debug

2021-02-06 Thread Daniel Carvalho (Gerrit) via gem5-dev
-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Id736dc42a82aea871da6a53c06d89fd399d3559a Gerrit-Change-Number: 40836 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org

[gem5-dev] Change in gem5/gem5[develop]: base: Initialize storage params on constructor

2021-02-05 Thread Daniel Carvalho (Gerrit) via gem5-dev
5/+/25426 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I66a902cd5a7c809d3ac5be65b406de29fc0acf1c Gerrit-Change-Number: 25426 Gerrit-PatchSet: 15 Gerrit-Owner: Daniel Carvalho Ger

[gem5-dev] Change in gem5/gem5[develop]: base: Fix storage params safe_cast

2021-02-05 Thread Daniel Carvalho (Gerrit) via gem5-dev
Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: kokoro Gerrit-MessageType: merged ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le

[gem5-dev] Change in gem5/gem5[develop]: base: Fix copyright of base/stats/SConscript

2021-02-05 Thread Daniel Carvalho (Gerrit) via gem5-dev
: develop Gerrit-Change-Id: Ib3b7a34ea889fbd9a6f2a8e21a6bb24432939da9 Gerrit-Change-Number: 40755 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email

[gem5-dev] Change in gem5/gem5[develop]: base: Make read-only functions const in ScalarBase

2021-02-05 Thread Daniel Carvalho (Gerrit) via gem5-dev
gs Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I4dd3899a29a741a7d8cd199ccd254b346d86ae07 Gerrit-Change-Number: 27084 Gerrit-PatchSet: 13 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: Gem5 Cloud

[gem5-dev] Change in gem5/gem5[develop]: base: Fix storage params safe_cast

2021-02-03 Thread Daniel Carvalho (Gerrit) via gem5-dev
-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: scons: Add an "All" compound debug flag

2021-02-03 Thread Daniel Carvalho (Gerrit) via gem5-dev
Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: If40f2f708be1495fa2b2380266164d5d44d7cffa Gerrit-Change-Number: 39077 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: Gabe Black Gerrit-Reviewer

[gem5-dev] Change in gem5/gem5[develop]: base: Move Stats::Info functions to its own source file

2021-02-02 Thread Daniel Carvalho (Gerrit) via gem5-dev
se/stats/info.hh index ad34b39..d9a6654 100644 --- a/src/base/stats/info.hh +++ b/src/base/stats/info.hh @@ -255,6 +255,9 @@ SparseHistData data; }; +typedef std::map NameMapType; +NameMapType (); + } // namespace Stats #endif // __BASE_STATS_INFO_HH__ -- To view, visit https://gem5-review

[gem5-dev] Change in gem5/gem5[develop]: sim: Move cur tick to its own files

2021-02-02 Thread Daniel Carvalho (Gerrit) via gem5-dev
unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ib4348312afb90765edb4f94c80785df1275b2004 Gerrit-Change-Number: 39835 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Carvalho Gerrit-R

[gem5-dev] Change in gem5/gem5[develop]: base,tests: Add a basic fake class to handle curTick

2021-02-02 Thread Daniel Carvalho (Gerrit) via gem5-dev
filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Iba8ecc049acdd097caa4d9cf05ac8d78bbaf03cc Gerrit-Change-Number: 39836 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carv

[gem5-dev] Change in gem5/gem5[develop]: scons: Separate debug flags from debug-format flags

2021-02-02 Thread Daniel Carvalho (Gerrit) via gem5-dev
) .def("kids", ::CompoundFlag::kids) ; -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/39076 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch:

[gem5-dev] Change in gem5/gem5[develop]: sim: Move cur tick to its own files

2021-01-26 Thread Daniel Carvalho (Gerrit) via gem5-dev
ng mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ib4348312afb90765edb4f94c80785df1275b2004 Gerrit-Change-Number: 39835 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange __

[gem5-dev] Change in gem5/gem5[develop]: base: Rename Flags::update as Flags::replace

2021-01-18 Thread Daniel Carvalho (Gerrit) via gem5-dev
unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ic7613ae09ecf9b92e31103b4e928192c07e9b640 Gerrit-Change-Number: 38737 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Carvalho Gerri

[gem5-dev] Change in gem5/gem5[develop]: base: Add unit tests for flags.hh

2021-01-18 Thread Daniel Carvalho (Gerrit) via gem5-dev
; 9) is not set in value_a, but it is in value_b, so it is set +// (1 << 10) is not set in both values, so it remains not set +const uint32_t result = (1 << 5) | (1 << 6) | (1 << 9); +Flags flags(value_a); +flags.update(value_b, mask); +ASSERT_EQ(re

[gem5-dev] Change in gem5/gem5[develop]: base: Remove dubious/unused Flags functions

2021-01-18 Thread Daniel Carvalho (Gerrit) via gem5-dev
5/+/38736 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ia7cbfd0726943506a3f04dc417e67a0b57cdbf95 Gerrit-Change-Number: 38736 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel

[gem5-dev] Change in gem5/gem5[develop]: misc: Fix some includes

2021-01-15 Thread Daniel Carvalho (Gerrit) via gem5-dev
@@ #include "sim/clocked_object.hh" #include "sim/linear_solver.hh" #include "sim/power/thermal_domain.hh" +#include "sim/serialize.hh" #include "sim/sim_object.hh" /** diff --git a/src/sim/power_state.cc b/src/sim/power_state.cc index a11ed43..ff

[gem5-dev] Change in gem5/gem5[develop]: base: Add unit test for debug.hh

2021-01-15 Thread Daniel Carvalho (Gerrit) via gem5-dev
lag_a.status()); +ASSERT_FALSE(flag_b.status()); +ASSERT_FALSE(flag_c.status()); +ASSERT_FALSE(flag_d.status()); + ASSERT_FALSE(flag_e.status()); +flag_a.enable(); +flag_c.enable(); +compound_flag_b.enable(); + +// Verify that the

[gem5-dev] Change in gem5/gem5[develop]: base: Rename Flag status to enabled

2021-01-15 Thread Daniel Carvalho (Gerrit) via gem5-dev
(const Debug::Flag *flag) { - return flag->status(); + return flag->enabled(); }, [](Debug::Flag *flag, bool state) { if (state) { @@ -106,7 +106,7 @@

[gem5-dev] Change in gem5/gem5[develop]: cpu-o3: Add missing tid in Rename's debug message

2021-01-14 Thread Daniel Carvalho (Gerrit) via gem5-dev
e-Number: 39075 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Giacomo Travaglini Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: kokoro Gerrit-MessageType: merged ___ ge

[gem5-dev] Change in gem5/gem5[develop]: scons: Add an "All" compound debug flag

2021-01-13 Thread Daniel Carvalho (Gerrit) via gem5-dev
ing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: If40f2f708be1495fa2b2380266164d5d44d7cffa Gerrit-Change-Number: 39077 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange __

[gem5-dev] Change in gem5/gem5[develop]: cpu-o3: Add missing tid in Rename's debug message

2021-01-13 Thread Daniel Carvalho (Gerrit) via gem5-dev
57f299145954fe72196f5969f29 Gerrit-Change-Number: 39075 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: scons: Separate debug flags from debug-format flags

2021-01-13 Thread Daniel Carvalho (Gerrit) via gem5-dev
gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ieae68745276218cf4e9c1d37d7bf3bd1f19709ae Gerrit-Change-Number: 39076 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___

[gem5-dev] Change in gem5/gem5[develop]: base: Add documentation to flags.hh

2021-01-13 Thread Daniel Carvalho (Gerrit) via gem5-dev
Gerrit-Change-Number: 38735 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: kokoro Gerrit-MessageType: merged ___ gem5-dev mailing

[gem5-dev] Change in gem5/gem5[develop]: base: Remove Flags assignment

2021-01-13 Thread Daniel Carvalho (Gerrit) via gem5-dev
2 Gerrit-Change-Number: 38713 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: Hoa Nguyen Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: kokoro

[gem5-dev] Change in gem5/gem5[develop]: base: Fix uninitialized variable in Flag

2021-01-13 Thread Daniel Carvalho (Gerrit) via gem5-dev
it-Branch: develop Gerrit-Change-Id: If51ab6ae038c7c397bc83de1c73af348c1db4ef8 Gerrit-Change-Number: 38707 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: Gabe Black Gerrit-Review

[gem5-dev] Change in gem5/gem5[develop]: base: Remove flag from allFlags on destruction

2021-01-13 Thread Daniel Carvalho (Gerrit) via gem5-dev
or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I201371a770c56e11b92532e146d577c6ecb29d34 Gerrit-Change-Number: 38709 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Andreas S

[gem5-dev] Change in gem5/gem5[develop]: base: Assert Flags' type is unsigned

2021-01-13 Thread Daniel Carvalho (Gerrit) via gem5-dev
er: Daniel Carvalho Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: kokoro Gerrit-MessageType: merged ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to g

[gem5-dev] Change in gem5/gem5[develop]: mem-cache: Fix update of useful prefetches

2021-01-13 Thread Daniel Carvalho (Gerrit) via gem5-dev
t https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Iff298f7bea11013f411f4ba39dba705fd81a0cd4 Gerrit-Change-Number: 38177 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel C

[gem5-dev] Change in gem5/gem5[develop]: misc: Fix coding style for class-opening braces

2021-01-12 Thread Daniel Carvalho (Gerrit) via gem5-dev
ps://gem5-review.googlesource.com/c/public/gem5/+/39015 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I17615ce16a333d69867b27c7bae0f4fdafd8b2eb Gerrit-Change-Number: 39015 Gerrit-PatchSet: 1 Gerrit-Owner:

[gem5-dev] Change in gem5/gem5[develop]: util: Add verifier for opening braces of classes

2021-01-12 Thread Daniel Carvalho (Gerrit) via gem5-dev
esource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I232df1a9ebd974b9f4f66e1d96d03b12513bd49f Gerrit-Change-Number: 39016 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -

[gem5-dev] Change in gem5/gem5[develop]: base: Move Named class to its own file

2021-01-06 Thread Daniel Carvalho (Gerrit) via gem5-dev
rvations.begin(), - lastCompletedTransaction(, before)); +lastCompletedTransaction(, before)); // Pruning of writeClusters if (!writeClusters.empty()) { diff --git a/src/mem/mem_checker.hh b/src/mem/mem_checker.hh index 41aa691..7060f88 100644 --- a/src/mem/mem_checker.hh +++ b/src/mem/mem_checker.hh @@ -38,13 +38,15 @@ #ifndef __MEM_MEM_CHECKER_HH__ #define __MEM_MEM_CHECKER_HH__ +#include +#include #include #include #include #include #include -#include "base/logging.hh" +#include "base/named.hh" #include "base/trace.hh" #include "base/types.hh" #include "debug/MemChecker.hh" -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/38743 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I314e850b4fafd7804d919fd3fe6dec44822e1f48 Gerrit-Change-Number: 38743 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base: Add M5_VAR_USED in Debug::Flag

2021-01-06 Thread Daniel Carvalho (Gerrit) via gem5-dev
ba8d6d65f5723a7 Gerrit-Change-Number: 38742 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: sim: Fix ParseParam and add Parse/ShowParam tests

2020-12-31 Thread Daniel Carvalho (Gerrit) via gem5-dev
uot;"); +parser.show(ss, 123456.789); +EXPECT_EQ("123457", ss.str()); +ss.str(""); +parser.show(ss, -123456.789); +EXPECT_EQ("-123457", ss.str()); +ss.str(""); +parser.show(ss, 1234567.89); +EXPECT_EQ("1.23457e+06",

[gem5-dev] Change in gem5/gem5[develop]: base: Add double tests to base/str

2020-12-31 Thread Daniel Carvalho (Gerrit) via gem5-dev
t https://gem5-review.googlesource.com/c/public/gem5/+/38775 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I6a9599d8473909d274326b6f8c268e3603044ab4 Gerrit-Change-Number: 38

[gem5-dev] Change in gem5/gem5[develop]: sim: Remove SimObject and Event dependency from serialize.hh

2020-12-29 Thread Daniel Carvalho (Gerrit) via gem5-dev
r) + * + * @ingroup api_serialize + */ +#define SERIALIZE_OBJPTR(objptr)paramOut(cp, #objptr, (objptr)->name()) + +/** + * \def UNSERIALIZE_OBJPTR(objptr) + * + * @ingroup api_serialize + */ +#define UNSERIALIZE_OBJPTR(objptr) \ +do {\ +SimObject *sptr;\ +objParamIn(cp, #objptr, sptr); \ +objptr = dynamic_cast(sptr); \ +} while (0) + #endif // __SIM_OBJECT_HH__ -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/38740 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I9438b799d7e9d4c992a62c7f9d1f15f3f3250a5a Gerrit-Change-Number: 38740 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: sim: Make IniFile non-pointer in CheckpointIn

2020-12-29 Thread Daniel Carvalho (Gerrit) via gem5-dev
c/public/gem5/+/38741 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I784c94c8b775880def8339df63540357c2078c7b Gerrit-Change-Number: 38741 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel

[gem5-dev] Change in gem5/gem5[develop]: sim: Move SimObjectResolver dependency to SimObject

2020-12-29 Thread Daniel Carvalho (Gerrit) via gem5-dev
}; /** -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/38739 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I9973bea0e3c6cabb0051a55dbf9aebef8a5

[gem5-dev] Change in gem5/gem5[develop]: misc: Fix some includes

2020-12-29 Thread Daniel Carvalho (Gerrit) via gem5-dev
t.cc +++ b/src/sim/ticked_object.cc @@ -39,6 +39,7 @@ #include "params/TickedObject.hh" #include "sim/clocked_object.hh" +#include "sim/serialize.hh" Ticked::Ticked(ClockedObject _, Stats::Scalar *imported_num_cycles, diff --git a/src/sim/voltage_domain.cc b/sr

[gem5-dev] Change in gem5/gem5[develop]: base: Add unit tests for flags.hh

2020-12-26 Thread Daniel Carvalho (Gerrit) via gem5-dev
both values, so it remains set +// (1 << 9) is not set in value_a, but it is in value_b, so it is set +// (1 << 10) is not set in both values, so it remains not set +const uint32_t result = (1 << 5) | (1 << 6) | (1 &l

[gem5-dev] Change in gem5/gem5[develop]: base: Remove dubious/unused Flags functions

2020-12-26 Thread Daniel Carvalho (Gerrit) via gem5-dev
e, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ia7cbfd0726943506a3f04dc417e67a0b57cdbf95 Gerrit-Change-Number: 38736 Gerrit-PatchSet: 1 Gerrit-Own

[gem5-dev] Change in gem5/gem5[develop]: base: Remove Flags assignment

2020-12-26 Thread Daniel Carvalho (Gerrit) via gem5-dev
s, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I8430045c42c003efc74e343cc5b4a4350bc2ad92 Gerrit-Change-Number: 38713 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: n

[gem5-dev] Change in gem5/gem5[develop]: base: Assert Flags' type is unsigned

2020-12-26 Thread Daniel Carvalho (Gerrit) via gem5-dev
t-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base: Add documentation to flags.hh

2020-12-26 Thread Daniel Carvalho (Gerrit) via gem5-dev
sit https://gem5-review.googlesource.com/c/public/gem5/+/38735 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I924b1d5c20a3e2066be64ab124ae1a5d96d4b3bf Gerrit-Change-Number:

[gem5-dev] Change in gem5/gem5[develop]: base: Rename Flags::update as Flags::replace

2020-12-26 Thread Daniel Carvalho (Gerrit) via gem5-dev
e.com/c/public/gem5/+/38737 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ic7613ae09ecf9b92e31103b4e928192c07e9b640 Gerrit-Change-Number: 38737 Gerrit-Patc

[gem5-dev] Change in gem5/gem5[develop]: base: Add unit test for debug.hh

2020-12-25 Thread Daniel Carvalho (Gerrit) via gem5-dev
TestB", "", +{_e}); + +// Enable a few flags +ASSERT_FALSE(flag_a.status()); +ASSERT_FALSE(flag_b.status()); +ASSERT_FALSE(flag_c.status()); + ASSERT_FALSE(flag_d.status()); +ASSERT_FALSE(flag_e.status()); +flag_a.enable(); +flag_c.enable(); +

[gem5-dev] Change in gem5/gem5[develop]: base: Fix unitialized variable in Flag

2020-12-25 Thread Daniel Carvalho (Gerrit) via gem5-dev
ef8 Gerrit-Change-Number: 38707 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base: Rename Flag status to enabled

2020-12-25 Thread Daniel Carvalho (Gerrit) via gem5-dev
[](const Debug::Flag *flag) { - return flag->status(); + return flag->enabled(); }, [](Debug::Flag *flag, bool state) { if (state) { @@ -106,7 +106,7 @@

[gem5-dev] Change in gem5/gem5[develop]: base: Remove flag from allFlags on destruction

2020-12-25 Thread Daniel Carvalho (Gerrit) via gem5-dev
t https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I201371a770c56e11b92532e146d577c6ecb29d34 Gerrit-Change-Number: 38709 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange _

[gem5-dev] Change in gem5/gem5[develop]: base: Remove negation operator in Flag

2020-12-25 Thread Daniel Carvalho (Gerrit) via gem5-dev
Gerrit-Change-Number: 38708 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s

[gem5-dev] Change in gem5/gem5[develop]: sim: Make ProbeManager instance a non-pointer

2020-12-24 Thread Daniel Carvalho (Gerrit) via gem5-dev
107,7 @@ { } -ProbeManager * +ProbeManager & SimObject::getProbeManager() { return probeManager; diff --git a/src/sim/sim_object.hh b/src/sim/sim_object.hh index a75f8dd..e2aaf05 100644 --- a/src/sim/sim_object.hh +++ b/src/sim/sim_object.hh @@ -54,10 +54,10 @@ #include "sim/d

[gem5-dev] Change in gem5/gem5[develop]: sim: Handle ProbePoint creation with ProbeManager

2020-12-24 Thread Daniel Carvalho (Gerrit) via gem5-dev
. + * @param name The name of the ProbePoint to create. + * @return A pointer to the probe point, so that a cached copy can + * be kept to generate notifications. */ -void addPoint(ProbePoint ); +template + std::shared_ptr +addPoint(const std

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: Fix memory leak of PMU events

2020-12-24 Thread Daniel Carvalho (Gerrit) via gem5-dev
view, visit https://gem5-review.googlesource.com/c/public/gem5/+/38703 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I3cd958310008799f0873af3a490f847a21b5 Gerrit-Change-Number:

[gem5-dev] Change in gem5/gem5[develop]: misc: Prefer ProbeListenerArg over ProbeListenerArgBase

2020-12-24 Thread Daniel Carvalho (Gerrit) via gem5-dev
source.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I93947214c301be95cc27e9f8817ecc99c24f042c Gerrit-Change-Number: 38702 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ g

[gem5-dev] Change in gem5/gem5[develop]: sim: Move management responsibility from probe listener

2020-12-24 Thread Daniel Carvalho (Gerrit) via gem5-dev
end() == std::find_if(listeners.begin(), listeners.end(), +[l](const std::shared_ptr> ) -> +bool { return listener.get() == l; })) { + listeners.emplace_back(static_cast*>(l)); } } @@ -335,8 +327,9 @@

[gem5-dev] Change in gem5/gem5[develop]: sim,arch-arm: Allow enabling and disabling probe listeners

2020-12-24 Thread Daniel Carvalho (Gerrit) via gem5-dev
nsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ia8118e6cd28a9bb9683edd4f71aa665e096e08a9 Gerrit-Change-Number: 38699 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageTy

[gem5-dev] Change in gem5/gem5[develop]: RFC,sim: Remove ProbeListenerObject

2020-12-24 Thread Daniel Carvalho (Gerrit) via gem5-dev
her - * SimObject. - * - * It instantiates manager from a call to Parent.any. - */ -class ProbeListenerObject : public SimObject -{ - protected: -ProbeManager *manager; - - public: -ProbeListenerObject(const ProbeListenerObjectParams ); -virtual ~ProbeListenerObject() = default; -ProbeMa

[gem5-dev] Change in gem5/gem5[develop]: mem: Rename BaseMemProbe's manager to objects

2020-12-24 Thread Daniel Carvalho (Gerrit) via gem5-dev
hange-Id: Id006c92a4fc30f5c28f6d402ee59f95e180c5598 Gerrit-Change-Number: 38706 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: sim: Remove SimObject pointer from ProbeManager

2020-12-24 Thread Daniel Carvalho (Gerrit) via gem5-dev
filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: If5647cc657b1a8e68a2cfc3f7d3e944a1104c1d9 Gerrit-Change-Number: 38701 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: sim: Align coding style of probes

2020-12-24 Thread Daniel Carvalho (Gerrit) via gem5-dev
); ++l) { (*l)->notify(arg); -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/38697 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ibd905d1941fc203ca8308f7a3930d58515b19a97 Gerrit-Change-Number: 38697 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Carvalho Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

<    1   2   3   4   5   6   7   8   9   10   >