[gem5-dev] [XS] Change in gem5/gem5[develop]: stdlib: small fix in spec-2006 and spec-2007

2023-04-08 Thread humza jahangir ikram (Gerrit) via gem5-dev 
humza jahangir ikram has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/69537?usp=email )


Change subject: stdlib: small fix in spec-2006 and spec-2007
..

stdlib: small fix in spec-2006 and spec-2007

I modified the spec-2017 benchmark file to include a
processor.switch() statement (which had been removed
in an earlier commit). I also replaced the use of
get_roi_ticks() with get_tick_stopwatch() as this
particular workload is not annotated with "workbegin"
and "workend" annotations.

Lastly, I fixed a minor bug in the spec-2006 file
which printed the total simulated ticks as zero due
to incorrect indexing of get_tick_stopwatch().

Change-Id: If0b6f88d6701a11f32e2e69994582524e0d7097b
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69537
Tested-by: kokoro 
Maintainer: Jason Lowe-Power 
Reviewed-by: Ayaz Akram 
Reviewed-by: Jason Lowe-Power 
---
M configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
M configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
2 files changed, 7 insertions(+), 2 deletions(-)

Approvals:
  kokoro: Regressions pass
  Jason Lowe-Power: Looks good to me, but someone else must approve; Looks  
good to me, approved

  Ayaz Akram: Looks good to me, approved




diff --git a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py  
b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py

index e7a9e82..60d93eb 100644
--- a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
@@ -306,7 +306,7 @@
 print("Performance statistics:")

 roi_begin_ticks = simulator.get_tick_stopwatch()[0][1]
-roi_end_ticks = simulator.get_tick_stopwatch()[0][1]
+roi_end_ticks = simulator.get_tick_stopwatch()[1][1]

 print("roi simulated ticks: " + str(roi_end_ticks - roi_begin_ticks))

diff --git a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py  
b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py

index 531ce94..c491c9b 100644
--- a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
@@ -288,6 +288,7 @@
 print("Done bootling Linux")
 print("Resetting stats at the start of ROI!")
 m5.stats.reset()
+processor.switch()
 yield False  # E.g., continue the simulation.
 print("Dump stats at the end of the ROI!")
 m5.stats.dump()
@@ -319,7 +320,11 @@
 print()
 print("Performance statistics:")

-print("Simulated time in ROI: " + ((str(simulator.get_roi_ticks()[0]
+roi_begin_ticks = simulator.get_tick_stopwatch()[0][1]
+roi_end_ticks = simulator.get_tick_stopwatch()[1][1]
+
+print("roi simulated ticks: " + str(roi_end_ticks - roi_begin_ticks))
+
 print(
 "Ran a total of", simulator.get_current_tick() / 1e12, "simulated  
seconds"

 )

--
To view, visit  
https://gem5-review.googlesource.com/c/public/gem5/+/69537?usp=email
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: If0b6f88d6701a11f32e2e69994582524e0d7097b
Gerrit-Change-Number: 69537
Gerrit-PatchSet: 2
Gerrit-Owner: humza jahangir ikram 
Gerrit-Reviewer: Ayaz Akram 
Gerrit-Reviewer: Bobby Bruce 
Gerrit-Reviewer: Hoa Nguyen 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: humza jahangir ikram 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org

[gem5-dev] [XS] Change in gem5/gem5[develop]: stdlib: small fix in spec-2006 and spec-2007

2023-04-07 Thread humza jahangir ikram (Gerrit) via gem5-dev 
humza jahangir ikram has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/69537?usp=email )



Change subject: stdlib: small fix in spec-2006 and spec-2007
..

stdlib: small fix in spec-2006 and spec-2007

I modified the spec-2017 benchmark file to include a
processor.switch() statement (which had been removed
in an earlier commit). I also replaced the use of
get_roi_ticks() with get_tick_stopwatch() as this
particular workload is not annotated with "workbegin"
and "workend" annotations.

Lastly, I fixed a minor bug in the spec-2006 file
which printed the total simulated ticks as zero due
to incorrect indexing of get_tick_stopwatch().

Change-Id: If0b6f88d6701a11f32e2e69994582524e0d7097b
---
M configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
M configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
2 files changed, 7 insertions(+), 2 deletions(-)



diff --git a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py  
b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py

index e7a9e82..60d93eb 100644
--- a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
@@ -306,7 +306,7 @@
 print("Performance statistics:")

 roi_begin_ticks = simulator.get_tick_stopwatch()[0][1]
-roi_end_ticks = simulator.get_tick_stopwatch()[0][1]
+roi_end_ticks = simulator.get_tick_stopwatch()[1][1]

 print("roi simulated ticks: " + str(roi_end_ticks - roi_begin_ticks))

diff --git a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py  
b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py

index 531ce94..c491c9b 100644
--- a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
@@ -288,6 +288,7 @@
 print("Done bootling Linux")
 print("Resetting stats at the start of ROI!")
 m5.stats.reset()
+processor.switch()
 yield False  # E.g., continue the simulation.
 print("Dump stats at the end of the ROI!")
 m5.stats.dump()
@@ -319,7 +320,11 @@
 print()
 print("Performance statistics:")

-print("Simulated time in ROI: " + ((str(simulator.get_roi_ticks()[0]
+roi_begin_ticks = simulator.get_tick_stopwatch()[0][1]
+roi_end_ticks = simulator.get_tick_stopwatch()[1][1]
+
+print("roi simulated ticks: " + str(roi_end_ticks - roi_begin_ticks))
+
 print(
 "Ran a total of", simulator.get_current_tick() / 1e12, "simulated  
seconds"

 )

--
To view, visit  
https://gem5-review.googlesource.com/c/public/gem5/+/69537?usp=email
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: If0b6f88d6701a11f32e2e69994582524e0d7097b
Gerrit-Change-Number: 69537
Gerrit-PatchSet: 1
Gerrit-Owner: humza jahangir ikram 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org

[gem5-dev] [XS] Change in gem5/gem5[develop]: stdlib: Small fix in stdlib spec2006 script

2023-04-04 Thread humza jahangir ikram (Gerrit) via gem5-dev 
humza jahangir ikram has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/69357?usp=email )


Change subject: stdlib: Small fix in stdlib spec2006 script
..

stdlib: Small fix in stdlib spec2006 script

The call to processor switch from KVM to TIMING was
removed in an earlier commit. This change fixes that.
Also, get_roi_ticks() doesn't work because spec2006
does not have work_begin and work_exit annotations.
This change uses get_tick_stopwatch() to calculate
the roi ticks.

Change-Id: I55efe28ebd686cb4e6c88a528533127fb73c88ed
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69357
Reviewed-by: Bobby Bruce 
Maintainer: Bobby Bruce 
Tested-by: kokoro 
---
M configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Bobby Bruce: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass




diff --git a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py  
b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py

index a681eca..e7a9e82 100644
--- a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
@@ -272,6 +272,7 @@
 print("Done bootling Linux")
 print("Resetting stats at the start of ROI!")
 m5.stats.reset()
+processor.switch()
 yield False  # E.g., continue the simulation.
 print("Dump stats at the end of the ROI!")
 m5.stats.dump()
@@ -304,7 +305,11 @@

 print("Performance statistics:")

-print("Simulated time: " + ((str(simulator.get_roi_ticks()[0]
+roi_begin_ticks = simulator.get_tick_stopwatch()[0][1]
+roi_end_ticks = simulator.get_tick_stopwatch()[0][1]
+
+print("roi simulated ticks: " + str(roi_end_ticks - roi_begin_ticks))
+
 print(
 "Ran a total of", simulator.get_current_tick() / 1e12, "simulated  
seconds"

 )

--
To view, visit  
https://gem5-review.googlesource.com/c/public/gem5/+/69357?usp=email
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I55efe28ebd686cb4e6c88a528533127fb73c88ed
Gerrit-Change-Number: 69357
Gerrit-PatchSet: 3
Gerrit-Owner: humza jahangir ikram 
Gerrit-Reviewer: Bobby Bruce 
Gerrit-Reviewer: humza jahangir ikram 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org

[gem5-dev] [XS] Change in gem5/gem5[develop]: stdlib: Small fix in stdlib spec2006 script The call to processor swi...

2023-03-29 Thread humza jahangir ikram (Gerrit) via gem5-dev 
humza jahangir ikram has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/69357?usp=email )



Change subject: stdlib: Small fix in stdlib spec2006 script The call to  
processor switch from KVM to TIMING was removed in an earlier commit. This  
change fixes that. Also, get_roi_ticks() doesn't work because spec2006 does  
not have work_begin and work_exit annotations. This change uses  
get_tick_stopwatch() to calculate the roi ticks.

..

stdlib: Small fix in stdlib spec2006 script
The call to processor switch from KVM to TIMING was
removed in an earlier commit. This change fixes that.
Also, get_roi_ticks() doesn't work because spec2006
does not have work_begin and work_exit annotations.
This change uses get_tick_stopwatch() to calculate
the roi ticks.

Change-Id: I55efe28ebd686cb4e6c88a528533127fb73c88ed
---
M configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
1 file changed, 6 insertions(+), 1 deletion(-)



diff --git a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py  
b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py

index a681eca..e7a9e82 100644
--- a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
@@ -272,6 +272,7 @@
 print("Done bootling Linux")
 print("Resetting stats at the start of ROI!")
 m5.stats.reset()
+processor.switch()
 yield False  # E.g., continue the simulation.
 print("Dump stats at the end of the ROI!")
 m5.stats.dump()
@@ -304,7 +305,11 @@

 print("Performance statistics:")

-print("Simulated time: " + ((str(simulator.get_roi_ticks()[0]
+roi_begin_ticks = simulator.get_tick_stopwatch()[0][1]
+roi_end_ticks = simulator.get_tick_stopwatch()[0][1]
+
+print("roi simulated ticks: " + str(roi_end_ticks - roi_begin_ticks))
+
 print(
 "Ran a total of", simulator.get_current_tick() / 1e12, "simulated  
seconds"

 )

--
To view, visit  
https://gem5-review.googlesource.com/c/public/gem5/+/69357?usp=email
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I55efe28ebd686cb4e6c88a528533127fb73c88ed
Gerrit-Change-Number: 69357
Gerrit-PatchSet: 1
Gerrit-Owner: humza jahangir ikram 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org