[gem5-dev] Change in gem5/gem5[develop]: dev-arm: Don't use args and kwargs on attachIO

2020-03-26 Thread Giacomo Travaglini (Gerrit) 
Giacomo Travaglini has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/27086 )


Change subject: dev-arm: Don't use args and kwargs on attachIO
..

dev-arm: Don't use args and kwargs on attachIO

This is matching the attachOnChipIO style, and fixing the error of the
dma_ports kwarg being forwarded to the _attach_mem

Change-Id: Ib3ecf2fc18c488d938bbbf63eab3d7693cdb7d06
Signed-off-by: Giacomo Travaglini 
Reviewed-by: Nikos Nikoleris 
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/27086
Tested-by: Gem5 Cloud Project GCB service account  
<345032938...@cloudbuild.gserviceaccount.com>

Reviewed-by: Ciro Santilli 
---
M src/dev/arm/RealView.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Ciro Santilli: Looks good to me, approved
  Giacomo Travaglini: Looks good to me, approved
  Gem5 Cloud Project GCB service account: Regressions pass



diff --git a/src/dev/arm/RealView.py b/src/dev/arm/RealView.py
index f9b9cb2..43d2b15 100644
--- a/src/dev/arm/RealView.py
+++ b/src/dev/arm/RealView.py
@@ -625,9 +625,9 @@
 if bridge:
 bridge.ranges = self._off_chip_ranges

-def attachIO(self, *args, **kwargs):
-self._attach_mem(self._off_chip_memory(), *args, **kwargs)
-self._attach_io(self._off_chip_devices(), *args, **kwargs)
+def attachIO(self, bus, dma_ports=None, mem_ports=None):
+self._attach_mem(self._off_chip_memory(), bus, mem_ports)
+self._attach_io(self._off_chip_devices(), bus, dma_ports)

 def setupBootLoader(self, cur_sys, boot_loader, atags_addr,  
load_offset):

 cur_sys.workload.boot_loader = boot_loader

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27086
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib3ecf2fc18c488d938bbbf63eab3d7693cdb7d06
Gerrit-Change-Number: 27086
Gerrit-PatchSet: 2
Gerrit-Owner: Giacomo Travaglini 
Gerrit-Reviewer: Ciro Santilli 
Gerrit-Reviewer: Gem5 Cloud Project GCB service account  
<345032938...@cloudbuild.gserviceaccount.com>

Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Nikos Nikoleris 
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[develop]: dev-arm: Don't use args and kwargs on attachIO

2020-03-25 Thread Giacomo Travaglini (Gerrit) 

Hello Nikos Nikoleris,

I'd like you to do a code review. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/27086

to review the following change.


Change subject: dev-arm: Don't use args and kwargs on attachIO
..

dev-arm: Don't use args and kwargs on attachIO

This is matching the attachOnChipIO style, and fixing the error of the
dma_ports kwarg being forwarded to the _attach_mem

Change-Id: Ib3ecf2fc18c488d938bbbf63eab3d7693cdb7d06
Signed-off-by: Giacomo Travaglini 
Reviewed-by: Nikos Nikoleris 
---
M src/dev/arm/RealView.py
1 file changed, 3 insertions(+), 3 deletions(-)



diff --git a/src/dev/arm/RealView.py b/src/dev/arm/RealView.py
index f9b9cb2..43d2b15 100644
--- a/src/dev/arm/RealView.py
+++ b/src/dev/arm/RealView.py
@@ -625,9 +625,9 @@
 if bridge:
 bridge.ranges = self._off_chip_ranges

-def attachIO(self, *args, **kwargs):
-self._attach_mem(self._off_chip_memory(), *args, **kwargs)
-self._attach_io(self._off_chip_devices(), *args, **kwargs)
+def attachIO(self, bus, dma_ports=None, mem_ports=None):
+self._attach_mem(self._off_chip_memory(), bus, mem_ports)
+self._attach_io(self._off_chip_devices(), bus, dma_ports)

 def setupBootLoader(self, cur_sys, boot_loader, atags_addr,  
load_offset):

 cur_sys.workload.boot_loader = boot_loader

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27086
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib3ecf2fc18c488d938bbbf63eab3d7693cdb7d06
Gerrit-Change-Number: 27086
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini 
Gerrit-Reviewer: Nikos Nikoleris 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev