[gem5-dev] Change in gem5/gem5[develop]: mem: Relax packet limit in packet queue

2020-09-02 Thread Giacomo Travaglini (Gerrit) via gem5-dev
Giacomo Travaglini has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/30317 )


Change subject: mem: Relax packet limit in packet queue
..

mem: Relax packet limit in packet queue

JIRA: https://gem5.atlassian.net/browse/GEM5-587

Change-Id: I4ac24bf18a0aff08a5b33c48179b882b27ef910c
Signed-off-by: Giacomo Travaglini 
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/30317
Reviewed-by: Jason Lowe-Power 
Maintainer: Jason Lowe-Power 
Tested-by: kokoro 
---
M src/mem/packet_queue.cc
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/mem/packet_queue.cc b/src/mem/packet_queue.cc
index dab133c..fe08d49 100644
--- a/src/mem/packet_queue.cc
+++ b/src/mem/packet_queue.cc
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012,2015,2018 ARM Limited
+ * Copyright (c) 2012,2015,2018-2020 ARM Limited
  * All rights reserved.
  *
  * The license below extends only to copyright in the software and shall
@@ -115,8 +115,8 @@

 // add a very basic sanity check on the port to ensure the
 // invisible buffer is not growing beyond reasonable limits
-if (!_disableSanityCheck && transmitList.size() > 100) {
-panic("Packet queue %s has grown beyond 100 packets\n",
+if (!_disableSanityCheck && transmitList.size() > 128) {
+panic("Packet queue %s has grown beyond 128 packets\n",
   name());
 }


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/30317
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4ac24bf18a0aff08a5b33c48179b882b27ef910c
Gerrit-Change-Number: 30317
Gerrit-PatchSet: 6
Gerrit-Owner: Giacomo Travaglini 
Gerrit-Reviewer: Bradford Beckmann 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Matthew Poremba 
Gerrit-Reviewer: Timothy Hayes 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: mem: Relax packet limit in packet queue

2020-06-15 Thread Giacomo Travaglini (Gerrit) via gem5-dev

Hello Timothy Hayes,

I'd like you to do a code review. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/30317

to review the following change.


Change subject: mem: Relax packet limit in packet queue
..

mem: Relax packet limit in packet queue

JIRA: https://gem5.atlassian.net/browse/GEM5-587

Change-Id: I4ac24bf18a0aff08a5b33c48179b882b27ef910c
Signed-off-by: Giacomo Travaglini 
---
M src/mem/packet_queue.cc
1 file changed, 3 insertions(+), 3 deletions(-)



diff --git a/src/mem/packet_queue.cc b/src/mem/packet_queue.cc
index acf29dd..f49d226 100644
--- a/src/mem/packet_queue.cc
+++ b/src/mem/packet_queue.cc
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012,2015,2018 ARM Limited
+ * Copyright (c) 2012,2015,2018-2020 ARM Limited
  * All rights reserved.
  *
  * The license below extends only to copyright in the software and shall
@@ -115,8 +115,8 @@

 // add a very basic sanity check on the port to ensure the
 // invisible buffer is not growing beyond reasonable limits
-if (!_disableSanityCheck && transmitList.size() > 100) {
-panic("Packet queue %s has grown beyond 100 packets\n",
+if (!_disableSanityCheck && transmitList.size() > 1000) {
+panic("Packet queue %s has grown beyond 1000 packets\n",
   name());
 }


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/30317
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4ac24bf18a0aff08a5b33c48179b882b27ef910c
Gerrit-Change-Number: 30317
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini 
Gerrit-Reviewer: Timothy Hayes 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s