Re: [gem5-dev] Review Request 3674: syscall_emul: [patch 8/22] refactor process class

2016-10-20 Thread Brandon Potter
> On Oct. 19, 2016, 6:23 p.m., Steve Reinhardt wrote: > > src/sim/aux_vector.cc, line 42 > > > > > > why do we need to include process.hh here? "process.hh" is included because it defines the namespace that it needs for

Re: [gem5-dev] Review Request 3674: syscall_emul: [patch 8/22] refactor process class

2016-10-19 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3674/#review8933 --- src/sim/aux_vector.hh (line 2)

Re: [gem5-dev] Review Request 3674: syscall_emul: [patch 8/22] refactor process class

2016-10-17 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3674/#review8879 --- Ship it! Ship It! - Michael LeBeane On Oct. 17, 2016, 3:23 p.m.,

[gem5-dev] Review Request 3674: syscall_emul: [patch 8/22] refactor process class

2016-10-17 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3674/ --- Review request for Default. Repository: gem5 Description --- Changeset