Re: [gem5-dev] Review Request 3602: mem: Add DRAM low-power functionality

2016-10-10 Thread Matthew Poremba
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3602/#review8804 --- Ship it! Ship It! - Matthew Poremba On Aug. 11, 2016, 9:08 a.m.,

Re: [gem5-dev] Review Request 3602: mem: Add DRAM low-power functionality

2016-10-10 Thread Matthew Poremba
> On Oct. 6, 2016, 10:27 p.m., Matthew Poremba wrote: > > I suggest there be a parameter to enable or disable the low-power > > functionality. Ideally, when disabled the model would behave exactly as it > > does prior to the patch. I would be interested to be able to evaluate any > >

Re: [gem5-dev] Review Request 3602: mem: Add DRAM low-power functionality

2016-10-10 Thread Wendy Elsasser
> On Oct. 6, 2016, 10:27 p.m., Matthew Poremba wrote: > > I suggest there be a parameter to enable or disable the low-power > > functionality. Ideally, when disabled the model would behave exactly as it > > does prior to the patch. I would be interested to be able to evaluate any > >

Re: [gem5-dev] Review Request 3602: mem: Add DRAM low-power functionality

2016-10-06 Thread Matthew Poremba
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3602/#review8776 --- I suggest there be a parameter to enable or disable the low-power

Re: [gem5-dev] Review Request 3602: mem: Add DRAM low-power functionality

2016-09-29 Thread Curtis Dunham
> On Sept. 28, 2016, 9:30 p.m., Matthias Jung wrote: > > Again my comment, maybe refer to the mentioned paper, since other DRAM > > controllers usually use timeouts for the transition to the low power modes. > > But the benefits of this "staggered" approach are explained in the > > mentioned

Re: [gem5-dev] Review Request 3602: mem: Add DRAM low-power functionality

2016-09-28 Thread Matthias Jung
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3602/#review8749 --- Again my comment, maybe refer to the mentioned paper, since other DRAM

Re: [gem5-dev] Review Request 3602: mem: Add DRAM low-power functionality

2016-09-28 Thread Éder F . Zulian
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3602/#review8748 --- Ship it! Ship It! - Éder F. Zulian On Aug. 11, 2016, 9:08 a.m.,

Re: [gem5-dev] Review Request 3602: mem: Add DRAM low-power functionality

2016-09-28 Thread Éder F . Zulian
> On Sept. 19, 2016, 11:03 p.m., Éder F. Zulian wrote: > > The data members readEntries, writeEntries and outstandingEvents seem to be > > redundant information that could be extracted from queues (readQueue, > > writeQueue and respQueue, the last one requiring a little bit more effort > > to

Re: [gem5-dev] Review Request 3602: mem: Add DRAM low-power functionality

2016-09-28 Thread Wendy Elsasser
> On Sept. 19, 2016, 11:03 p.m., Éder F. Zulian wrote: > > The data members readEntries, writeEntries and outstandingEvents seem to be > > redundant information that could be extracted from queues (readQueue, > > writeQueue and respQueue, the last one requiring a little bit more effort > > to

Re: [gem5-dev] Review Request 3602: mem: Add DRAM low-power functionality

2016-09-19 Thread Éder F . Zulian
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3602/#review8732 --- The data members readEntries, writeEntries and outstandingEvents seem to

Re: [gem5-dev] Review Request 3602: mem: Add DRAM low-power functionality

2016-08-12 Thread Matthias Jung
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3602/#review8611 --- I will do a detailed review and testing in the next days. What this