[gem5-dev] Change in gem5/gem5[develop]: arm: Add missing overrides to the ARM interrupt object.

2020-06-15 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/30294 )


Change subject: arm: Add missing overrides to the ARM interrupt object.
..

arm: Add missing overrides to the ARM interrupt object.

Change-Id: Idddc5267d5eb287a0895a1a2e1631ca9a2e789f3
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/30294
Reviewed-by: Jason Lowe-Power 
Reviewed-by: Giacomo Travaglini 
Maintainer: Giacomo Travaglini 
Tested-by: kokoro 
---
M src/arch/arm/interrupts.hh
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved
  Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/arch/arm/interrupts.hh b/src/arch/arm/interrupts.hh
index 814fd71..8e78f96 100644
--- a/src/arch/arm/interrupts.hh
+++ b/src/arch/arm/interrupts.hh
@@ -77,7 +77,7 @@


 void
-post(int int_num, int index)
+post(int int_num, int index) override
 {
 DPRINTF(Interrupt, "Interrupt %d:%d posted\n", int_num, index);

@@ -92,7 +92,7 @@
 }

 void
-clear(int int_num, int index)
+clear(int int_num, int index) override
 {
 DPRINTF(Interrupt, "Interrupt %d:%d cleared\n", int_num, index);

@@ -107,7 +107,7 @@
 }

 void
-clearAll()
+clearAll() override
 {
 DPRINTF(Interrupt, "Interrupts all cleared\n");
 intStatus = 0;
@@ -123,7 +123,7 @@
 bool takeInt(InterruptTypes int_type) const;

 bool
-checkInterrupts() const
+checkInterrupts() const override
 {
 HCR  hcr  = tc->readMiscReg(MISCREG_HCR);


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/30294
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Idddc5267d5eb287a0895a1a2e1631ca9a2e789f3
Gerrit-Change-Number: 30294
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s


[gem5-dev] Change in gem5/gem5[develop]: arm: Add missing overrides to the ARM interrupt object.

2020-06-12 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/30294 )



Change subject: arm: Add missing overrides to the ARM interrupt object.
..

arm: Add missing overrides to the ARM interrupt object.

Change-Id: Idddc5267d5eb287a0895a1a2e1631ca9a2e789f3
---
M src/arch/arm/interrupts.hh
1 file changed, 4 insertions(+), 4 deletions(-)



diff --git a/src/arch/arm/interrupts.hh b/src/arch/arm/interrupts.hh
index 814fd71..8e78f96 100644
--- a/src/arch/arm/interrupts.hh
+++ b/src/arch/arm/interrupts.hh
@@ -77,7 +77,7 @@


 void
-post(int int_num, int index)
+post(int int_num, int index) override
 {
 DPRINTF(Interrupt, "Interrupt %d:%d posted\n", int_num, index);

@@ -92,7 +92,7 @@
 }

 void
-clear(int int_num, int index)
+clear(int int_num, int index) override
 {
 DPRINTF(Interrupt, "Interrupt %d:%d cleared\n", int_num, index);

@@ -107,7 +107,7 @@
 }

 void
-clearAll()
+clearAll() override
 {
 DPRINTF(Interrupt, "Interrupts all cleared\n");
 intStatus = 0;
@@ -123,7 +123,7 @@
 bool takeInt(InterruptTypes int_type) const;

 bool
-checkInterrupts() const
+checkInterrupts() const override
 {
 HCR  hcr  = tc->readMiscReg(MISCREG_HCR);


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/30294
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Idddc5267d5eb287a0895a1a2e1631ca9a2e789f3
Gerrit-Change-Number: 30294
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s