[gem5-dev] Change in gem5/gem5[develop]: base: Make the random number generator public

2021-07-10 Thread Bobby R. Bruce (Gerrit) via gem5-dev
Bobby R. Bruce has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/47859 )


Change subject: base: Make the random number generator public
..

base: Make the random number generator public

There are cases where we need a random number generator engine. The
Random class has such an engine but its interface currently only
allows for generating random numbers. To make sure we can reuse the
same random number generator in as many places as possible this patch
makes the engine in the Random class public.

Change-Id: I80153dd39f5b0d12537e4c0cf54773e7725b2a94
Signed-off-by: Nikos Nikoleris 
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/47859
Reviewed-by: Jason Lowe-Power 
Maintainer: Jason Lowe-Power 
Tested-by: kokoro 
---
M src/base/random.hh
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/base/random.hh b/src/base/random.hh
index 9a3d696..55d7245 100644
--- a/src/base/random.hh
+++ b/src/base/random.hh
@@ -61,14 +61,15 @@
 class Random : public Serializable
 {

-  private:
-
-std::mt19937_64 gen;
-
   public:

 /**
  * @ingroup api_base_utils
+ */
+std::mt19937_64 gen;
+
+/**
+ * @ingroup api_base_utils
  * @{
  */
 Random();

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/47859
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I80153dd39f5b0d12537e4c0cf54773e7725b2a94
Gerrit-Change-Number: 47859
Gerrit-PatchSet: 2
Gerrit-Owner: Nikos Nikoleris 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Daniel Carvalho 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base: Make the random number generator public

2021-07-09 Thread Nikos Nikoleris (Gerrit) via gem5-dev
Nikos Nikoleris has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/47859 )



Change subject: base: Make the random number generator public
..

base: Make the random number generator public

There are cases where we need a random number generator engine. The
Random class has such an engine but its interface currently only
allows for generating random numbers. To make sure we can reuse the
same random number generator in as many places as possible this patch
makes the engine in the Random class public.

Change-Id: I80153dd39f5b0d12537e4c0cf54773e7725b2a94
Signed-off-by: Nikos Nikoleris 
---
M src/base/random.hh
1 file changed, 5 insertions(+), 4 deletions(-)



diff --git a/src/base/random.hh b/src/base/random.hh
index 9a3d696..55d7245 100644
--- a/src/base/random.hh
+++ b/src/base/random.hh
@@ -61,14 +61,15 @@
 class Random : public Serializable
 {

-  private:
-
-std::mt19937_64 gen;
-
   public:

 /**
  * @ingroup api_base_utils
+ */
+std::mt19937_64 gen;
+
+/**
+ * @ingroup api_base_utils
  * @{
  */
 Random();

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/47859
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I80153dd39f5b0d12537e4c0cf54773e7725b2a94
Gerrit-Change-Number: 47859
Gerrit-PatchSet: 1
Gerrit-Owner: Nikos Nikoleris 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s