[gem5-dev] Change in gem5/gem5[develop]: cpu: Rename GpuThread in gpu_ruby_test tester
Matthew Poremba has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/39935 ) Change subject: cpu: Rename GpuThread in gpu_ruby_test tester .. cpu: Rename GpuThread in gpu_ruby_test tester The GpuThread class will be used as an abstract class for any thread type (CPU, GPU, DMA) therefore changing to a more appropriate name. Change-Id: If241edb53ea405c95b0315c609176c6470b29931 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/39935 Reviewed-by: Matt Sinclair Reviewed-by: Jason Lowe-Power Maintainer: Matt Sinclair Tested-by: kokoro --- M src/cpu/testers/gpu_ruby_test/CpuThread.py M src/cpu/testers/gpu_ruby_test/GpuWavefront.py M src/cpu/testers/gpu_ruby_test/README M src/cpu/testers/gpu_ruby_test/SConscript R src/cpu/testers/gpu_ruby_test/TesterThread.py M src/cpu/testers/gpu_ruby_test/address_manager.hh M src/cpu/testers/gpu_ruby_test/cpu_thread.cc M src/cpu/testers/gpu_ruby_test/cpu_thread.hh M src/cpu/testers/gpu_ruby_test/episode.cc M src/cpu/testers/gpu_ruby_test/episode.hh M src/cpu/testers/gpu_ruby_test/gpu_wavefront.cc M src/cpu/testers/gpu_ruby_test/gpu_wavefront.hh M src/cpu/testers/gpu_ruby_test/protocol_tester.cc M src/cpu/testers/gpu_ruby_test/protocol_tester.hh R src/cpu/testers/gpu_ruby_test/tester_thread.cc R src/cpu/testers/gpu_ruby_test/tester_thread.hh 16 files changed, 95 insertions(+), 95 deletions(-) Approvals: Jason Lowe-Power: Looks good to me, approved Matt Sinclair: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass diff --git a/src/cpu/testers/gpu_ruby_test/CpuThread.py b/src/cpu/testers/gpu_ruby_test/CpuThread.py index 7124a32..8cb3269 100644 --- a/src/cpu/testers/gpu_ruby_test/CpuThread.py +++ b/src/cpu/testers/gpu_ruby_test/CpuThread.py @@ -1,4 +1,4 @@ -# Copyright (c) 2017-2020 Advanced Micro Devices, Inc. +# Copyright (c) 2017-2021 Advanced Micro Devices, Inc. # All rights reserved. # # For use for simulation and test purposes only @@ -32,8 +32,8 @@ from m5.params import * from m5.proxy import * -from m5.objects.GpuThread import GpuThread +from m5.objects.TesterThread import TesterThread -class CpuThread(GpuThread): +class CpuThread(TesterThread): type = 'CpuThread' cxx_header = "cpu/testers/gpu_ruby_test/cpu_thread.hh" diff --git a/src/cpu/testers/gpu_ruby_test/GpuWavefront.py b/src/cpu/testers/gpu_ruby_test/GpuWavefront.py index a54870f..d8d7dae 100644 --- a/src/cpu/testers/gpu_ruby_test/GpuWavefront.py +++ b/src/cpu/testers/gpu_ruby_test/GpuWavefront.py @@ -1,4 +1,4 @@ -# Copyright (c) 2017-2020 Advanced Micro Devices, Inc. +# Copyright (c) 2017-2021 Advanced Micro Devices, Inc. # All rights reserved. # # For use for simulation and test purposes only @@ -32,9 +32,9 @@ from m5.params import * from m5.proxy import * -from m5.objects.GpuThread import GpuThread +from m5.objects.TesterThread import TesterThread -class GpuWavefront(GpuThread): +class GpuWavefront(TesterThread): type = 'GpuWavefront' cxx_header = "cpu/testers/gpu_ruby_test/gpu_wavefront.hh" cu_id = Param.Int("Compute Unit ID") diff --git a/src/cpu/testers/gpu_ruby_test/README b/src/cpu/testers/gpu_ruby_test/README index 5627f43..390b503 100644 --- a/src/cpu/testers/gpu_ruby_test/README +++ b/src/cpu/testers/gpu_ruby_test/README @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017-2020 Advanced Micro Devices, Inc. + * Copyright (c) 2017-2021 Advanced Micro Devices, Inc. * All rights reserved. * * For use for simulation and test purposes only @@ -113,11 +113,11 @@ location, generates locations for all episodes, maintains per-location last writer and validates values returned from load actions. -GpuThread.hh/cc -- This is abstract class for CPU threads and GPU +TesterThread.hh/cc -- This is abstract class for CPU threads and GPU wavefronts. It generates and executes a series of episodes. CpuThread.hh/cc -- Thread class for CPU threads. Not fully implemented yet -GpuWavefront.hh/cc -- GpuThread class for GPU wavefronts. +GpuWavefront.hh/cc -- Thread class for GPU wavefronts. Episode.hh/cc-- Class to encapsulate an episode, notably including episode load/store structure and ordering. diff --git a/src/cpu/testers/gpu_ruby_test/SConscript b/src/cpu/testers/gpu_ruby_test/SConscript index d801130..28c8006 100644 --- a/src/cpu/testers/gpu_ruby_test/SConscript +++ b/src/cpu/testers/gpu_ruby_test/SConscript @@ -1,5 +1,5 @@ # -# Copyright (c) 2017-2020 Advanced Micro Devices, Inc. +# Copyright (c) 2017-2021 Advanced Micro Devices, Inc. # All rights reserved. # # For use for simulation and test purposes only @@ -40,15 +40,15 @@ Return() SimObject('ProtocolTester.py') -SimObject('GpuThread.py') SimObject('CpuThread.py')
[gem5-dev] Change in gem5/gem5[develop]: cpu: Rename GpuThread in gpu_ruby_test tester
Matthew Poremba has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39935 ) Change subject: cpu: Rename GpuThread in gpu_ruby_test tester .. cpu: Rename GpuThread in gpu_ruby_test tester The GpuThread class will be used as an abstract class for any thread type (CPU, GPU, DMA) therefore changing to a more appropriate name. Change-Id: If241edb53ea405c95b0315c609176c6470b29931 --- M src/cpu/testers/gpu_ruby_test/CpuThread.py M src/cpu/testers/gpu_ruby_test/GpuWavefront.py M src/cpu/testers/gpu_ruby_test/README M src/cpu/testers/gpu_ruby_test/SConscript R src/cpu/testers/gpu_ruby_test/TesterThread.py M src/cpu/testers/gpu_ruby_test/address_manager.hh M src/cpu/testers/gpu_ruby_test/cpu_thread.cc M src/cpu/testers/gpu_ruby_test/cpu_thread.hh M src/cpu/testers/gpu_ruby_test/episode.cc M src/cpu/testers/gpu_ruby_test/episode.hh M src/cpu/testers/gpu_ruby_test/gpu_wavefront.cc M src/cpu/testers/gpu_ruby_test/gpu_wavefront.hh M src/cpu/testers/gpu_ruby_test/protocol_tester.cc M src/cpu/testers/gpu_ruby_test/protocol_tester.hh R src/cpu/testers/gpu_ruby_test/tester_thread.cc R src/cpu/testers/gpu_ruby_test/tester_thread.hh 16 files changed, 95 insertions(+), 95 deletions(-) diff --git a/src/cpu/testers/gpu_ruby_test/CpuThread.py b/src/cpu/testers/gpu_ruby_test/CpuThread.py index 7124a32..8cb3269 100644 --- a/src/cpu/testers/gpu_ruby_test/CpuThread.py +++ b/src/cpu/testers/gpu_ruby_test/CpuThread.py @@ -1,4 +1,4 @@ -# Copyright (c) 2017-2020 Advanced Micro Devices, Inc. +# Copyright (c) 2017-2021 Advanced Micro Devices, Inc. # All rights reserved. # # For use for simulation and test purposes only @@ -32,8 +32,8 @@ from m5.params import * from m5.proxy import * -from m5.objects.GpuThread import GpuThread +from m5.objects.TesterThread import TesterThread -class CpuThread(GpuThread): +class CpuThread(TesterThread): type = 'CpuThread' cxx_header = "cpu/testers/gpu_ruby_test/cpu_thread.hh" diff --git a/src/cpu/testers/gpu_ruby_test/GpuWavefront.py b/src/cpu/testers/gpu_ruby_test/GpuWavefront.py index a54870f..d8d7dae 100644 --- a/src/cpu/testers/gpu_ruby_test/GpuWavefront.py +++ b/src/cpu/testers/gpu_ruby_test/GpuWavefront.py @@ -1,4 +1,4 @@ -# Copyright (c) 2017-2020 Advanced Micro Devices, Inc. +# Copyright (c) 2017-2021 Advanced Micro Devices, Inc. # All rights reserved. # # For use for simulation and test purposes only @@ -32,9 +32,9 @@ from m5.params import * from m5.proxy import * -from m5.objects.GpuThread import GpuThread +from m5.objects.TesterThread import TesterThread -class GpuWavefront(GpuThread): +class GpuWavefront(TesterThread): type = 'GpuWavefront' cxx_header = "cpu/testers/gpu_ruby_test/gpu_wavefront.hh" cu_id = Param.Int("Compute Unit ID") diff --git a/src/cpu/testers/gpu_ruby_test/README b/src/cpu/testers/gpu_ruby_test/README index 5627f43..390b503 100644 --- a/src/cpu/testers/gpu_ruby_test/README +++ b/src/cpu/testers/gpu_ruby_test/README @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017-2020 Advanced Micro Devices, Inc. + * Copyright (c) 2017-2021 Advanced Micro Devices, Inc. * All rights reserved. * * For use for simulation and test purposes only @@ -113,11 +113,11 @@ location, generates locations for all episodes, maintains per-location last writer and validates values returned from load actions. -GpuThread.hh/cc -- This is abstract class for CPU threads and GPU +TesterThread.hh/cc -- This is abstract class for CPU threads and GPU wavefronts. It generates and executes a series of episodes. CpuThread.hh/cc -- Thread class for CPU threads. Not fully implemented yet -GpuWavefront.hh/cc -- GpuThread class for GPU wavefronts. +GpuWavefront.hh/cc -- Thread class for GPU wavefronts. Episode.hh/cc-- Class to encapsulate an episode, notably including episode load/store structure and ordering. diff --git a/src/cpu/testers/gpu_ruby_test/SConscript b/src/cpu/testers/gpu_ruby_test/SConscript index d801130..28c8006 100644 --- a/src/cpu/testers/gpu_ruby_test/SConscript +++ b/src/cpu/testers/gpu_ruby_test/SConscript @@ -1,5 +1,5 @@ # -# Copyright (c) 2017-2020 Advanced Micro Devices, Inc. +# Copyright (c) 2017-2021 Advanced Micro Devices, Inc. # All rights reserved. # # For use for simulation and test purposes only @@ -40,15 +40,15 @@ Return() SimObject('ProtocolTester.py') -SimObject('GpuThread.py') SimObject('CpuThread.py') SimObject('GpuWavefront.py') +SimObject('TesterThread.py') Source('address_manager.cc') Source('episode.cc') Source('protocol_tester.cc') -Source('gpu_thread.cc') Source('cpu_thread.cc') Source('gpu_wavefront.cc') +Source('tester_thread.cc') DebugFlag('ProtocolTest') diff --git a/src/cpu/testers/gpu_ruby_test/GpuThread.py