Daniel Carvalho has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/40836 )
Change subject: dev: Fix register bank unit test in .debug
..
dev: Fix register bank unit test in .debug
The lack of definition of this static variable was throwing
and undefined reference error when running
scons build/X86/unittests.opt.
For more info, check
https://stackoverflow.com/questions/
8016780/undefined-reference-to-static-constexpr-char
Change-Id: Id736dc42a82aea871da6a53c06d89fd399d3559a
Signed-off-by: Daniel R. Carvalho
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40836
Reviewed-by: Jason Lowe-Power
Reviewed-by: Gabe Black
Maintainer: Jason Lowe-Power
Tested-by: kokoro
---
M src/dev/reg_bank.test.cc
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, but someone else must approve; Looks
good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/dev/reg_bank.test.cc b/src/dev/reg_bank.test.cc
index 6e655e2..f72642d 100644
--- a/src/dev/reg_bank.test.cc
+++ b/src/dev/reg_bank.test.cc
@@ -82,6 +82,8 @@
buf.fill(0xff);
}
};
+// Needed by C++14 and lower
+constexpr size_t RegisterRazTest::RazSize;
TEST_F(RegisterRazTest, Name)
{
@@ -166,6 +168,8 @@
buf.fill(0x00);
}
};
+// Needed by C++14 and lower
+constexpr size_t RegisterRaoTest::RaoSize;
TEST_F(RegisterRaoTest, Name)
{
@@ -252,6 +256,8 @@
0x70, 0x80, 0x90, 0xa0, 0xb0, 0xc0}
{}
};
+// Needed by C++14 and lower
+constexpr size_t RegisterBufTest::RegSize;
TEST_F(RegisterBufTest, Name)
{
@@ -456,6 +462,8 @@
buf{0x1, 0x2, 0x3, 0x4, 0x5, 0x6}
{}
};
+// Needed by C++14 and lower
+constexpr size_t TypedRegisterTest::RegSize;
TEST_F(TypedRegisterTest, DefaultConstructor)
{
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40836
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id736dc42a82aea871da6a53c06d89fd399d3559a
Gerrit-Change-Number: 40836
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Carvalho
Gerrit-Reviewer: Daniel Carvalho
Gerrit-Reviewer: Gabe Black
Gerrit-Reviewer: Gabe Black
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-Reviewer: kokoro
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
