[gem5-dev] Change in gem5/gem5[develop]: dev-arm: Adjust idreg value in RealViewCtrl

2020-03-30 Thread Giacomo Travaglini (Gerrit)
Giacomo Travaglini has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/27184 )


Change subject: dev-arm: Adjust idreg value in RealViewCtrl
..

dev-arm: Adjust idreg value in RealViewCtrl

This is to match the FVP Foundation platform.
Priviledged software could query the SYS_ID register in the V2m
Motherboard controller to extract platform information:

https://
static.docs.arm.com/100961/1110/armv8_a_fp_ug_100961_1110_00_en.pdf

In particular:

* SYS_ID[31:28] (REV) = Revision Number
** Value = 0x3 -> FVP Foundation v9.6

* SYS_ID[27:16] (HBI) = Board Number
** Value = 0x010 -> FVP Foundation platform

* SYS_ID[15:12] (BLD) = Which variant of the GIC memory is implemented
in the model
** Value = 0x1 -> (!= legacy VE memory map)

* SYS_ID[11:8] (Arch) = Architecture
** Value = 0x1 -> Architectural model (FVP)

Change-Id: Ib9395eb872cb925c029077acfdd18e48478f779b
Signed-off-by: Giacomo Travaglini 
Reviewed-by: Ciro Santilli 
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/27184
Reviewed-by: Nikos Nikoleris 
Maintainer: Nikos Nikoleris 
Tested-by: Gem5 Cloud Project GCB service account  
<345032938...@cloudbuild.gserviceaccount.com>

Tested-by: kokoro 
---
M src/dev/arm/RealView.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nikos Nikoleris: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass
  Gem5 Cloud Project GCB service account: Regressions pass



diff --git a/src/dev/arm/RealView.py b/src/dev/arm/RealView.py
index cf57ee2..4cd6258 100644
--- a/src/dev/arm/RealView.py
+++ b/src/dev/arm/RealView.py
@@ -961,7 +961,7 @@

 # Platform control device (off-chip)
 realview_io = RealViewCtrl(proc_id0=0x1400, proc_id1=0x1400,
-   idreg=0x0225, pio_addr=0x1c01)
+   idreg=0x30101100, pio_addr=0x1c01)
 mcc = VExpressMCC()
 dcc = CoreTile2A15DCC()


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27184
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib9395eb872cb925c029077acfdd18e48478f779b
Gerrit-Change-Number: 27184
Gerrit-PatchSet: 4
Gerrit-Owner: Giacomo Travaglini 
Gerrit-Reviewer: Adrian Herrera 
Gerrit-Reviewer: Ciro Santilli 
Gerrit-Reviewer: Gem5 Cloud Project GCB service account  
<345032938...@cloudbuild.gserviceaccount.com>

Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Nikos Nikoleris 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[develop]: dev-arm: Adjust idreg value in RealViewCtrl

2020-03-27 Thread Giacomo Travaglini (Gerrit)

Hello Ciro Santilli, Adrian Herrera,

I'd like you to do a code review. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/27184

to review the following change.


Change subject: dev-arm: Adjust idreg value in RealViewCtrl
..

dev-arm: Adjust idreg value in RealViewCtrl

This is to match the FVP Foundation platform.
Priviledged softwtware could query the SYS_ID register in the V2m
Motherboard controller to extract platform information:

https://
static.docs.arm.com/100961/1110/armv8_a_fp_ug_100961_1110_00_en.pdf

In particular:

* SYS_ID[31:28] (REV) = Revision Number
** Value = 0x3 -> FVP Foundation v9.6

* SYS_ID[27:16] (HBI) = Board Number
** Value = 0x010 -> FVP Foundation platform

* SYS_ID[15:12] (BLD) = Which variant of the GIC memory is implemented
in the model
** Value = 0x1 -> (!= legacy VE memory map)

* SYS_ID[11:8] (Arch) = Architecture
** Value = 0x1 -> Architectural model (FVP)

Change-Id: Ib9395eb872cb925c029077acfdd18e48478f779b
Signed-off-by: Giacomo Travaglini 
Reviewed-by: Ciro Santilli 
---
M src/dev/arm/RealView.py
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/dev/arm/RealView.py b/src/dev/arm/RealView.py
index 43d2b15..f6a9c69 100644
--- a/src/dev/arm/RealView.py
+++ b/src/dev/arm/RealView.py
@@ -961,7 +961,7 @@

 # Platform control device (off-chip)
 realview_io = RealViewCtrl(proc_id0=0x1400, proc_id1=0x1400,
-   idreg=0x0225, pio_addr=0x1c01)
+   idreg=0x30101100, pio_addr=0x1c01)
 mcc = VExpressMCC()
 dcc = CoreTile2A15DCC()


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27184
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib9395eb872cb925c029077acfdd18e48478f779b
Gerrit-Change-Number: 27184
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini 
Gerrit-Reviewer: Adrian Herrera 
Gerrit-Reviewer: Ciro Santilli 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev