Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/30238 )
Change subject: ext: Remove dead code from fixture.py
......................................................................
ext: Remove dead code from fixture.py
This has been tested with vulture:
https://pypi.org/project/vulture
JIRA: https://gem5.atlassian.net/projects/GEM5/issues/GEM5-533
Change-Id: Ifa55a846ba22a84a0f684ffbf870506af7c1045c
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/30238
Maintainer: Bobby R. Bruce <bbr...@ucdavis.edu>
Tested-by: kokoro <noreply+kok...@google.com>
Reviewed-by: Hoa Nguyen <hoangu...@ucdavis.edu>
---
M ext/testlib/fixture.py
1 file changed, 0 insertions(+), 17 deletions(-)
Approvals:
Hoa Nguyen: Looks good to me, approved
Bobby R. Bruce: Looks good to me, approved
kokoro: Regressions pass
diff --git a/ext/testlib/fixture.py b/ext/testlib/fixture.py
index 20568b8..79b57c0 100644
--- a/ext/testlib/fixture.py
+++ b/ext/testlib/fixture.py
@@ -26,17 +26,10 @@
#
# Authors: Sean Wilson
-import copy
-import traceback
-
import testlib.helper as helper
-import testlib.log as log
class SkipException(Exception):
def __init__(self, fixture, testitem):
- self.fixture = fixture
- self.testitem = testitem
-
self.msg = 'Fixture "%s" raised SkipException for "%s".' % (
fixture.name, testitem.name
)
@@ -74,22 +67,12 @@
def skip(self, testitem):
raise SkipException(self.name, testitem.metadata)
- def init(self, *args, **kwargs):
- pass
-
def setup(self, testitem):
pass
def teardown(self, testitem):
pass
- def skip_cleanup(self):
- '''
- If this method is called, then we should make sure that nothing is
- done when the teardown() function is called.
- '''
- pass
-
def set_global(self):
self._is_global = True
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/30238
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ifa55a846ba22a84a0f684ffbf870506af7c1045c
Gerrit-Change-Number: 30238
Gerrit-PatchSet: 4
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Hoa Nguyen <hoangu...@ucdavis.edu>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
