[gem5-dev] Change in gem5/gem5[develop]: misc: Use a const char * in the m5op m5_add_symbol.

2020-04-27 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/27224 )


Change subject: misc: Use a const char * in the m5op m5_add_symbol.
..

misc: Use a const char * in the m5op m5_add_symbol.

The symbol name is not modified by the m5 op, so a const char * is more
accurate and gives the caller more flexibility as far as what they can
pass in.

Change-Id: Iee567bceef501643175dd5c65551a4c8554a6e3b
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/27224
Maintainer: Bobby R. Bruce 
Tested-by: kokoro 
Reviewed-by: Ciro Santilli 
---
M include/gem5/m5ops.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ciro Santilli: Looks good to me, approved
  Bobby R. Bruce: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/include/gem5/m5ops.h b/include/gem5/m5ops.h
index 440ea2d..1c08017 100644
--- a/include/gem5/m5ops.h
+++ b/include/gem5/m5ops.h
@@ -56,7 +56,7 @@
 void m5_debug_break(void);
 void m5_switch_cpu(void);
 void m5_dist_toggle_sync(void);
-void m5_add_symbol(uint64_t addr, char *symbol);
+void m5_add_symbol(uint64_t addr, const char *symbol);
 void m5_load_symbol();
 void m5_panic(void);
 void m5_work_begin(uint64_t workid, uint64_t threadid);

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27224
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iee567bceef501643175dd5c65551a4c8554a6e3b
Gerrit-Change-Number: 27224
Gerrit-PatchSet: 10
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Ciro Santilli 
Gerrit-Reviewer: Earl Ou 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Yu-hsin Wang 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s


[gem5-dev] Change in gem5/gem5[develop]: misc: Use a const char * in the m5op m5_add_symbol.

2020-03-27 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/27224 )



Change subject: misc: Use a const char * in the m5op m5_add_symbol.
..

misc: Use a const char * in the m5op m5_add_symbol.

The symbol name is not modified by the m5 op, so a const char * is more
accurate and gives the caller more flexibility as far as what they can
pass in.

Change-Id: Iee567bceef501643175dd5c65551a4c8554a6e3b
---
M include/gem5/m5ops.h
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/include/gem5/m5ops.h b/include/gem5/m5ops.h
index 440ea2d..1c08017 100644
--- a/include/gem5/m5ops.h
+++ b/include/gem5/m5ops.h
@@ -56,7 +56,7 @@
 void m5_debug_break(void);
 void m5_switch_cpu(void);
 void m5_dist_toggle_sync(void);
-void m5_add_symbol(uint64_t addr, char *symbol);
+void m5_add_symbol(uint64_t addr, const char *symbol);
 void m5_load_symbol();
 void m5_panic(void);
 void m5_work_begin(uint64_t workid, uint64_t threadid);

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27224
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iee567bceef501643175dd5c65551a4c8554a6e3b
Gerrit-Change-Number: 27224
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev