[gem5-dev] Change in gem5/gem5[develop]: scons: Call summarize_warnings() when scons finishes building.

2020-03-27 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/27130 )


Change subject: scons: Call summarize_warnings() when scons finishes  
building.

..

scons: Call summarize_warnings() when scons finishes building.

This will ensure that warnings are not all shoved off the end of the
scrollback buffer or lost in a sea of compiler lines, and that the user
will actually have a chance to see and read them.

Change-Id: I7129560482ebca903ec597f8b1cf8a9a84d98c9c
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/27130
Tested-by: kokoro 
Reviewed-by: Gabe Black 
Maintainer: Gabe Black 
---
M SConstruct
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Gabe Black: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/SConstruct b/SConstruct
index 8d5ac57..8be1ced 100755
--- a/SConstruct
+++ b/SConstruct
@@ -78,6 +78,7 @@
 from __future__ import print_function

 # Global Python includes
+import atexit
 import itertools
 import os
 import re
@@ -168,7 +169,7 @@
 AddLocalOption('--with-systemc-tests', dest='with_systemc_tests',
action='store_true', help='Build systemc tests')

-from gem5_scons import Transform, error, warning
+from gem5_scons import Transform, error, warning, summarize_warnings

 if GetOption('no_lto') and GetOption('force_lto'):
 error('--no-lto and --force-lto are mutually exclusive')
@@ -1274,3 +1275,5 @@

 %(local_vars)s
 ''' % help_texts)
+
+atexit.register(summarize_warnings)

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27130
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I7129560482ebca903ec597f8b1cf8a9a84d98c9c
Gerrit-Change-Number: 27130
Gerrit-PatchSet: 4
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: kokoro 
Gerrit-CC: Earl Ou 
Gerrit-CC: Jui-min Lee 
Gerrit-CC: Yu-hsin Wang 
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[develop]: scons: Call summarize_warnings() when scons finishes building.

2020-03-26 Thread Gabe Black (Gerrit)

Hello Gabe Black,

I'd like you to do a code review. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/27130

to review the following change.


Change subject: scons: Call summarize_warnings() when scons finishes  
building.

..

scons: Call summarize_warnings() when scons finishes building.

This will ensure that warnings are not all shoved off the end of the
scrollback buffer or lost in a sea of compiler lines, and that the user
will actually have a chance to see and read them.

Change-Id: I7129560482ebca903ec597f8b1cf8a9a84d98c9c
---
M SConstruct
1 file changed, 3 insertions(+), 0 deletions(-)



diff --git a/SConstruct b/SConstruct
index 8d5ac57..0f36eac 100755
--- a/SConstruct
+++ b/SConstruct
@@ -78,6 +78,7 @@
 from __future__ import print_function

 # Global Python includes
+import atexit
 import itertools
 import os
 import re
@@ -1274,3 +1275,5 @@

 %(local_vars)s
 ''' % help_texts)
+
+atexit.register(summarize_warnings)

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27130
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I7129560482ebca903ec597f8b1cf8a9a84d98c9c
Gerrit-Change-Number: 27130
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev