[gem5-dev] Change in gem5/gem5[develop]: scons: Get rid of a redundant "Warning:" in the SConstruct.

2020-03-27 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/27127 )


Change subject: scons: Get rid of a redundant "Warning:" in the SConstruct.
..

scons: Get rid of a redundant "Warning:" in the SConstruct.

The "warning()" method already prints "Warning:", so putting it in the
message itself means it gets printed twice.

Change-Id: Ic157355958fdf56739f865a926ecba071bb25c5e
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/27127
Reviewed-by: Nikos Nikoleris 
Maintainer: Bobby R. Bruce 
Tested-by: kokoro 
---
M SConstruct
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Nikos Nikoleris: Looks good to me, approved
  Bobby R. Bruce: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/SConstruct b/SConstruct
index f5eb0ca..8d5ac57 100755
--- a/SConstruct
+++ b/SConstruct
@@ -425,9 +425,9 @@
 disable_lto = GetOption('no_lto')
 if not disable_lto and main.get('BROKEN_INCREMENTAL_LTO', False) and \
 not GetOption('force_lto'):
-warning('Warning: Your compiler doesn\'t support incremental  
linking '
-'and lto at the same time, so lto is being disabled. To  
force '
-'lto on anyway, use the --force-lto option. That will  
disable '
+warning('Your compiler doesn\'t support incremental linking and  
lto '
+'at the same time, so lto is being disabled. To force lto  
on '

+'anyway, use the --force-lto option. That will disable '
 'partial linking.')
 disable_lto = True


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27127
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic157355958fdf56739f865a926ecba071bb25c5e
Gerrit-Change-Number: 27127
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Nikos Nikoleris 
Gerrit-Reviewer: kokoro 
Gerrit-CC: Earl Ou 
Gerrit-CC: Jui-min Lee 
Gerrit-CC: Yu-hsin Wang 
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[develop]: scons: Get rid of a redundant "Warning:" in the SConstruct.

2020-03-26 Thread Gabe Black (Gerrit)

Hello Gabe Black,

I'd like you to do a code review. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/27127

to review the following change.


Change subject: scons: Get rid of a redundant "Warning:" in the SConstruct.
..

scons: Get rid of a redundant "Warning:" in the SConstruct.

The "warning()" method already prints "Warning:", so putting it in the
message itself means it gets printed twice.

Change-Id: Ic157355958fdf56739f865a926ecba071bb25c5e
---
M SConstruct
1 file changed, 3 insertions(+), 3 deletions(-)



diff --git a/SConstruct b/SConstruct
index f5eb0ca..8d5ac57 100755
--- a/SConstruct
+++ b/SConstruct
@@ -425,9 +425,9 @@
 disable_lto = GetOption('no_lto')
 if not disable_lto and main.get('BROKEN_INCREMENTAL_LTO', False) and \
 not GetOption('force_lto'):
-warning('Warning: Your compiler doesn\'t support incremental  
linking '
-'and lto at the same time, so lto is being disabled. To  
force '
-'lto on anyway, use the --force-lto option. That will  
disable '
+warning('Your compiler doesn\'t support incremental linking and  
lto '
+'at the same time, so lto is being disabled. To force lto  
on '

+'anyway, use the --force-lto option. That will disable '
 'partial linking.')
 disable_lto = True


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27127
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic157355958fdf56739f865a926ecba071bb25c5e
Gerrit-Change-Number: 27127
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev