[gem5-dev] Change in gem5/gem5[develop]: util: Delete the execfile m5 utility command.

2020-04-27 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/27233 )


Change subject: util: Delete the execfile m5 utility command.
..

util: Delete the execfile m5 utility command.

This command was just a thin wrapper around the readfile command, and
can be easily duplicated by piping the output of that command to
/tmp/execfile and then running it.

Change-Id: Ib77166ee9f07571d57e4d21e9615def55e5391a8
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/27233
Maintainer: Gabe Black 
Tested-by: kokoro 
Reviewed-by: Bobby R. Bruce 
---
M util/m5/src/m5.c
1 file changed, 0 insertions(+), 20 deletions(-)

Approvals:
  Bobby R. Bruce: Looks good to me, approved
  Gabe Black: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/util/m5/src/m5.c b/util/m5/src/m5.c
index de382d0..6e3efac 100644
--- a/util/m5/src/m5.c
+++ b/util/m5/src/m5.c
@@ -226,23 +226,6 @@
 }

 void
-do_exec_file(int argc, char *argv[])
-{
-if (argc > 0)
-usage();
-
-const char *destname = "/tmp/execfile";
-
-int fid = open(destname, O_WRONLY, 0777);
-int len = read_file(fid);
-close(fid);
-if (len > 0) {
-execl(destname, "execfile", NULL);
-err(1, "execl failed!");
-}
-}
-
-void
 do_checkpoint(int argc, char *argv[])
 {
 uint64_t ints[2];
@@ -306,9 +289,6 @@
  "delay (default 0) dump the "
  "stats, and then optionally "
  "every period after" },
-{ "execfile",   do_exec_file,"read a preselected file  
into "
- "/tmp/execfile and then  
exec() "

- "it" },
 { "exit",   do_exit, "[delay] // Exit after  
delay, "

  "or immediately" },
 { "fail",   do_fail, " [delay] // Exit with "

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27233
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib77166ee9f07571d57e4d21e9615def55e5391a8
Gerrit-Change-Number: 27233
Gerrit-PatchSet: 11
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Earl Ou 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Yu-hsin Wang 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s


[gem5-dev] Change in gem5/gem5[develop]: util: Delete the execfile m5 utility command.

2020-03-27 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/27233 )



Change subject: util: Delete the execfile m5 utility command.
..

util: Delete the execfile m5 utility command.

This command was just a thin wrapper around the readfile command, and
can be easily duplicated by piping the output of that command to
/tmp/execfile and then running it.

Change-Id: Ib77166ee9f07571d57e4d21e9615def55e5391a8
---
M util/m5/src/m5.c
1 file changed, 0 insertions(+), 20 deletions(-)



diff --git a/util/m5/src/m5.c b/util/m5/src/m5.c
index de382d0..6e3efac 100644
--- a/util/m5/src/m5.c
+++ b/util/m5/src/m5.c
@@ -226,23 +226,6 @@
 }

 void
-do_exec_file(int argc, char *argv[])
-{
-if (argc > 0)
-usage();
-
-const char *destname = "/tmp/execfile";
-
-int fid = open(destname, O_WRONLY, 0777);
-int len = read_file(fid);
-close(fid);
-if (len > 0) {
-execl(destname, "execfile", NULL);
-err(1, "execl failed!");
-}
-}
-
-void
 do_checkpoint(int argc, char *argv[])
 {
 uint64_t ints[2];
@@ -306,9 +289,6 @@
  "delay (default 0) dump the "
  "stats, and then optionally "
  "every period after" },
-{ "execfile",   do_exec_file,"read a preselected file  
into "
- "/tmp/execfile and then  
exec() "

- "it" },
 { "exit",   do_exit, "[delay] // Exit after  
delay, "

  "or immediately" },
 { "fail",   do_fail, " [delay] // Exit with "

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27233
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib77166ee9f07571d57e4d21e9615def55e5391a8
Gerrit-Change-Number: 27233
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev