[gem5-dev] Change in public/gem5[master]: mem-cache: Create MRU replacement policy

2018-03-22 Thread Daniel Carvalho (Gerrit) 
Daniel Carvalho has submitted this change and it was merged. (  
https://gem5-review.googlesource.com/8889 )


Change subject: mem-cache: Create MRU replacement policy
..

mem-cache: Create MRU replacement policy

Implementation of a Most Recently Used replacement policy.

Change-Id: Id52cb247ca25d4523dcc53490d113695dac6a3f1
Reviewed-on: https://gem5-review.googlesource.com/8889
Reviewed-by: Jason Lowe-Power 
Reviewed-by: Nikos Nikoleris 
Maintainer: Nikos Nikoleris 
---
M src/mem/cache/replacement_policies/ReplacementPolicies.py
M src/mem/cache/replacement_policies/SConscript
A src/mem/cache/replacement_policies/mru_rp.cc
A src/mem/cache/replacement_policies/mru_rp.hh
4 files changed, 176 insertions(+), 0 deletions(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved
  Nikos Nikoleris: Looks good to me, approved; Looks good to me, approved



diff --git a/src/mem/cache/replacement_policies/ReplacementPolicies.py  
b/src/mem/cache/replacement_policies/ReplacementPolicies.py

index 6474381..1907c36 100644
--- a/src/mem/cache/replacement_policies/ReplacementPolicies.py
+++ b/src/mem/cache/replacement_policies/ReplacementPolicies.py
@@ -40,6 +40,11 @@
 cxx_class = 'LRURP'
 cxx_header = "mem/cache/replacement_policies/lru_rp.hh"

+class MRURP(BaseReplacementPolicy):
+type = 'MRURP'
+cxx_class = 'MRURP'
+cxx_header = "mem/cache/replacement_policies/mru_rp.hh"
+
 class RandomRP(BaseReplacementPolicy):
 type = 'RandomRP'
 cxx_class = 'RandomRP'
diff --git a/src/mem/cache/replacement_policies/SConscript  
b/src/mem/cache/replacement_policies/SConscript

index c3c8992..6f99110 100644
--- a/src/mem/cache/replacement_policies/SConscript
+++ b/src/mem/cache/replacement_policies/SConscript
@@ -34,4 +34,5 @@

 Source('base.cc')
 Source('lru_rp.cc')
+Source('mru_rp.cc')
 Source('random_rp.cc')
diff --git a/src/mem/cache/replacement_policies/mru_rp.cc  
b/src/mem/cache/replacement_policies/mru_rp.cc

new file mode 100644
index 000..0a89d43
--- /dev/null
+++ b/src/mem/cache/replacement_policies/mru_rp.cc
@@ -0,0 +1,87 @@
+/**
+ * Copyright (c) 2018 Inria
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met: redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer;
+ * redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution;
+ * neither the name of the copyright holders nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * Authors: Daniel Carvalho
+ */
+
+#include "mem/cache/replacement_policies/mru_rp.hh"
+
+#include "debug/CacheRepl.hh"
+
+MRURP::MRURP(const Params *p)
+: BaseReplacementPolicy(p)
+{
+}
+
+void
+MRURP::touch(CacheBlk *blk)
+{
+BaseReplacementPolicy::touch(blk);
+
+// Update last touch timestamp
+blk->lastTouchTick = curTick();
+}
+
+void
+MRURP::reset(CacheBlk *blk)
+{
+BaseReplacementPolicy::reset(blk);
+
+// Set last touch timestamp
+blk->lastTouchTick = blk->tickInserted;
+}
+
+CacheBlk*
+MRURP::getVictim(ReplacementCandidates& candidates)
+{
+// There must be at least one replacement candidate
+assert(candidates.size() > 0);
+
+// Visit all candidates to find victim
+CacheBlk* blk = candidates[0];
+for (const auto& candidate : candidates) {
+// Stop iteration if found an invalid block
+if (!candidate->isValid()) {
+blk = candidate;
+break;
+// Update victim block if necessary
+} else if (candidate->lastTouchTick > blk->lastTouchTick) {
+blk = candidate;
+}
+}
+
+DPRINTF(CacheRepl, "set %x, way %x: selecting blk for replacement\n",
+blk->set,

[gem5-dev] Change in public/gem5[master]: mem-cache: Create MRU replacement policy

2018-03-19 Thread Daniel Carvalho (Gerrit) 

Hello Jason Lowe-Power, Nikos Nikoleris,

I'd like you to reexamine a change. Please visit

https://gem5-review.googlesource.com/8889

to look at the new patch set (#3).

Change subject: mem-cache: Create MRU replacement policy
..

mem-cache: Create MRU replacement policy

Implementation of a Most Recently Used replacement policy.

Change-Id: Id52cb247ca25d4523dcc53490d113695dac6a3f1
---
M src/mem/cache/replacement_policies/ReplacementPolicies.py
M src/mem/cache/replacement_policies/SConscript
A src/mem/cache/replacement_policies/mru_rp.cc
A src/mem/cache/replacement_policies/mru_rp.hh
4 files changed, 176 insertions(+), 0 deletions(-)


--
To view, visit https://gem5-review.googlesource.com/8889
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Id52cb247ca25d4523dcc53490d113695dac6a3f1
Gerrit-Change-Number: 8889
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Carvalho 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Nikos Nikoleris 
Gerrit-MessageType: newpatchset
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in public/gem5[master]: mem-cache: Create MRU replacement policy

2018-03-13 Thread Daniel Carvalho (Gerrit) 
Daniel Carvalho has uploaded a new patch set (#2). (  
https://gem5-review.googlesource.com/8889 )


Change subject: mem-cache: Create MRU replacement policy
..

mem-cache: Create MRU replacement policy

Implementation of a Most Recently Used replacement policy.

Change-Id: Id52cb247ca25d4523dcc53490d113695dac6a3f1
---
M src/mem/cache/replacement_policies/ReplacementPolicies.py
M src/mem/cache/replacement_policies/SConscript
A src/mem/cache/replacement_policies/mru_rp.cc
A src/mem/cache/replacement_policies/mru_rp.hh
4 files changed, 143 insertions(+), 0 deletions(-)


--
To view, visit https://gem5-review.googlesource.com/8889
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Id52cb247ca25d4523dcc53490d113695dac6a3f1
Gerrit-Change-Number: 8889
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Carvalho 
Gerit-CC: Nikos Nikoleris 
Gerrit-MessageType: newpatchset
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in public/gem5[master]: mem-cache: Create MRU replacement policy

2018-03-09 Thread Daniel Carvalho (Gerrit) 
Daniel Carvalho has uploaded this change for review. (  
https://gem5-review.googlesource.com/8889



Change subject: mem-cache: Create MRU replacement policy
..

mem-cache: Create MRU replacement policy

Implementation of a Most Recently Used replacement policy.

Change-Id: Id52cb247ca25d4523dcc53490d113695dac6a3f1
---
M src/mem/cache/replacement_policies/ReplacementPolicies.py
M src/mem/cache/replacement_policies/SConscript
A src/mem/cache/replacement_policies/mru_rp.cc
A src/mem/cache/replacement_policies/mru_rp.hh
4 files changed, 144 insertions(+), 0 deletions(-)



diff --git a/src/mem/cache/replacement_policies/ReplacementPolicies.py  
b/src/mem/cache/replacement_policies/ReplacementPolicies.py

index 0faa524..7582ddc 100644
--- a/src/mem/cache/replacement_policies/ReplacementPolicies.py
+++ b/src/mem/cache/replacement_policies/ReplacementPolicies.py
@@ -40,6 +40,11 @@
 cxx_class = 'LRURP'
 cxx_header = "mem/cache/replacement_policies/lru_rp.hh"

+class MRURP(LRURP):
+type = 'MRURP'
+cxx_class = 'MRURP'
+cxx_header = "mem/cache/replacement_policies/mru_rp.hh"
+
 class RandomRP(BaseReplacementPolicy):
 type = 'RandomRP'
 cxx_class = 'RandomRP'
diff --git a/src/mem/cache/replacement_policies/SConscript  
b/src/mem/cache/replacement_policies/SConscript

index c3c8992..6f99110 100644
--- a/src/mem/cache/replacement_policies/SConscript
+++ b/src/mem/cache/replacement_policies/SConscript
@@ -34,4 +34,5 @@

 Source('base.cc')
 Source('lru_rp.cc')
+Source('mru_rp.cc')
 Source('random_rp.cc')
diff --git a/src/mem/cache/replacement_policies/mru_rp.cc  
b/src/mem/cache/replacement_policies/mru_rp.cc

new file mode 100644
index 000..7466647
--- /dev/null
+++ b/src/mem/cache/replacement_policies/mru_rp.cc
@@ -0,0 +1,70 @@
+/**
+ * Copyright (c) 2018 Inria
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met: redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer;
+ * redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution;
+ * neither the name of the copyright holders nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * Authors: Daniel Carvalho
+ */
+
+#include "mem/cache/replacement_policies/mru_rp.hh"
+
+#include "debug/CacheRepl.hh"
+
+MRURP::MRURP(const Params *p)
+: LRURP(p)
+{
+}
+
+CacheBlk*
+MRURP::getVictim(ReplacementCandidates cands)
+{
+// There must be at least one replacement candidate
+assert(cands.size() > 0);
+
+// Visit all candidates to find victim
+CacheBlk* blk = cands[0];
+for (auto it = cands.begin(); it != cands.end(); ++it) {
+// Stop iteration if found an invalid block
+if (!(*it)->isValid()) {
+blk = *it;
+break;
+// Update victim block if necessary
+} else if (!(*it)->isValid() or
+  ((*it)->lastTouchTick > blk->lastTouchTick)) {
+blk = *it;
+}
+}
+
+DPRINTF(CacheRepl, "set %x, way %x: selecting blk for replacement\n",
+blk->set, blk->way);
+
+return blk;
+}
+
+MRURP*
+MRURPParams::create()
+{
+return new MRURP(this);
+}
diff --git a/src/mem/cache/replacement_policies/mru_rp.hh  
b/src/mem/cache/replacement_policies/mru_rp.hh

new file mode 100644
index 000..bb19fef
--- /dev/null
+++ b/src/mem/cache/replacement_policies/mru_rp.hh
@@ -0,0 +1,68 @@
+/**
+ * Copyright (c) 2018 Inria
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met: redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer;
+ *