[gem5-dev] Re: Build failed in Jenkins: nightly #307

2021-05-13 Thread Bobby Bruce via gem5-dev
Cool, thanks for the help. I believe this patch should fix the nightlys: https://gem5-review.googlesource.com/c/public/gem5/+/45480 -- Dr. Bobby R. Bruce Room 3050, Kemper Hall, UC Davis Davis, CA, 95616 web: https://www.bobbybruce.net On Tue, May 11, 2021 at 7:27 PM Gabe Black wrote: > Yes,

[gem5-dev] Re: Build failed in Jenkins: nightly #307

2021-05-11 Thread Gabe Black via gem5-dev
Yes, I think Daniel has the right diagnosis. Gabe On Tue, May 11, 2021 at 1:47 PM Daniel Carvalho wrote: > Hi, Bobby, > > Previous to that patch, enabled() (now tracing()) checked if the flag was > globally enabled and if it had been individually enabled, and the tracing > check was done

[gem5-dev] Re: Build failed in Jenkins: nightly #307

2021-05-11 Thread Daniel Carvalho via gem5-dev
Hi, Bobby, Previous to that patch, enabled() (now tracing()) checked if the flag was globally enabled and if it had been individually enabled, and the tracing check was done elsewhere (DTRACE(flag) did that). Now tracing() is checking both conditions AND if tracing is on, which is likely a

[gem5-dev] Re: Build failed in Jenkins: nightly #307

2021-05-11 Thread Bobby Bruce via gem5-dev
Hey Daniel and Gabe, I'm looking into this test failure (reproducible with `scons build/NULL/unittests.fast`). I'm a little confused about how these tests ever passed. This patchet introduces the error (or at least, if this patch is reverted, the tests pass):