Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-29 Thread Andreas Hansson via gem5-dev
On Nov. 20, 2014, 8:54 p.m., Cagdas Dirik wrote: I am afraid you have to move config_manager-instantiate() call into SimControl::run() after wait. Currently it is tripping at: fatal condition !eventq-empty() occurred: There must be no posted events before SimControl::run @ tick 0

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-25 Thread Cagdas Dirik via gem5-dev
On Nov. 20, 2014, 8:54 p.m., Cagdas Dirik wrote: I am afraid you have to move config_manager-instantiate() call into SimControl::run() after wait. Currently it is tripping at: fatal condition !eventq-empty() occurred: There must be no posted events before SimControl::run @ tick 0

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-20 Thread Andrew Bardsley via gem5-dev
On Nov. 19, 2014, 12:22 a.m., Cagdas Dirik wrote: Please ignore my last review. I made a mistake with my patches. In FS, X86 mode I was able to boot with python variant, checkpoint, run a short program. Then I was able to restore from checkpoint and run the same program again. And

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-20 Thread Andrew Bardsley via gem5-dev
On Nov. 19, 2014, 12:22 a.m., Cagdas Dirik wrote: Please ignore my last review. I made a mistake with my patches. In FS, X86 mode I was able to boot with python variant, checkpoint, run a short program. Then I was able to restore from checkpoint and run the same program again. And

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-20 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2504/ --- (Updated Nov. 20, 2014, 3:48 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-20 Thread Cagdas Dirik via gem5-dev
On Nov. 19, 2014, 12:22 a.m., Cagdas Dirik wrote: Please ignore my last review. I made a mistake with my patches. In FS, X86 mode I was able to boot with python variant, checkpoint, run a short program. Then I was able to restore from checkpoint and run the same program again. And

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-20 Thread Cagdas Dirik via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2504/#review5510 --- I am afraid you have to move config_manager-instantiate() call into

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-20 Thread Andreas Hansson via gem5-dev
On Nov. 20, 2014, 8:54 p.m., Cagdas Dirik wrote: I am afraid you have to move config_manager-instantiate() call into SimControl::run() after wait. Currently it is tripping at: fatal condition !eventq-empty() occurred: There must be no posted events before SimControl::run @ tick 0

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-20 Thread Cagdas Dirik via gem5-dev
On Nov. 20, 2014, 8:54 p.m., Cagdas Dirik wrote: I am afraid you have to move config_manager-instantiate() call into SimControl::run() after wait. Currently it is tripping at: fatal condition !eventq-empty() occurred: There must be no posted events before SimControl::run @ tick 0

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-20 Thread Andreas Hansson via gem5-dev
On Nov. 20, 2014, 8:54 p.m., Cagdas Dirik wrote: I am afraid you have to move config_manager-instantiate() call into SimControl::run() after wait. Currently it is tripping at: fatal condition !eventq-empty() occurred: There must be no posted events before SimControl::run @ tick 0

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-20 Thread Andrew Bardsley via gem5-dev
To: Cagdas Dirik; Andreas Hansson; Default Subject: Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling On Nov. 20, 2014, 8:54 p.m., Cagdas Dirik wrote: I am afraid you have to move config_manager-instantiate() call into SimControl::run() after wait

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-20 Thread Cagdas Dirik via gem5-dev
On Nov. 20, 2014, 8:54 p.m., Cagdas Dirik wrote: I am afraid you have to move config_manager-instantiate() call into SimControl::run() after wait. Currently it is tripping at: fatal condition !eventq-empty() occurred: There must be no posted events before SimControl::run @ tick 0

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-19 Thread Andrew Bardsley via gem5-dev
On Nov. 19, 2014, 12:22 a.m., Cagdas Dirik wrote: Please ignore my last review. I made a mistake with my patches. In FS, X86 mode I was able to boot with python variant, checkpoint, run a short program. Then I was able to restore from checkpoint and run the same program again. And

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-19 Thread Andrew Bardsley via gem5-dev
On Nov. 19, 2014, 12:22 a.m., Cagdas Dirik wrote: Please ignore my last review. I made a mistake with my patches. In FS, X86 mode I was able to boot with python variant, checkpoint, run a short program. Then I was able to restore from checkpoint and run the same program again. And

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-19 Thread Cagdas Dirik via gem5-dev
On Nov. 19, 2014, 12:22 a.m., Cagdas Dirik wrote: Please ignore my last review. I made a mistake with my patches. In FS, X86 mode I was able to boot with python variant, checkpoint, run a short program. Then I was able to restore from checkpoint and run the same program again. And

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-19 Thread Cagdas Dirik via gem5-dev
On Nov. 19, 2014, 12:22 a.m., Cagdas Dirik wrote: Please ignore my last review. I made a mistake with my patches. In FS, X86 mode I was able to boot with python variant, checkpoint, run a short program. Then I was able to restore from checkpoint and run the same program again. And

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-18 Thread Andrew Bardsley via gem5-dev
happening before the simulation starts running. - Andrew -Original Message- From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Cagdas Dirik via gem5-dev Sent: 17 November 2014 23:45 To: Cagdas Dirik; Andreas Hansson; Default Subject: Re: [gem5-dev] Review Request 2504: config: Fix

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-18 Thread Cagdas Dirik (cdirik) via gem5-dev
Message- From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Cagdas Dirik via gem5-dev Sent: 17 November 2014 23:45 To: Cagdas Dirik; Andreas Hansson; Default Subject: Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-18 Thread Cagdas Dirik via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2504/#review5479 --- I think there are still synchronization issues with curTick and systemc

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-17 Thread Cagdas Dirik via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2504/#review5460 --- I think you are missing the call to

[gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-16 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2504/ --- Review request for Default. Repository: gem5 Description --- Changeset