Re: [gem5-dev] Review Request 2646: mem: Split port retry for all different packet classes

2015-02-08 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2646/ --- (Updated Feb. 8, 2015, 5:48 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2646: mem: Split port retry for all different packet classes

2015-02-08 Thread Andreas Hansson via gem5-dev
On Feb. 7, 2015, 6:14 p.m., Steve Reinhardt wrote: Awesome! This lack of separate channels for requests responses has bugged me for years, I'm really glad to see it addressed. One minor suggestion: to me, terms like recvRetryReq and recvRetryResp seem backward, since 'retry' is

Re: [gem5-dev] Review Request 2646: mem: Split port retry for all different packet classes

2015-02-07 Thread Steve Reinhardt via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2646/#review5867 --- Awesome! This lack of separate channels for requests responses has

Re: [gem5-dev] Review Request 2646: mem: Split port retry for all different packet classes

2015-02-07 Thread Steve Reinhardt via gem5-dev
On Feb. 7, 2015, 10:14 a.m., Steve Reinhardt wrote: Awesome! This lack of separate channels for requests responses has bugged me for years, I'm really glad to see it addressed. One minor suggestion: to me, terms like recvRetryReq and recvRetryResp seem backward, since 'retry' is

[gem5-dev] Review Request 2646: mem: Split port retry for all different packet classes

2015-02-07 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2646/ --- Review request for Default. Repository: gem5 Description --- Changeset