Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

2016-10-19 Thread Steve Reinhardt 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3660/#review8928
---

Ship it!


Ship It!

- Steve Reinhardt


On Oct. 17, 2016, 8:07 a.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3660/
> ---
> 
> (Updated Oct. 17, 2016, 8:07 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11689:579f5d74b7a6
> ---
> style: [patch 1/22] use /r/3648/ to reorganize includes
> 
> 
> Diffs
> -
> 
>   src/cpu/static_inst.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/DirectedGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/InvalidateGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/RubyDirectedTester.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/SeriesRequestGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/memtest/memtest.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/Check.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/CheckTable.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/RubyTester.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/traffic_gen/generators.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/thread_context.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/thread_state.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/timing_expr.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/backdoor.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/a9scu.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/amba_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/amba_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/energy_ctrl.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/gic_pl390.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/hdlcd.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/kmi.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/pl011.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/pl111.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/realview.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/rtc_pl031.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/timer_cpulocal.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/timer_sp804.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/vgic.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/baddev.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/intel_8254_timer.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/io_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/isa_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mc146818.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/pci/device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/pci/host.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/platform.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/ps2.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/ps2.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/dtod.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/iob.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/mm_disk.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/t1000.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/uart.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/uart8250.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/base.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/block.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/console.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/fs9p.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/pci.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/x86/cmos.cc

Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

2016-10-17 Thread Jason Lowe-Power 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3660/#review8883
---

Ship it!


Ship It!

- Jason Lowe-Power


On Oct. 17, 2016, 3:07 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3660/
> ---
> 
> (Updated Oct. 17, 2016, 3:07 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11689:579f5d74b7a6
> ---
> style: [patch 1/22] use /r/3648/ to reorganize includes
> 
> 
> Diffs
> -
> 
>   src/cpu/static_inst.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/DirectedGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/InvalidateGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/RubyDirectedTester.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/SeriesRequestGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/memtest/memtest.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/Check.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/CheckTable.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/RubyTester.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/traffic_gen/generators.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/thread_context.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/thread_state.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/timing_expr.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/backdoor.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/a9scu.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/amba_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/amba_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/energy_ctrl.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/gic_pl390.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/hdlcd.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/kmi.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/pl011.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/pl111.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/realview.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/rtc_pl031.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/timer_cpulocal.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/timer_sp804.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/vgic.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/baddev.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/intel_8254_timer.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/io_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/isa_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mc146818.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/pci/device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/pci/host.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/platform.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/ps2.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/ps2.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/dtod.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/iob.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/mm_disk.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/t1000.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/uart.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/uart8250.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/base.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/block.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/console.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/fs9p.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/pci.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/x86/cmos.cc

Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

2016-10-17 Thread Tony Gutierrez 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3660/#review8868
---

Ship it!


Ship It!

- Tony Gutierrez


On Oct. 17, 2016, 8:07 a.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3660/
> ---
> 
> (Updated Oct. 17, 2016, 8:07 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11689:579f5d74b7a6
> ---
> style: [patch 1/22] use /r/3648/ to reorganize includes
> 
> 
> Diffs
> -
> 
>   src/cpu/static_inst.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/DirectedGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/InvalidateGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/RubyDirectedTester.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/SeriesRequestGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/memtest/memtest.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/Check.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/CheckTable.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/RubyTester.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/traffic_gen/generators.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/thread_context.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/thread_state.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/timing_expr.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/backdoor.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/a9scu.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/amba_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/amba_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/energy_ctrl.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/gic_pl390.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/hdlcd.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/kmi.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/pl011.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/pl111.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/realview.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/rtc_pl031.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/timer_cpulocal.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/timer_sp804.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/vgic.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/baddev.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/intel_8254_timer.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/io_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/isa_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mc146818.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/pci/device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/pci/host.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/platform.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/ps2.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/ps2.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/dtod.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/iob.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/mm_disk.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/t1000.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/uart.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/uart8250.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/base.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/block.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/console.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/fs9p.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/pci.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/x86/cmos.cc

Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

2016-10-17 Thread Michael LeBeane 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3660/#review8861
---

Ship it!


Ship It!

- Michael LeBeane


On Oct. 17, 2016, 3:07 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3660/
> ---
> 
> (Updated Oct. 17, 2016, 3:07 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11689:579f5d74b7a6
> ---
> style: [patch 1/22] use /r/3648/ to reorganize includes
> 
> 
> Diffs
> -
> 
>   src/cpu/static_inst.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/DirectedGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/InvalidateGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/RubyDirectedTester.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/directedtest/SeriesRequestGenerator.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/memtest/memtest.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/Check.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/CheckTable.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/rubytest/RubyTester.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/testers/traffic_gen/generators.cc 
> 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/thread_context.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/thread_state.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/cpu/timing_expr.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/backdoor.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/alpha/tsunami_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/a9scu.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/amba_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/amba_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/energy_ctrl.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/gic_pl390.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/hdlcd.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/kmi.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/pl011.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/pl111.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/realview.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/rtc_pl031.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/timer_cpulocal.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/timer_sp804.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/arm/vgic.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/baddev.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/intel_8254_timer.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/io_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/isa_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mc146818.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/mips/malta_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/pci/device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/pci/host.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/platform.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/ps2.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/ps2.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/dtod.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/iob.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/mm_disk.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/sparc/t1000.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/uart.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/uart8250.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/base.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/block.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/console.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/fs9p.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/virtio/pci.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/dev/x86/cmos.cc

Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

2016-10-17 Thread Brandon Potter 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3660/
---

(Updated Oct. 17, 2016, 3:07 p.m.)


Review request for Default.


Summary (updated)
-

style: [patch 1/22] use /r/3648/ to reorganize includes


Repository: gem5


Description (updated)
---

Changeset 11689:579f5d74b7a6
---
style: [patch 1/22] use /r/3648/ to reorganize includes


Diffs (updated)
-

  src/cpu/static_inst.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/directedtest/DirectedGenerator.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/directedtest/InvalidateGenerator.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/directedtest/RubyDirectedTester.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/directedtest/SeriesRequestGenerator.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/memtest/memtest.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/rubytest/Check.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/rubytest/CheckTable.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/rubytest/RubyTester.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/testers/traffic_gen/generators.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/thread_context.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/thread_state.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/cpu/timing_expr.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/alpha/backdoor.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/alpha/tsunami.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/alpha/tsunami_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/alpha/tsunami_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/a9scu.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/amba_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/amba_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/energy_ctrl.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/gic_pl390.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/hdlcd.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/kmi.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/pl011.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/pl111.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/realview.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/rtc_pl031.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/timer_cpulocal.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/timer_sp804.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/arm/vgic.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/baddev.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/intel_8254_timer.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/io_device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/isa_fake.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/mc146818.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/mips/malta.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/mips/malta_cchip.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/mips/malta_io.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/pci/device.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/pci/host.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/platform.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/ps2.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/ps2.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/sparc/dtod.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/sparc/iob.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/sparc/mm_disk.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/sparc/t1000.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/uart.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/uart8250.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/virtio/base.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/virtio/block.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/virtio/console.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/virtio/fs9p.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/virtio/pci.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/x86/cmos.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/x86/i8042.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/x86/i82094aa.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/x86/i8237.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/x86/i8254.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/x86/i8259.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/dev/x86/pc.cc

Re: [gem5-dev] Review Request 3660: style: [patch 1/~22] use /r/3648/ to reorganize includes

2016-10-17 Thread Brandon Potter 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3660/
---

(Updated Oct. 17, 2016, 3:03 p.m.)


Review request for Default.


Summary (updated)
-

style: [patch 1/~22] use /r/3648/ to reorganize includes


Repository: gem5


Description (updated)
---

Changeset 11689:36fcc24cd120
---
style: [patch 1/~22] use /r/3648/ to reorganize includes


Diffs (updated)
-

  src/mem/ruby/network/Network.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/network/Topology.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/network/simple/PerfectSwitch.hh 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/network/simple/PerfectSwitch.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/network/simple/SimpleNetwork.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/network/simple/Switch.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/network/simple/Throttle.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/profiler/AccessTraceForAddress.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/profiler/AddressProfiler.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/profiler/StoreTrace.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/slicc_interface/AbstractController.hh 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/slicc_interface/AbstractController.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/slicc_interface/RubyRequest.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/BankedArray.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/CacheMemory.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/DirectoryMemory.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/LRUPolicy.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/Prefetcher.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/PseudoLRUPolicy.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/RubyMemoryControl.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/structures/WireBuffer.cc 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/system/CacheRecorder.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/system/DMASequencer.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/system/RubyPort.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/ruby/system/Sequencer.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/se_translating_port_proxy.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/serial_link.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/simple_mem.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/slicc/symbols/StateMachine.py 
4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/snoop_filter.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/tport.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/mem/xbar.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/proto/protoio.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/python/swig/pyevent.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/python/swig/pyevent.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/python/swig/pyobject.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/arguments.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/backtrace_glibc.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/clock_domain.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/core.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/cxx_manager.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/debug.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/dvfs_handler.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/init.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/probe/probe.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/pseudo_inst.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/py_interact.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/root.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/serialize.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/sim_events.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/sim_object.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/simulate.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/stat_control.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/stat_control.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/sub_system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/voltage_domain.cc