Re: [m5-dev] m5: port: Clean up default port setup and port switchover code.

2008-06-16 Thread nathan binkert
I don't think this works, given that you've (still) got a single global static instance of DefaultPeerPort... right? I ask because this patch looks frighteningly familiar... I just did the same thing last week (including the identical class rename :-) ) but mine was more complicated because

[m5-dev] [PATCH 3 of 3] imported patch rename_mips_console.diff

2008-06-16 Thread Nathan Binkert
# HG changeset patch # User Nathan Binkert [EMAIL PROTECTED] # Date 1213635026 25200 # Node ID a2e7f8c2bc7b1b44228303394797261f1f2b09d3 # Parent 4eebad63fad5463724fb64fdd1c6f923cd8df1f2 imported patch rename_mips_console.diff diff --git a/src/dev/mips/MipsConsole.py

[m5-dev] [PATCH 1 of 3] Rename SimConsole to Terminal since it makes more sense

2008-06-16 Thread Nathan Binkert
# HG changeset patch # User Nathan Binkert [EMAIL PROTECTED] # Date 1213635025 25200 # Node ID 5ffbff2e6cada183d53f894f6458e8ad0ec20700 # Parent dc04d655315a1145c381bedbebbcc93bffd78fed Rename SimConsole to Terminal since it makes more sense diff --git a/configs/common/FSConfig.py

[m5-dev] [PATCH 2 of 2] Fix tests script to deal with changes in default file names

2008-06-16 Thread Nathan Binkert
# HG changeset patch # User Nathan Binkert [EMAIL PROTECTED] # Date 1213638368 25200 # Node ID 148a05f7dfb91fc2084bdb9abc913070806c727b # Parent d98970506a49bae1b7d9186a3f479a272cfb3485 Fix tests script to deal with changes in default file names diff --git a/tests/SConscript b/tests/SConscript

Re: [m5-dev] m5: port: Clean up default port setup and port switchover code.

2008-06-16 Thread Steve Reinhardt
I was strictly talking about the port.cc changes... my diff doesn't touch base.cc, and I don't think it does much in port.hh either. So in that context, your answer seems to be no... Steve On Mon, Jun 16, 2008 at 11:33 AM, nathan binkert [EMAIL PROTECTED] wrote: Is there anything in your

Re: [m5-dev] [PATCH 0 of 3] Sort out the name console

2008-06-16 Thread Ali Saidi
On Jun 16, 2008, at 1:01 PM, Nathan Binkert wrote: I mentioned in a e-mail last night that I'd like to rename the various things that are called console so that the names are not as ambiguous. The following renames apply: SimConsole - Terminal AlphaConsole - AlphaBackdoor MipsConsole -

Re: [m5-dev] [PATCH 0 of 3] Sort out the name console

2008-06-16 Thread nathan binkert
I mentioned in a e-mail last night that I'd like to rename the various things that are called console so that the names are not as ambiguous. The following renames apply: SimConsole - Terminal AlphaConsole - AlphaBackdoor MipsConsole - MipsBackdoor Everyone OK with this? I'm fine with

Re: [m5-dev] [PATCH 0 of 2] Change default output directory and output files

2008-06-16 Thread nathan binkert
Long ago, we discussed changing the default output directory and the names of some default output files. I think I suggested m5out, but I'm not crazy about it. Is there something you like more? I'm fine with m5out. I kind of like extensions on the names. stats.out seems more satisfying to