[m5-dev] Cron m5t...@zizzer /z/m5/regression/do-regression quick

2010-12-29 Thread Cron Daemon
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/inorder-timing passed. * build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/o3-timing passed. * build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/simple-atomic passed. *

[m5-dev] Possible Problem with M5's Prefetching Mechanism

2010-12-29 Thread zhanglunkai
Hi, I am adding a new prefetcher to m5 system. However it seems m5's current cache implementation does not fully support the prefetching mechanism. The problem is happening if a writeback request comes to cache while the cache is issuing a prefetching on the same address. The writeback request

[m5-dev] Review Request: Add seed option to ruby_random_test.py

2010-12-29 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/361/ --- Review request for Default. Summary --- This patch adds an option to the

Re: [m5-dev] Fwd: Sorted includes

2010-12-29 Thread Steve Reinhardt
Plain textual sort please. I don't completely follow the distinction here, but I'm guessing that it's pretty subtle at best, and not worth requiring something more than M-x sort-lines or equivalent to maintain compliance with. Steve On Tue, Dec 28, 2010 at 11:05 AM, nathan binkert

Re: [m5-dev] Possible Problem with M5's Prefetching Mechanism

2010-12-29 Thread Steve Reinhardt
Good catch... it's true that we don't typically run with the prefetcher on, so it's not too surprising that there are some subtle latent bugs. It seems to me like the easiest fix would be to detect on a prefetch response that the cache already has valid data and just throw the prefetch away.

Re: [m5-dev] Review Request: util: python implementation of a routine that will sort includes

2010-12-29 Thread Steve Reinhardt
On Mon, Dec 27, 2010 at 11:56 AM, nathan binkert n...@binkert.org wrote: I like the former idea... just plain README as a filename seems good enough to me. The latter idea (putting it in the root directory with GENERATED in the name) has the problem that if you don't know that you're

Re: [m5-dev] Sorted includes

2010-12-29 Thread nathan binkert
Plain textual sort please.  I don't completely follow the distinction here, but I'm guessing that it's pretty subtle at best, and not worth requiring something more than M-x sort-lines or equivalent to maintain compliance with. I was basically trying to implement something like what you had

Re: [m5-dev] Review Request: util: python implementation of a routine that will sort includes

2010-12-29 Thread nathan binkert
My main point is that the location is what matters most.  If you're agreeing that putting something in the directories where the generated files might be is the right thing to do?  In that case, I don't think that the filename matters that much; README is fine, MISSING_FILES is probably

Re: [m5-dev] Sorted includes

2010-12-29 Thread Steve Reinhardt
On Wed, Dec 29, 2010 at 1:32 PM, nathan binkert n...@binkert.org wrote: Plain textual sort please. I don't completely follow the distinction here, but I'm guessing that it's pretty subtle at best, and not worth requiring something more than M-x sort-lines or equivalent to maintain

Re: [m5-dev] Review Request: Add seed option to ruby_random_test.py

2010-12-29 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/361/#review583 --- Ship it! I assume that this works. One thing that I will say is that we

Re: [m5-dev] Sorted includes

2010-12-29 Thread nathan binkert
Wow, I forgot I had written that... it was only seven years ago. Yeah. Me too. I only noticed it when I wrote the new version and noticed that tab completion didn't work trivially. I guess it does make some sense to have the includes with paths before the ones that are in the local